AlliedModders

AlliedModders (https://forums.alliedmods.net/index.php)
-   New Plugin Submissions (https://forums.alliedmods.net/forumdisplay.php?f=26)
-   -   Galileo v5.9.1-925 (a feature rich map voting plugin) | Last Update: 2018-07-16 (https://forums.alliedmods.net/showthread.php?t=273019)

Old.School 02-14-2016 08:31

Re: Galileo v1.2.1 | Last Update: 11.02.2016
 
[SUG]
add cvar rtv wait type 1 = time 2 = rounds

addons_zz 02-14-2016 08:39

Re: Galileo v1.2.1 | Last Update: 11.02.2016
 
Noted:
******************************** TODO Go to top *********************************
Code:

* Add a new cvar RTV wait 'gal_rtv_wait_rounds'.

Old.School 02-14-2016 09:39

Re: Galileo v1.2.1 | Last Update: 11.02.2016
 
bug report :
using mp_maxrounds...
when the vote started by rtv vote work but the map didn't change + when the vote end mp_maxrounds is not "0"

another bug :
exemple mp_maxrounds 40 rounds left = 20 admin used sv_restart 1 = rounds left is 40 now

addons_zz 02-14-2016 10:17

Re: Galileo v1.2.1 | Last Update: 11.02.2016
 
Quote:

Originally Posted by Old.School (Post 2392891)
bug report :
another bug :
exemple mp_maxrounds 40 rounds left = 20 admin used sv_restart 1 = rounds left is 40 now

Well, that is the expected behavior. It is the same as time timelimit. Example mp_timelimt 40 minutes. And time left = 20, admin used sv_restart 1 = time limit is 40 now.

Quote:

Originally Posted by Old.School (Post 2392891)
+ when the vote end mp_maxrounds is not "0"

I did not understand what do you mean by: the vote end mp_maxrounds is not "0".

Why it should be 0?

When the vote end, the remaining rounds are played until there is any rounds left. The voting start about when there are 4 or 5 rounds reaming.

Quote:

Originally Posted by Old.School (Post 2392891)
bug report :
using mp_maxrounds...
when the vote started by rtv vote work but the map didn't change

That is a bug, It will be fixed at next 30 minutes.

Old.School 02-14-2016 10:21

Re: Galileo v1.2.1 | Last Update: 11.02.2016
 
what i mean with : + when the vote end mp_maxrounds is not "0"
when the vote end on the oroginal galileo mp_timelimit will be 0 for when the player type timeleft in the chat he will display : No Time Limit

addons_zz 02-14-2016 12:28

Re: Galileo v1.2.2 | Last Update: 11.02.2016
 
Released a new hotfix version:
Code:

2016-02-11 | v1.2.2
 * Add a new cvar RTV wait 'gal_rtv_wait_rounds'.
 * Fixed bug when the vote started by rtv vote work but the map didn't change.

Quote:

Originally Posted by Old.School (Post 2392902)
when the vote end on the oroginal galileo mp_timelimit will be 0 for when the player type timeleft in the chat he will display : No Time Limit

The time limit will be zero, if have the 'gal_endonround' cvar enabled and the current round is the last round. This usually happens near the map voting.

But if at the original plugin, the timelimit is set to zero during the voting, it was a bug. The timelimit is set to zero only when the allow last round feature is enabled (gal_endonround cited above).

But I think I understand you now, the 'mp_maxrounds' and 'mp_winlimit' must be setted to "0" to avoid the map ending during the last voting. But the map voting starts 4 or 5 rounds before the 'mp_maxrounds' and 'mp_winlimit' to be reached. So it is not a problem.

Old.School 02-14-2016 16:32

Re: Galileo v1.2.2 | Last Update: 11.02.2016
 
Another SUG :
add Cvar to control sv_restart
using rounds exmple : mp_maxrounds 40 and 20 rounds passed and admin used sv_restart
if the cvar is 1 the rounds left will be 20
if the cvar is 0 the rounds left will 40

addons_zz 02-14-2016 16:37

Re: Galileo v1.2.2 | Last Update: 11.02.2016
 
Noted:
******************************** TODO Go to top *********************************
Code:

* add Cvar to control sv_restart
  using rounds exmple : mp_maxrounds 40 and 20 rounds passed and admin used sv_restart
  if the cvar is 1 the rounds left will be 20
  if the cvar is 0 the rounds left will 40


Old.School 02-14-2016 16:53

Re: Galileo v1.2.2 | Last Update: 11.02.2016
 
[SUG]
add two cvars the first one :
if 1 and the Cvar control sv_restart is 1 too next the sv restart he will add x rounds/time to mp_maxrounds /mp_timelimit
the second cvar is the x rounds/time if the first cvar is 1

addons_zz 02-14-2016 16:58

Re: Galileo v1.2.2 | Last Update: 11.02.2016
 
Noted:
******************************** TODO Go to top *********************************
Code:

* add Cvar to control sv_restart
  using rounds exmple : mp_maxrounds 40 and 20 rounds passed and admin used sv_restart
  if the cvar is 1 the rounds left will be 20
  if the cvar is 0 the rounds left will 40
 * add two cvars the first one :
  if 1 and the Cvar control sv_restart is 1 too next the sv restart he will add x rounds/time to mp_maxrounds /mp_timelimit
  the second cvar is the x rounds/time if the first cvar is 1


Old.School 02-14-2016 17:22

Re: Galileo v1.2.2 | Last Update: 11.02.2016
 
Bug Report :
gal_rtv_wait is 0
gal_rtv_wait_rounds is 30
and when you type rtv : You have to wait approximately 10 more minutes before you can 'rock the vote'.
i think you should add cvar to select rounds or timelimit
if rounds : You have to wait approximately x more rounds before you can 'rock the vote'.
if time limit : You have to wait approximately x more minutes before you can 'rock the vote'.

addons_zz 02-14-2016 17:37

Re: Galileo v1.2.2 | Last Update: 11.02.2016
 
Actually, it's just looks like 10 minutes, but are your rounds. It is because I did not create a new LANG file to show 'rounds' instead of 'minutes', when you are using rounds. But, the timelimit has priority if you use both 'mp_timelimit' and 'mp_maxrounds'. So, if you disable the timelimit, then it will wait 'gal_rtv_wait_rounds'.

And I think I found your problem. I cache the 'gal_rtv_wait_rounds' while reading the 'galileo.cfg' file when the server starts. So if you change it in-game, not in the 'galileo.cfg' file before to start the server, it will not use your values never.

But there is a bug, where 'gal_rtv_wait_rounds' has priority over 'gal_rtv_wait'. I fixed it here: https://github.com/addonszz/Galileo/tree/develop

As it is a really small fix, I will update here another day/week/month/year.

Old.School 02-14-2016 18:02

Re: Galileo v1.2.2 | Last Update: 11.02.2016
 
i know about the lang and i ask you to add it

addons_zz 02-14-2016 18:05

Re: Galileo v1.2.2 | Last Update: 11.02.2016
 
As it is a really small fix, it goes to the TODO list. It will be released here on the next version. The next version will be released when there are several accumulated changes.

******************************** TODO Go to top *********************************
Code:

* Add Cvar to control sv_restart
  using rounds exmple : mp_maxrounds 40 and 20 rounds passed and admin used sv_restart
  if the cvar is 1 the rounds left will be 20
  if the cvar is 0 the rounds left will 40
 * Add two cvars the first one :
  if 1 and the Cvar control sv_restart is 1 too next the sv restart he will add x rounds/time to mp_maxrounds /mp_timelimit
  the second cvar is the x rounds/time if the first cvar is 1
 * Create a new LANG file to show 'rounds' instead of 'minutes', when you are using rounds.


Old.School 02-14-2016 18:41

Re: Galileo v1.2.2 | Last Update: 11.02.2016
 
[SUG]
gal_cancelvote to cancel the vote

addons_zz 02-14-2016 18:48

Re: Galileo v1.2.2 | Last Update: 11.02.2016
 
It is an admin command to cancel the current voting?

******************************** TODO Go to top *********************************
Code:

* Add Cvar to control sv_restart
  using rounds exmple : mp_maxrounds 40 and 20 rounds passed and admin used sv_restart
  if the cvar is 1 the rounds left will be 20
  if the cvar is 0 the rounds left will 40
 * Add two cvars the first one :
  if 1 and the Cvar control sv_restart is 1 too next the sv restart he will add x rounds/time to mp_maxrounds /mp_timelimit
  the second cvar is the x rounds/time if the first cvar is 1
 * Create a new LANG file to show 'rounds' instead of 'minutes', when you are using rounds.
 * Add an admin command 'gal_cancelvote' to cancel the current vote.


Old.School 02-14-2016 18:53

Re: Galileo v1.2.2 | Last Update: 11.02.2016
 
4 feautures i think its enough to release the next version

addons_zz 02-14-2016 20:30

Re: Galileo v1.2.2 | Last Update: 11.02.2016
 
Now you got me on this one. So, let us take a break for some days and see if something else comes out to attention.

Old.School 02-15-2016 06:50

Re: Galileo v1.2.2 | Last Update: 11.02.2016
 
i know you think those features not necessary and can wait but i think this feature is necessary :

* Add Cvar to control sv_restart
using rounds exmple : mp_maxrounds 40 and 20 rounds passed and admin used sv_restart
if the cvar is 1 the rounds left will be 20
if the cvar is 0 the rounds left will 40

and this is new suggestion for your attention hahah :p :
rtv not work if admin have flag change map online with enable cvar and print...lang some thing like you cannot rock the vote when the admin is online

addons_zz 02-15-2016 07:27

Re: Galileo v1.2.2 | Last Update: 11.02.2016
 
Quote:

Originally Posted by Old.School (Post 2393133)
rtv not work if admin have flag change map online

RTV is working if admins are online.

Quote:

Originally Posted by Old.School (Post 2393133)
if admin have flag change map online with enable cvar and print...lang

What cvar enabled?

Quote:

Originally Posted by Old.School (Post 2393133)
if admin have flag change map online with enable cvar and print...lang

What does it mean enable cvar and print...lang?

Quote:

Originally Posted by Old.School (Post 2393133)
rtv not work if admin have flag change map online with enable cvar and print...lang some thing like you cannot rock the vote when the admin is online

Want you a cvar to do not allow RTV when there is an admin which can change map online?

Old.School 02-15-2016 16:25

Re: Galileo v1.2.2 | Last Update: 11.02.2016
 
you didn't understend me

Quote:

rtv not work if admin have flag change map online
= sug feature

Quote:

if admin have flag change map online with enable cvar
i mean add enable cvar to this feature and the admin must have flag f (change map)
Quote:

print...lang some thing like you cannot rock the vote when the admin is online
add print chat to display : cannot rock the vote when the admin is online

addons_zz 02-15-2016 18:22

Re: Galileo v1.2.2 | Last Update: 11.02.2016
 
Thanks, I got it.
******************************** TODO Go to top *********************************
Code:

* Add Cvar to control sv_restart
  using rounds exmple : mp_maxrounds 40 and 20 rounds passed and admin used sv_restart
  if the cvar is 1 the rounds left will be 20
  if the cvar is 0 the rounds left will 40
 * Add two cvars the first one :
  if 1 and the Cvar control sv_restart is 1 too next the sv restart he will add x rounds/time to mp_maxrounds /mp_timelimit
  the second cvar is the x rounds/time if the first cvar is 1
 * Create a new LANG file to show 'rounds' instead of 'minutes', when you are using rounds.
 * Add an admin command 'gal_cancelvote' to cancel the current vote.
 * If an admin have the change map flag, is online and the cvar 'gal_rtv_wait_admin' is enabled, rtv will not work and will print 'cannot rock the vote when the admin is online'.


addons_zz 03-03-2016 01:55

Re: Galileo v2.0 (a feature rich map voting plugin) | Last Update: 03.03.2016
 
Released a new big update version:

2016-03-03 | v2.0
  1. Fixed the language bug where the voting menu is always displayed on LANG_SERVER instead of LANG_PLAYER.
  2. Added the Romanian [ro] and Italian [it] language translations.
  3. Fixed a bug, where 'gal_rtv_wait_rounds' has priority over 'gal_rtv_wait'.
  4. Added new cvars 'gal_srv_timelimit_restart', 'gal_srv_maxrounds_restart' and 'gal_srv_winlimit_restart'
    to control the sv_restart. If nonzero and the server is restarted, adds x - 1 rounds/minutes to
    mp_maxrounds or mp_winlimit or mp_timelimit. Example using mp_maxrounds: If mp_maxrounds = 40 and
    20 rounds has already passed and admin used sv_restart. After the restart, if the cvar is 1, the
    rounds left will be 20. If the cvar is 0 the rounds left will 40.
  5. Create a new LANG file to show 'rounds' instead of 'minutes', when you are using mp_maxrounds.
  6. Add an admin command 'gal_cancelvote' to cancel the current vote.
  7. Fixed bug using mp_maxrounds: if the vote started automatique and the result is extend its works fine
    and with mp_maxrounds. If the vote started by rtv and the result is extend he will with extend with
    mp_timelimit. It must use mp_maxrounds.
  8. Fixed 'sv_restartround' time dection.
  9. Added new cvar 'gal_endonround_rtv' to Indicates when a map should end after the RTV voting is finished.
    0 - end immediately after the voting finished.
    1 - end after the current round.
  10. Added new cvar 'gal_rtv_wait_admin'. If an admin have the change map flag is online:
    0 - players can normally rock the vote.
    1 - RTV will not work and will print 'Cannot rock the vote when an admin is online'.
  11. Fixed bug where the handle empty server feature would change the map when there are players playing.
  12. Integrated the cvar 'gal_endonround_players' features into the cvar 'gal_endonround_msg'.
  13. Added to the 'gal_endonround_rtv' cvar the players minimum number necessary to allow the
    last round to be finished when the time runs out.
  14. Added new option 2 to the cvar 'gal_vote_show_none_type'. After the user voted, transform
    the '0 - None' option on 'one time cancel' vote opportunity.
  15. Added support to 'engine_changelevel' from AMX Mod X 183.
  16. Added correct documentation for the 'gal_srv_start' cvar to indicates which action to take
    when it is detected that the server has been 'externally restarted'.
  17. Improved 'gal_emptyserver_wait' cvar documentation in the configuration file.
  18. Fixed empty-server map cycle bug to always starting at its first map.
  19. Added new cvar 'gal_emptyserver_change'. When the server is empty, only change to an alternate
    empty-server map cycle after timelimit, maxrounds or winlimit expiration.
  20. Added new cvar 'gal_endofmapvote_ask' to indicates whether there should be asked to the players
    if they want to participate the map vote to decide what the next map will be.
  21. Added to the handle server start feature the abilitie to continues the mapcycle from the lastmap
    played instead of the first map on the mapcycle list.
  22. Added the Map Groups Feature feature documentation.
  23. Added new cvar 'gal_vote_whitelist_mapfile' that points a configuration file which specifies the
    time where its listed maps are allowed to be added to the voting list as fillers after the nominations
    being loaded.

Old.School 03-03-2016 16:06

Re: Galileo v2.0 (a feature rich map voting plugin) | Last Update: 03.03.2016
 
Nice Work

Depresie 03-04-2016 21:10

Re: Galileo v2.0 (a feature rich map voting plugin) | Last Update: 03.03.2016
 
and this son, is how you end up with 100k lines of code in 2 plugins designed to do simple stuff..

no offence man, you did a great job, you must have nerves of steel to get this far.. but in my opinion it is too much

@Arks, i totaly disagree with you on the point of editing the plugins of other users, i think it is good to have more options on the table, plugin edits like this should be allowed around here, maybe in a special section of these forums, but they shoud be allowed

Why?

Well, i'll give as example the user abdul rehman who created ZPA by editing the addon created by mercylez.. maybe it wasn't well coded, but the ideeas were good, and his creativity contributed alot to the zombie plague comunity...

Ethics kills freedom and creativity, we could benefit alot by derivating an actual work..

addons_zz 03-05-2016 03:33

Re: Galileo v2.0 (a feature rich map voting plugin) | Last Update: 03.03.2016
 
Do I have to much stuff on it? Look at 'galileo2.0.sma' vs 'deagsmapmanager.sma' here: (It is at the page's bottom, i.e., almost the last page's thing.)
https://forums.alliedmods.net/showthread.php?p=2353696#post2353696

Do not forget that these plugins are not only mapchoosers, they to do, to replace several small plugins like 'nextmap.amxx', 'allowroundfinish.amxx', etc. So, it is not just a mapchooser plugin, it is a super plugin (like Amx Super), where one of its functions is to do map voting. However my plugin is doing simple stuff, it is just that I to put some documentation, automated Unit Tests, debug statements, do not name variables as 'a', 'b', 'c', ..., to avoid magic numbers, to avoid to repeated code, to avoid big functions, to avoid big code lines, to avoid code huddle/heap, ... Things that let me to relax and do not worry, when it is needed to find a bug or to implement something new. Of course, as you said, it took time to get where it is now, a lots of it. And I do not think is has to much, it just some code lines and features that probability to scared the bejesus out of you, but it is just that the things here are well specified to best attend the users. For example, when I first opened the 'galileo.cfg' I said: "Damn so many things what**** is all this". However now I look and say: "Just this? This is that, that is this. This if for that there. That there is for this here". You can look now on my GitHub and you will see already new updates/fix/features, on the Galileo's develop branch, which are not released yet.

Quote:

"plugin edits like this should be allowed around here, maybe in a special section of these forums, but they should be allowed"
But they are allowed, just to post it on the plugin originals thread, however if you to want to you own thread on New Plugin Submissions; To do some decent work and take over the plugin support if the author does not support it anymore or if the plugin is on the unapproved section. But even if the plugin is on the approved section, you cold just to do a fork and to release it if you to got enough work to differ from the original.

What @Arkshine was complaining about me is that on that time, I did not had changed enough to be a new decent fork. So, would be acceptable to takeover the support to the original plugin. However, now I probably have enough work to do both. This plugin now could be a decent new fork as a support take over, because there are major code changes and it stills to respects the original plugin requirements/features.

addons_zz 03-05-2016 19:18

Re: Galileo v2.1 (a feature rich map voting plugin) | Last Update: 05.03.2016
 
Released new update:

2016-03-05 | v2.1.1 ~ 2016-03-09 | v2.1.9
  1. Fixed wrong version number on files.
  2. Corrected "pl" translations misspellings.
  3. Fixed do not reset the round limiters feature.
  4. Added to restore RTV original values on 'sv_restartround' event.
  5. Fixed extra map restart the on 'gal_srv_start' cvar feature.
  6. Fixed nominations not showing/allowing all nominated maps.
  7. Fixed bad vote start timer.
  8. Fixed start on the last map feature, cvar 'gal_srv_start', using a wrong next map position.
  9. Fixed the 'say nextmap' command not showing the next map.

2016-03-05 | v2.1
  1. Improved the 'vote_startDirector()' Unit Tests sequencial running.
  2. Fixed the cvar 'gal_nextmap_change' working when the cvar 'gal_endofmapvote' is disabled.
  3. Created a voting round start detection delay, to give time to buy weapons before the voting to start.
  4. Added new cvar 'gal_endofmapvote_start' to enable or disabled the voting round start detection delay.
  5. Fixed to start an early map vote after the first two minutes bad behavior.
  6. Fixed a new voting reset after the 'gal_cancelvote' command.

Depresie 03-06-2016 04:04

Re: Galileo v2.1.2 (a feature rich map voting plugin) | Last Update: 05.03.2016
 
Yes, but you should take in consideration that not everyone around here has you knowledge in pawn, so if the first time the cfg of galileo scared you, image the cfg of yours to a newbie :)

You are right, there may be mapchoosers more scarier than yours, that's probably why people avoid using them

I still consider that you would have more success with a lite version of this, but that's just my opinion :P
Anyway, i wish you good luck with it, as i said, i saw the hard work you have put in it, and i also can see that the reason you put so much work in this is tending to be more of the addiction to code and going further testing your capabilities and learning, rather than creating something for the public use :P i know that feeling..

As i said, great job and good luck with your project :P

EFFx 03-08-2016 13:03

Re: Galileo v2.1.7 (a feature rich map voting plugin) | Last Update: 07.03.2016
 
@addons_zz me adiciona no Skype: ruan.Guilherme.1614, se não tiver, steam: effx_cs

gabuch2 03-10-2016 10:45

Re: Galileo v2.1.9 (a feature rich map voting plugin) | Last Update: 09.03.2016
 
Hello

Galileo is not storing its data files in a custom "amxx_datadir" directory. (Files go directly to amxmodx/data/ regardless of what is set on amxx_datadir)

Also

gal_nom_mapfile "#" disables nominations. (make nomination of mapcycle.txt maps only default?)

Thank you for supporting the plugin!

addons_zz 03-10-2016 13:51

Re: Galileo v2.1.9 (a feature rich map voting plugin) | Last Update: 09.03.2016
 
Quote:

Originally Posted by Shattered Heart Lynx (Post 2401267)
gal_nom_mapfile "#" disables nominations. (make nomination of mapcycle.txt maps only default?)

Thank you for supporting the plugin!

You are welcome

Now, are you saying that it is not allowing any nominations when do you use "#"? If was it that, could be a bug because I was not removing double quotes.

If is not that, the value # does not disables the nominations, it use whatever map file list do you have over the cvar 'mapcyclefile'. I updated the documentation to be more descriptive.

PHP Code:

// Specifies the file to use which holds the names of the maps, listed
// one per line, that players can nominate. You can specify a relative
// path before the filename, relative from your gamemod folder (i.e.
// "addons/amxmodx/configs/mymapcycle.txt").
// Use * for all maps in the server's maps folder.
// Use # for your mapcycle (whatever file is on the cvar 'mapcyclefile').
gal_nom_mapfile "*" 

Quote:

Originally Posted by Shattered Heart Lynx (Post 2401267)
Hello
Galileo is not storing its data files in a custom "amxx_datadir" directory. (Files go directly to amxmodx/data/ regardless of what is set on amxx_datadir)

I will review this code and make certain it is working properly and release a new hotfix version improving that. The actually code, was not working because it relies on an existing folder called 'Galileo' on your new data dir. Now I implemented auto-creation to that directory and it must not happen anymore. It should be released soon.

I cannot test it right now, but if you want to try it, it is already on the 'v2.1.9d' branch over github if you want to see.
Changes:
https://github.com/addonszz/Galileo/commits/v2.1.9d

Download link:
https://github.com/addonszz/Galileo/archive/v2.1.9d.zip

gabuch2 03-10-2016 14:10

Re: Galileo v2.1.9 (a feature rich map voting plugin) | Last Update: 09.03.2016
 
Quote:

Originally Posted by addons_zz (Post 2401305)
Now, are you saying that it is not allowing any nominations when do you use "#"? If was it that, could be a bug because I was not removing double quotes.

If is not that, the value # does not disables the nominations, it use whatever map file list do you have over the cvar 'mapcyclefile'. I updated the documentation to be more descriptive.

mapcycle.txt is indeed the value of the cvar mapcyclefile. (or else my server wouldn't be able to change maps :P)

I am aware of the functionality of the "#" value on the cvar. I was reporting a possible bug.

addons_zz 03-13-2016 00:46

Re: Galileo v2.2.1 (a feature rich map voting plugin) | Last Update: 13.03.2016
 
Released newer version:

2016-03-13 | v2.2.1
  1. Fixed wrong version number on files.

2016-03-13 | v2.2
  1. Added to the cvar 'gal_vote_mapfile', the option '*' to use all maps in the server's maps folder as map fillers.
  2. Fixed map extension now showing up.
  3. Implemented the 'Galileo' data directory auto-creation.
  4. Updated the cvar 'gal_nom_mapfile' documentation.
  5. Fixed the possibility to start rock the vote after a map voting.

2016-03-05 | v2.1.1 ~ 2016-03-09 | v2.1.9
  1. Fixed wrong version number on files.
  2. Corrected "pl" translations misspellings.
  3. Fixed do not reset the round limiters feature.
  4. Added to restore RTV original values on 'sv_restartround' event.
  5. Fixed extra map restart the on 'gal_srv_start' cvar feature.
  6. Fixed nominations not showing/allowing all nominated maps.
  7. Fixed bad vote start timer.
  8. Fixed start on the last map feature, cvar 'gal_srv_start', using a wrong next map position.
  9. Fixed the 'say nextmap' command not showing the next map.

PartialCloning 03-13-2016 03:03

Re: Galileo v2.2.1 (a feature rich map voting plugin) | Last Update: 13.03.2016
 
An admin should really change the title of this plugin. Addon_zz not only stole the name and layout which now makes it confusing to tell that this is a fork and not the original, but he also copied the cvar variable "gal_version", which he now uses to show servers using "his" plugin, when in fact most of those servers are using Brad's plugin.

addons_zz 03-13-2016 03:59

Re: Galileo v2.2.1 (a feature rich map voting plugin) | Last Update: 13.03.2016
 
Because this is the same plugin, same algorithms, they are the same features and they must behave the same. If was missed something, let me know. Whatever, now there more cvars, different variables names, more splinted and different functions workflow and some Unit Tests. This is the same plugin and I am supporting it. Code evolves, code changes... Don't be square or live in the past, then tell now I stole the plugin? This is a debacle. Please, report to trash this thread and ban me, 'cuz I'm waist my time, your time, everybody else's time. I dare that y'all have more things to do as I have to, so please help me help y'all, as I am a crazy machine which cannot stop until get banned from here, from this reality. I hate this place. This zoo. This prison. Whatever you want to call it, I can't stand it any longer. It's the smell, if there is such a thing. I feel saturated by it. I can taste it stink and every time I do, I fear that I've somehow been infected by it.

.:cs.stambeto:. 03-13-2016 04:20

Re: Galileo v2.2.1 (a feature rich map voting plugin) | Last Update: 13.03.2016
 
Why choose when to extend my time it gives in rounds and not in time.

addons_zz 03-13-2016 05:00

Re: Galileo v2.2.1 (a feature rich map voting plugin) | Last Update: 13.03.2016
 
If you are using only 'mp_timelimit' it gives you in minutes.

If you are using 'mp_maxrounds/mp_winlimit' if gives you in rounds.

If you are usin both 'mp_timelimit/mp_maxrounds/mp_winlimit' if gives you the first to get close to finish the map. For example, suppose that there are 3 minutes left and 10 rounds remaining. It will give you by minutes, and not by rounds. And to avoid re-voting when the 10 rounds end up. It will temporarily disables the rounds voting when the rounds remaining end up.

But if you are only using 'mp_timelimit'... If you have access to your game server's console, type the following in the server console:
  • status
  • meta list
  • amxx list
  • amxx cvars
If you don't have access the your game server's console, join your server and type the
following in your game console:
  • status
  • rcon_password your_rcon_password
  • rcon meta list
  • rcon amxx list
  • rcon amxx cvars
  1. Paste here everything from the status command *except* the player list.
  2. Paste here the entire result from the meta list and amxx plugins commands.
  3. Paste here *only* the CVARs that contain "galileo.amxx" in the last column
    from the amxx cvars command. They will be grouped together.

gabuch2 03-22-2016 13:40

Re: Galileo v2.2.1 (a feature rich map voting plugin) | Last Update: 13.03.2016
 
The configureRTV_votingType() method is breaking non-round based mods. After every player rocked the vote, a vote to change the map will never appear. Error: Invalid Cvar Pointer.

Maybe you can do something like this?

PHP Code:

stock configureRTV_votingType()
{
    if(
is_running("cstrike") || is_running("czero"))
    {
        new 
minutes_left   get_timeleft() / 60
        
new maxrounds_left get_pcvar_numg_maxrounds_pointer ) - g_total_rounds_played
        
new winlimit_left  get_pcvar_numg_winlimit_pointer ) - maxg_total_CT_winsg_total_terrorists_wins )
        
        if( 
minutes_left maxrounds_left
            
|| minutes_left winlimit_left  )
        {
            
g_isVotingByRounds true
            
            
if( maxrounds_left >= winlimit_left )
            {
                
g_is_maxrounds_extend true
            
}
            else
            {
                
g_is_maxrounds_extend false
            
}
        }
    }
    else
    {
        
//please check, this may need a proper implementation
        
g_isVotingByRounds false;
        
g_is_maxrounds_extend false;
    }


This fixed the issue on Sven Co-op. (assuming it's configured to immediately change the map on rockthevote success)

Untested elsewhere or other configurations.

addons_zz 03-22-2016 19:36

Re: Galileo v2.2.1 (a feature rich map voting plugin) | Last Update: 13.03.2016
 
Let me see. You are running Galileo on 'Sven Co-op' your code fixed the bug.

Now, before your fix, the plugin was throwing 'Invalid Cvar Pointer' error, so, this means that 'Sven Co-op' does not have some of these cvars:
Code:

    g_maxrounds_pointer  = get_cvar_pointer( "mp_maxrounds" )
    g_winlimit_pointer  = get_cvar_pointer( "mp_winlimit" )
    g_freezetime_pointer = get_cvar_pointer( "mp_freezetime" )
    g_timelimit_pointer  = get_cvar_pointer( "mp_timelimit" )

Hence the plugin was stopping then not starting the voting.
  1. Well, I bad named they, would be proper 'cvar_' instead of 'g_..._pointer'. I am going to change it.
  2. I will look into the 'Sven Co-op' to proper fix it.
  3. As this is a very relevant issue, soon as it is fixed, I am going to release a new version.

Thank you for codding and reporting. And about these variables, I added some documentation.
Code:
/**  * This function choose what RTV's type will be used to 'rock the vote'. The types are:  * 1) Per rounds.  * 1.1) Is by mp_winlimit expiration proximity?  * 1.2) Is by mp_maxrounds expiration proximity?  * 2) Per minutes.  * These data are used to display the voting menu and proper set the voting flow.  */ stock configureRtvVotingType() {

WaSaAa1 03-23-2016 04:40

Re: Galileo v2.2.1 (a feature rich map voting plugin) | Last Update: 13.03.2016
 
Galileo had and has several critical bugs (in my opinion), one the most famous is that often does not show votemaps and its version of Galileo code remains the same in that part so I understand that it will be repeated situation (bug).

Brad already commented this bug and gave a possible solution:
https://forums.alliedmods.net/showpo...&postcount=511


For example, in your version: (Bug)
Code:

        get_user_menu( player_id, menu_id, menuKeysUnused )
       
        if( menu_id == 0 || menu_id == g_chooseMapQuestionMenuId )
        {
            show_menu( player_id, menuKeys, menu_body, ( g_pendingVoteCountdown == 1 ? 1 : 2 ), MENU_CHOOSEMAP_QUESTION )
        }

Fix:
Code:

            show_menu( player_id, menuKeys, menu_body, ( g_pendingVoteCountdown == 1 ? 1 : 2 ), MENU_CHOOSEMAP_QUESTION )
When removing the previous code, the menu is replaced always, as for example in the CS 1.6, the menu teams often given as an open menu even having chosen team. (With weapons menu the same)

PS:Reoccurs in more parts of the code, a total of 3 times.

I will try your version to check Galileo critical errors and try and solve them.


All times are GMT -4. The time now is 08:59.

Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.