AlliedModders

AlliedModders (https://forums.alliedmods.net/index.php)
-   Scripting Help (https://forums.alliedmods.net/forumdisplay.php?f=11)
-   -   Small Help Code Optimization , If someone can optimize for me this code ^^ (https://forums.alliedmods.net/showthread.php?t=270787)

FragPawn 08-29-2015 14:20

Small Help Code Optimization , If someone can optimize for me this code ^^
 
PHP Code:

public Musique_HandleridCTMenuitem )
{
        if( 
item == MENU_EXIT )
        {
                
menu_destroyCTMenu );
                return 
PLUGIN_HANDLED;
        }
        
        new 
szData];
        new 
iAccesshCallback;        
        
menu_item_getinfoCTMenuitemiAccessszData5__hCallback );
        
        new 
name32 ];
        
get_user_name(id,name,31)

        switch( 
str_to_numszData ) )
        {
                case 
0
                { 
                        
ColorChat(0RED"^4[PrisonBreak]^1 || Guard ^3%s^1 Start Song 1 || ^4!",name)
                        
client_cmd0"mp3 play ^"sound/Masters-PrisonBreak/Masters-music/Song1.mp3^"" );
                }
                case 
1:
                {  
                        
ColorChat(0RED"^4[PrisonBreak]^1 || Guard ^3%s^1 Start Song 2 || ^4!",name)
                        
client_cmd0"mp3 play ^"sound/Masters-PrisonBreak/Masters-music/Song2.mp3^"" );
                }
                case 
2:
                {     
                        
ColorChat(0RED"^4[PrisonBreak]^1 || Guard ^3%s^1 Start Song 3 || ^4!",name)
                        
client_cmd0"mp3 play ^"sound/Masters-PrisonBreak/Masters-music/Song3.mp3^"" );
                }
                case 
3:
                {   
                        
ColorChat(0RED"^4[PrisonBreak]^1 || Guard ^3%s^1 Start Song 4 || ^4!",name)
                        
client_cmd0"mp3 play ^"sound/Masters-PrisonBreak/Masters-music/Song4.mp3^"" );
                }
                case 
4
                {
                        
ColorChat(0RED"^4[PrisonBreak]^1 || Guard ^3%s^1 Start Song 5 || ^4!",name)
                        
client_cmd0"mp3 play ^"sound/Masters-PrisonBreak/Masters-music/Song5.mp3^"" );  
                }
                case 
5
                { 
                        
ColorChat(0RED"^4[PrisonBreak]^1 || Guard ^3%s^1 Start Song 6 || ^4!",name)
                        
client_cmd0"mp3 play ^"sound/Masters-PrisonBreak/Masters-music/Song6.mp3^"" );  
                }
        }   
        
menu_destroyCTMenu );
        return 
PLUGIN_HANDLED;



Bugsy 08-29-2015 15:39

Re: Small Help Code Optimization , If someone can optimize for me this code ^^
 
Please wrap your code postings in php tags.
PHP Code:

public Musique_Handlerid CTMenu item )
{
    if( 
item == MENU_EXIT )
    {
        
menu_destroyCTMenu );
        return 
PLUGIN_HANDLED;
    }
    
    new 
szData] , iAccess hCallback name32 ] , iVal;
    
    
menu_item_getinfoCTMenu item iAccess szData charsmaxszData ) , __hCallback );
    
get_user_nameid name charsmaxname ) )
    
iVal str_to_numszData );
    
    if ( 
<= iVal <= )
    {
        
ColorChat(0RED"^4[PrisonBreak]^1 || Guard ^3%s^1 Start Song %d || ^4!" name iVal )
        
client_cmd0"mp3 play ^"sound/Masters-PrisonBreak/Masters-music/Song%d.mp3^"" iVal );
    }
    
    
menu_destroyCTMenu );
    
    return 
PLUGIN_HANDLED;



FragPawn 08-29-2015 19:03

Re: Small Help Code Optimization , If someone can optimize for me this code ^^
 
Thanks bro =) :bee:

Bugsy 08-29-2015 20:19

Re: Small Help Code Optimization , If someone can optimize for me this code ^^
 
I added a condition just in case an invalid value is selected (< 0 or > 5). If you add songs, adjust this accordingly.


All times are GMT -4. The time now is 22:12.

Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.