Knife Deathmatch Shop
2 Attachment(s)
Knife Deathmatch Shop Introduction A Shop that designed for Knife Server owners to make their players' gameplay different. |
Re: Knife Deathmatch Shop
Hola.
|
Re: Knife Deathmatch Shop
Thanks for your great advises, Kia. I'll apply them as soon as possible.
But, would you explain your second advise? I couldn't understand it. I'll thank you if you say what do you think about the idea and its effect on gameplay. (P.S.: I think you know Persian or you or your parents are Iranian, is it true? 'cause your name is like the names in Iran. ;)) |
Re: Knife Deathmatch Shop
"After purchasing, it'll take 1 - 2 seconds to activate the item
Plugin will crash if you enter a negative value for HP Value" First, why not instantly? Second, check the value and if is negative return. Makes no sense to use a plugin that can crash the server lol |
Re: Knife Deathmatch Shop
I need some help...
1. Should I hook a function to Ham_Player_ResetMaxSpeed or just call it? 2. Fixed 3. You mean sth like this? : PHP Code:
Thank you. |
Re: Knife Deathmatch Shop
Quote:
2. LOL, I knew that, but Mmm. I will reupload it when I apply major changes. Anyway it doesn't crash the server itself, it will be crashed if plugin misconfigured. Thanks anyway. |
Re: Knife Deathmatch Shop
Quote:
PHP Code:
PHP Code:
Reseting variables in both client_disconnect and client_connect is not needed. It is enough to do it only one time during client_disconnect. Kia was talking about iFrags >= iPrice. You can save expression value(true/false) inside a boolean and check it inside formatex. From my point of view this is not very important, it may help on readability, but nothing more. Initializing iTime variable is not needed, cause you use it only one time, you can write the native directly. Also, for menu items an array would be better :crab Info param from menu_additem is not used, so you can remove menu_item_getinfo and work directly with item. Also, instead of checking item name, why you don't do a [tt]switch(item)[/t] ? Returning PLUGIN_HANDLED inside menu callback and inside the public where creating the menu is not needed. PHP Code:
Cache the return value of get_user_msgid. This are just some stuffs, didn't read all your code. |
Re: Knife Deathmatch Shop
Thank you really much Hamlet. This gave me a lot of code optimization guides. I never thought that someone ever would help me in this amount. (You don't know, my country, Iran is just ... never mind)
But, I didn't understand the last part of your post: Quote:
Thank you again so much :) |
Re: Knife Deathmatch Shop
PHP Code:
|
Re: Knife Deathmatch Shop
Updated to version 3.3
I tried to do everything you guys said and plugin optimized 1.5x (Thank you for your great advises) Please test newer version and tell me what do you think about The Idea and Plugin performance. Thanks. |
| All times are GMT -4. The time now is 20:48. |
Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.