AlliedModders

AlliedModders (https://forums.alliedmods.net/index.php)
-   New Plugin Submissions (https://forums.alliedmods.net/forumdisplay.php?f=26)
-   -   Entity Resources Replacement[ V 1.4 ] (https://forums.alliedmods.net/showthread.php?t=250244)

Jhob94 10-22-2014 13:09

Re: Entity Resources Replacement[ OKAPI ]
 
nice, really nice. Btw you could tell us wich sprites it can replace. For example i heard that radar sprite is impossible to replace so you should make a list. But very nice, i start liking and considering to use this plugin :)

HamletEagle 10-22-2014 13:50

Re: Entity Resources Replacement[ OKAPI ]
 
Attachement removed, just spotted some dumb mistakes into the source, I will upload it when they are fixed.

Edit: fixed.

Arkshine 10-22-2014 13:58

Re: Weapons Resources Replacement[ OKAPI ]
 
Quote:

Originally Posted by HamletEagle (Post 2214475)
I'm sure you still have a lot of suggestions.

Of course, like:
  • You did not care to test properly your code before releasing it. Like the first okapi_mod_replace_string which is out of loop... :nono: (EDIT: looking at your previous post, you probably fixed that)
  • You use 2 copy... but why not using directly arrayData in parse?
  • I'm not sure why you check for .mdl / .spr ; this doesn't seem useful.
  • Well, about sound/, I told you have 2 ways, but honestly this makes more sense and is more consistent that user has to add sound/ in config file, like he has to add models/ and /sprites. This also simplify your code.
  • You should rewrite your description in first post. This is kind of incomplete, not really clear, with some pointless sentences. You should also clearly list the pros and cons of your plugin (for example pros: you have probably work for all mods, the most efficient method, can replace any entity resources ; and cons: probably the limit about length which could be a pain, global (can't be done per-player, etc.), possible incompatibility with plugins which check the original model name, etc.). This is important to an admin to understand at first glance whether this plugin is suitable for their needs. So please take time to properly elaborate your plugin description.

HamletEagle 10-22-2014 14:34

Re: Entity Resources Replacement[ OKAPI ]
 
Done. I've added a second array with only the string that were replaced for unpathMemory function, to avoid making the same checks as in pathMemory. The topic will be rewrited tomorow.

ANTICHRISTUS 10-22-2014 15:32

Re: Entity Resources Replacement[ OKAPI ]
 
you edited your plugin's name ? so basically it's no longer a replacement of the Weapon Model Replacement but a replacement of the Content Replacer one. right ?

my advice is to make separate plugins, and to use easy topic names (to search for/remember them easily).

HamletEagle 10-22-2014 15:39

Re: Entity Resources Replacement[ OKAPI ]
 
Quote:

Originally Posted by ANTICHRISTUS (Post 2214561)
you edited your plugin's name ? so basically it's no longer a replacement of the Weapon Model Replacement but a replacement of the Content Replacer one. right ?

my advice is to make separate plugins, and to use easy topic names (to search for/remember them easily).

It's a replacement for both of them :D There is no point in having different plugins, this one can to the same job :D

yokomo 10-23-2014 01:58

Re: Entity Resources Replacement[ OKAPI ]
 
Actually just put "String Replacement" in your thread tittle, it just change string.

This replacement is for global. The plugin from GHW is better because you can replace string > original. I believe every community has it own sound/models/sprites folder, and of course they want use their own path (sound/picollo/mysound.wav). Your plugin is limited and i don't think this is useful. You can do with Opheu too, see http://forums.alliedmods.net/showthread.php?t=117930

Very simple right.

HamletEagle 10-23-2014 09:23

Re: Entity Resources Replacement[ OKAPI ]
 
Quote:

Originally Posted by yokomo (Post 2214690)
Actually just put "String Replacement" in your thread tittle, it just change string.

This replacement is for global. The plugin from GHW is better because you can replace string > original. I believe every community has it own sound/models/sprites folder, and of course they want use their own path (sound/picollo/mysound.wav). Your plugin is limited and i don't think this is useful. You can do with Opheu too, see http://forums.alliedmods.net/showthread.php?t=117930

Very simple right.

Some users may not know what a string is, the current name is just fine. How could you say what GHW's is better ? Speacking about restrictions, yes, his one doesn't has many restriction, but considering his code it's very inneficient, using old file natives, using currentweapon and so on. I know it can be done with orpheu, but why creating a signature when with okapi I need just one line ? If the sound has not a plugin that's using it you can short it's name, this is no problem, and if it has already one what's the point in using my plugin ? So, this is not a problem. Of course, you can consider it's useless, but this won't stop me from updating this. :D

Arkshine 10-23-2014 10:26

Re: Entity Resources Replacement[ OKAPI ]
 
Same for you, is there a specific reason you're ranting and raving about this?
But I agree that this plugin should not be considerated as a total replacement of existing plugins.
Both plugins have its pros and cons. That's why description should be more clear about it. It's fine to have both way.

HamletEagle 10-23-2014 13:25

Re: Entity Resources Replacement[ OKAPI ]
 
Updated to 0.5, this brings some code improvements and some mistakes fixed.


All times are GMT -4. The time now is 06:59.

Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.