Re: Weapons Model Replacement[ OKAPI ]
Well, when you have your definitive final version, you should request an approver/moderator to add everything to zip file including amxx for make the job easier to who doesn't knows how to compile localy.
And nice that you added sounds support :) |
Re: Weapons Model Replacement[ OKAPI ]
Quote:
|
Re: Weapons Model Replacement[ OKAPI ]
I don't have much to say for now, but I think you should review your "Usage" section. It's confusing and kind of unreadable.
Like for example: - you say in 1. to create a file, but you provide already a config file. - The config file should contain a dummy example with explanations. - Make sure to warn about not using mp3 sounds. - Make sure to emphasis about the length restriction. - Make sure to emphasis about putting the map name. - Your example should follow your current config file syntax, and you should not hesitate to use [code] bbcode. - No need to duplicate 2 times your examples - Basically rewrite the whole section \o/. |
Re: Weapons Model Replacement[ OKAPI ]
Ok, this is for the topic, about the code do you spot some problems ? Yeah, I will rewrite it.
Edit: done, new file uploaded. |
Re: Weapons Model Replacement[ OKAPI ]
Code as it is seems ok.
Though you can always improve a bit:
|
Re: Weapons Model Replacement[ OKAPI ]
I like too much my parsing method and if a user simply fallow the instructions he can't be wrong :D
Everything else updated. |
Re: Weapons Model Replacement[ OKAPI ]
But I don't care you like much your method. :twisted:
You should also be aware that you can be sure user won't follow instructions. Never trust user. A gold rule. This is not a joke. When you think again, more things:
Since I'm a evil bastard, the last point should make you realize your plugin is no more about only Weapon Model anymore but a generic memory replacer for entity's resources. That's it, your plugin can replace any sounds/models/sprites that the game precaches. You should rename your plugin to something else. Don't tell me you want to keep only for weapons, it would not make sense at all since your plugin would already allows that \o/, and it's better to be generic so your plugin has more chance to be used for more things. If you are a masochist, you could take the thing a bit further, like config file allows to replace any string (so not a file, your have already the code ready). If you are a masochist, you could add some parameter in config file to replace any string in the engine library as well. |
Re: Weapons Model Replacement[ OKAPI ]
Quote:
|
Re: Weapons Resources Replacement[ OKAPI ]
You did not rename your plugin. What plugin does is not related to weapon specifically anymore, but to entities more generally. An entity can be a weapon, an item, or anything else like func_*, env_* etc. Such entities precaches resources as well (just look at HLSDK.
|
Re: Weapons Resources Replacement[ OKAPI ]
Quote:
Check the code, forget the name, it can be easely changed :P I'm sure you still have a lot of suggestions. |
| All times are GMT -4. The time now is 06:59. |
Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.