AlliedModders

AlliedModders (https://forums.alliedmods.net/index.php)
-   New Plugin Submissions (https://forums.alliedmods.net/forumdisplay.php?f=26)
-   -   Deagles' Map Manager v3.25Beta (https://forums.alliedmods.net/showthread.php?t=177180)

Infamanious 07-19-2022 17:49

Re: Deagles' Map Manager v3.25Beta
 
Quote:

Originally Posted by JusTGo (Post 2784215)
I guess you don't need to remove the map from the maps folder, since it will be ignored once it gets removed from mapcycle file.

PS: The discord invite link on your profile is invalid, I don't know if you are aware or not but thought I would tell you anyway lol

lol thanks. character limits suck!

fysiks 07-20-2022 00:01

Re: Deagles' Map Manager v3.25Beta
 
Quote:

Originally Posted by Infamanious (Post 2784214)
Removing a map from the maps directory (bsp, and place it in a renamed directory for easy access later) also removing the corresponding map name from the mapcycle file as any other maps.txt file. For Deags map manager there is the mapcycles.txt file and the allmaps.txt file in the plugins i believe.
Edited the hardcoded line to alot for the amount of maps on our server to 900.

I couldn't find any fundamental reason why a large number of maps would cause any major issues other than maybe a little lag when it's trying to loop through the long list. So, I was starting to wonder if the server itself is having issues. What happens if you leave all the maps in the maps directory and just remove it from your mapcyclefile?

Quote:

Originally Posted by JusTGo (Post 2784215)
I guess you don't need to remove the map from the maps folder, since it will be ignored once it gets removed from mapcycle file.

PS: The discord invite link on your profile is invalid, I don't know if you are aware or not but thought I would tell you anyway lol

This plugin does scan the whole maps directory but only to make the allmaps.txt file if it doesn't already exist. I find it unlikely that this would cause any issues since it's ignored most of the time.

Infamanious 07-20-2022 03:46

Re: Deagles' Map Manager v3.25Beta
 
Quote:

Originally Posted by fysiks (Post 2784248)
I couldn't find any fundamental reason why a large number of maps would cause any major issues other than maybe a little lag when it's trying to loop through the long list. So, I was starting to wonder if the server itself is having issues. What happens if you leave all the maps in the maps directory and just remove it from your mapcyclefile?



This plugin does scan the whole maps directory but only to make the allmaps.txt file if it doesn't already exist. I find it unlikely that this would cause any issues since it's ignored most of the time.

After removing the mapcycles.txt file the lag or hang is still the same. With the plugin disable the server loads buttery smooth and with galileo it loads smooth as well aside for the crashes. Still working on the culprit with that one and doing more testing with the gal_pagination setting.

fysiks 07-20-2022 23:08

Re: Deagles' Map Manager v3.25Beta
 
1 Attachment(s)
Quote:

Originally Posted by Infamanious (Post 2784257)
After removing the mapcycles.txt file the lag or hang is still the same. With the plugin disable the server loads buttery smooth and with galileo it loads smooth as well aside for the crashes. Still working on the culprit with that one and doing more testing with the gal_pagination setting.

I took some time to refactor how it was loading the map files to see if that makes a difference. I removed several loops including nested loops that would definitely cause a larger than 1-to-1 increase in processor time as the map list gets longer. This removes allmaps.txt entirely (there were some scenarios where it might be used). Maps that you can nominate are loaded from the file set as the mapcyclefile and maps to fill the voting slots when less than 5 maps are nominated are loaded from mapchoice.ini.

The nested loops were primarily checking for duplicate map names in the files so I'd recommend that you don't duplicate map names in the files (though I doubt it would affect anything). Also, make sure that both files have have at least like ~20 maps.

Let me know how it works out.

Infamanious 07-21-2022 20:41

Re: Deagles' Map Manager v3.25Beta
 
Quote:

Originally Posted by fysiks (Post 2784331)
I took some time to refactor how it was loading the map files to see if that makes a difference. I removed several loops including nested loops that would definitely cause a larger than 1-to-1 increase in processor time as the map list gets longer. This removes allmaps.txt entirely (there were some scenarios where it might be used). Maps that you can nominate are loaded from the file set as the mapcyclefile and maps to fill the voting slots when less than 5 maps are nominated are loaded from mapchoice.ini.

The nested loops were primarily checking for duplicate map names in the files so I'd recommend that you don't duplicate map names in the files (though I doubt it would affect anything). Also, make sure that both files have have at least like ~20 maps.

Let me know how it works out.

So far, so good. I'm able to list 900 maps without any lag and there isnt any lag while connecting to the server or after entering the server. I added the list of maps to the mapcycle.txt and the mapschoice.ini with +20 maps unduplicated. In this case there are 900 maps in the mapcycles.txt file.

edit: yet to do a full server with 32 players. We should have a full server starting later tonight and i'll post here if there are any issues.
45.32.203.198:27035

Suicide_Kid 07-27-2022 22:15

Re: Deagles' Map Manager v3.25Beta
 
As Infamanious mentioned, the plugin seems to work well enough but we did notice an issue. If the mapcycle.txt has the ~900 maps in it, it messes up demo recording with this -->

Quote:

WARNING! Server::ParseBad: illegal server message.
WARNING! Server::ProcessMessage: packet read overflow.
Added 804 resources.
***** FATAL ERROR *****
Server::ParseBaseline: needed delta encoder missing.
*** STOPPING SYSTEM ***
WARNING! Server::ParseBad: illegal server message.
WARNING! Server::ProcessMessage: packet read overflow.

Suicide_Kid 07-27-2022 22:24

Re: Deagles' Map Manager v3.25Beta
 
I would prefer if the original mapname files were used to avoid confusion with updates from previous (3.23) version. Currently I have the cvar mapcyclefile set to mapcycle.txt with only 25 or so maps and it's working ok and most players know the names of most maps but now and then someone won't remember the name (or exact name) and will not have the full list of maps. The old behavior of listmaps using the allmaps.txt and the maps that are cycled through which are much less using mapcycle.txt/mapchoice.ini would be preferable.

fysiks 07-29-2022 22:50

Re: Deagles' Map Manager v3.25Beta
 
Quote:

Originally Posted by Suicide_Kid (Post 2785047)
As Infamanious mentioned, the plugin seems to work well enough but we did notice an issue. If the mapcycle.txt has the ~900 maps in it, it messes up demo recording with this -->

  1. This was just a test to see where the loading issue was occurring. I didn't change anything else.
  2. I'm not sure how the loading of maps by the server at the beginning of the map before any clients have connected would be related to recording a demo on the client.

I'm too tired to look through the code to respond to your second post. I'll have to come back to that.

Suicide_Kid 08-02-2022 04:32

Re: Deagles' Map Manager v3.25Beta
 
It's working for the most part so no worries. The "precaching resources" delay is totally gone and we had 1-2 players that would totally freeze and that's gone too so I'm ok where it is for now. I think the demo issue had something to do with the pagination but not sure. A file was created with the demo that had a list of maps but it ended right around 600-700 maps.


All times are GMT -4. The time now is 10:05.

Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.