AlliedModders

AlliedModders (https://forums.alliedmods.net/index.php)
-   Plugins (https://forums.alliedmods.net/forumdisplay.php?f=108)
-   -   [ANY] Goomba Stomp (2.0.2) (https://forums.alliedmods.net/showthread.php?t=111893)

exvel 12-20-2009 11:24

Re: [TF2] Goomba Stomp (1.0.3)
 
A few suggestions about using colors.inc.
You don't need to make so complicated translations when colorizing player's name. Just use CPrintToChatAllEx function (author is a client index you want to use as team color). It supports {teamcolor} tag that is based on player's team color.
For example:
Code:

"Red Stomp Blue"
{
        "#format"                "{1:s},{2:s}"
        "fr"                        "{olive}>> {teamcolor}{1} {default}a stompé {olive}{2} {default}!"
        "en"                        "{olive}>> {teamcolor}{1} {default}goomba stomped {olive}{2} {default}!"
}


psychonic 12-27-2009 13:54

Re: [TF2] Goomba Stomp (1.0.3)
 
Flyfo:
A couple minor things I noticed.

You might want to move
PHP Code:

if(GetConVarFloat(g_Cvar_PluginOnOff) > 0.0

from FrameAction to OnGameFrame before FrameAction is called. That way you only check once that the plugin is enabled each from instead of checking MaxClients times. Also, is there a reason you used GetConVarFloat instead of GetConVarBool for that check?

Also, many of your condition checks are redundant.
Ex.
PHP Code:

return pcond >= ? ((pcond TF2_PLAYER_INVULN) != 0) : false

You don't need the ">= 0" check.

Flyflo 12-28-2009 09:17

Re: [TF2] Goomba Stomp (1.0.3b)
 
Quote:

Originally Posted by exvel (Post 1023950)
Just use CPrintToChatAllEx function (author is a client index you want to use as team color)

I just didn't notice this function ^^ it's really useful.

Quote:

Originally Posted by psychonic (Post 1032968)
You might want to move
PHP Code:

if(GetConVarFloat(g_Cvar_PluginOnOff) > 0.0

from FrameAction to OnGameFrame before FrameAction is called. That way you only check once that the plugin is enabled each from instead of checking MaxClients times.

You're right, it's more logical and efficient this way.

Quote:

Originally Posted by psychonic (Post 1032968)
Also, is there a reason you used GetConVarFloat instead of GetConVarBool for that check?

No :oops:


First post and plugin updated !

bouncer 03-21-2010 12:36

Re: [TF2] Goomba Stomp (1.0.3b)
 
without...

sm_goomba_ff 1/0 (default 0) : Enable the friendly fire for the stomp (require mp_friendlyfire = 1)

will the plugin be useless then? Cause i dont want friendly fire on my server, or can the players still kill the other players?

Flyflo 03-21-2010 12:44

Re: [TF2] Goomba Stomp (1.0.3b)
 
I don't understand, you want to enable the friendly fire only for the stomp ?

bouncer 03-21-2010 13:01

Re: [TF2] Goomba Stomp (1.0.3b)
 
No, I don't really understand what that command means...

if that is set to 0 will the plugin still work? What is that command for?

Flyflo 03-21-2010 13:07

Re: [TF2] Goomba Stomp (1.0.3b)
 
Yes it'll work, sm_goomba_ff enables stomp between players of the same team when mp_friendlyfire is set to 1. By default you can just stomp players of the other team.

bouncer 03-21-2010 13:12

Re: [TF2] Goomba Stomp (1.0.3b)
 
k thanks.
installed

WGSXFrank 05-01-2010 06:30

Re: [TF2] Goomba Stomp (1.0.3b)
 
It seems that this is causing my server to crash with the latest update whenever anyone actually performs a stomp.

It was working great for months before the update.

Dumb Valve...

Flyflo 05-01-2010 10:24

Re: [TF2] Goomba Stomp (1.0.3b)
 
Ok, I'll look at it as soon as possible.


All times are GMT -4. The time now is 14:11.

Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.