set/get_pcvar_* error/crash
 

Hello.

I just found an error.

Code
will result in an instant crash of the server.

Windows, 1.8.2 latest. (it seems that there is no difference with 1.8.3 and 1.9)

I know that there is no way to see this situation in a real use (because of get_cvar_pointer() and register_cvar()/create_cvar()), but it will be better if the server does not crash and simply throws an error.

Thank.

Re: set/get_pcvar_* error/crash
 

Pcvars are really just cvar pointers - it's impossible to check whether it's really pointing to a cvar_t struct, unless we change the implementation (i.e. use handles). Not sure if this would be a breaking change, doesn't seem so.

Anyway, just don't do that, I think it's rather obvious that you shouldn't do that.

Re: set/get_pcvar_* error/crash
 

get_tr2(1, TR_pHit)

As wrote above, they are just pointers, a memory address.