AIO: Winter Plugin
3 Attachment(s)
AIO (All-In-One) Winter Plugin https://cdn4.iconfinder.com/data/ico...ns/64/Gift.pngDescription After researching a lot on a variety of forums, I could not find what i needed to customize my server for Winter. Instead of installing 100 plugins, I created an AIO one! With this plugin you can bring the Christmas Environment to your Counter Strike server! Very customizable, this plugin unique style is beyond all the existing Christmas plugins here. I know there are a LOT of plugins for winter here, but most of them aren't complete, or they contain bugs. Well in this plugin I tried to create an All-In-One Winter plugin that includes almost all the functionalities for a Christmas Server! Merry Christmas everyone! What does this plugin contains?
Why is it so unique?
https://cdn4.iconfinder.com/data/ico...ns/64/Gift.pngCvars: PHP Code:
https://cdn4.iconfinder.com/data/ico...ns/64/Gift.pngRequirements:
https://cdn4.iconfinder.com/data/ico...ns/64/Gift.pngInstallation Guide:
https://cdn4.iconfinder.com/data/ico...ns/64/Gift.pngCredits:
https://cdn4.iconfinder.com/data/ico...ns/64/Gift.pngModules:
https://cdn4.iconfinder.com/data/ico...ns/64/Gift.pngVideo Demonstration: It is a 10 minutes gameplay with bots, you can skip thorough it and see new additions along with the demonstration of this plugin Video has been uploaded now, so until youtube renders to high quality, expect 360p :arrow: https://youtu.be/0HKGO07QhwA . |
Re: AIO: Winter Plugin
Nice job.
My only objection is that all the grenades have the same model and that, for most of the models, you could of made a single model with sub-models in order to have less resources precached so we don't get closer to the almighty 512 limit(which I can help you with if you want). I also was too lazy to read all the cvars. Are the gameplay-modifying features optional? |
Re: AIO: Winter Plugin
I have no clue in 3d modelling so, if you could help me would be great.
Yes, grenades are replaced with same model since all of them act like a snowball. Check the video. I recorded every aspect during my shitty gameplay where I can't even kill bots lol. And yes, everything listed in there can be disabled. |
Re: AIO: Winter Plugin
Yes, Christmas stuff :D
Well, I have some things to say, if you don't mind. 1.register_forward( FM_Touch, "forward_FM_Touch" ) I would like you to use engine here. FM_Touch catch all touch between all entities, and this is bad for server resources. While you filter them and execute your code only when needed the forward is still fired all the time. With engine you can filter by classnames(touched, toucher) so the forward will be called only when needed. 2.new szMapName[ 25 ]; should be 32, that is the max size used by engine. 3.In the menu you can not use the info param(3 rd one - because you don't need it) thus in menu handler you could use directly item in the switch(so no longer needing menu_item_getinfo). 4.In EVENT_RoundStart and LOGEvent_Round_Start you have the exact same code, you can create a function for this code and call it from the two events. Repeating code is ugly. 5.bacon_GrenadeDeploy make sure iWeaponEntity is valid before retrieving it's pdatas. Also make sure the owner is alive. Same for bacon_KnifeDeploy 6.In EVENT_DeathMsg:
8.Remove the stock keyword from your functions. That is used for things that may not be needed(like in an include file where not all functions will be used at same time). IMO it's misused in a plugin. 9.UTIL_GiveWeaponAmmo: use cs_get_user_bpammo, and as weapon index to get_user_weapon(id). It should be a bit better. |
Re: AIO: Winter Plugin
Quote:
Quote:
Quote:
Nice ^_^ I also have a few suggestions: Don't spawn the "snowflake" hit sprite when hitting a player or remove it fast because it looks weird hanging in the air. Be careful with the light messages because they often lower the client FPS(DLIGHT for example). |
Re: AIO: Winter Plugin
Hamlet - was expecting you here
Georgik - thanks for the info, i will add your suggestions PLUGIN UPDATED. |
Re: AIO: Winter Plugin
1.You have some indentation problems, please fix them.
2.Recheck point 1 from previous list, please use register_touch. 3.I think you should not limit rain removal only to de_aztec. Maybe there are more maps that use env_rain, so you should remove map check and search for env_rain(find_ent_by_class), if you find one remove it and print the message. 4.szFile[80] I am not sure if 80 is enough, configs dir path can be easely changed from core.ini, you could put more(something like 256, IIRC this is the max dimension of a path). 5.In forward_TouchGift checking both IS_PLAYER and is_user_alive is not needed. Keep only is_user_alive, because the native already check what you were doing with IS_PLAYER. 6.In forward_FM_PlaybackEvent do not make vars in a loop, declare them before. Well, only this. |
Re: AIO: Winter Plugin
okay sharp eye. i used register touch. kappa
indentation problems? what editor you're using? cuz i use notepad and it's all good |
Re: AIO: Winter Plugin
I still see register_forward( FM_Touch, "forward_FM_Touch" );.
|
Re: AIO: Winter Plugin
Quote:
updated with fixes. |
Re: AIO: Winter Plugin
My point is you should never use FM_Touch if you want to get interactions between specific entities. You use FM_SetModel for trail and w_ models, not Touch(btw, you forgot to remove register_forward( FM_Touch, "forward_FM_Touch" ); from init).
In RemovePlayer_InvisGift don't check is_user_connected && IS_PLAYER, the same reasoning as for is_user_alive. In forward_FM_PlaybackEvent you still create some vars inside the loop. Same for EVENT_OnBombDrop. Other than this few things code looks ok, so fix this and, you know. |
Re: AIO: Winter Plugin
Oh lol forgot to remove it. Also wasn't paying attention. Will change it soon
|
Re: AIO: Winter Plugin
Fastly checked, code looks ok. Hope I did not miss something.
Approved. |
Re: AIO: Winter Plugin
That was a fast approval.
|
Re: AIO: Winter Plugin
no it wasn't. i spent 3 days fixing the stuff in each day.
|
Re: AIO: Winter Plugin
Yes it was, you only posted it 2 days ago. I'm not saying there's anything wrong with your code (I haven't seen it) or the approval. I'm just surprised at how quick it was approved.
|
Re: AIO: Winter Plugin
Can we increase the size of snowflakes? Heavy snowfall?
|
Re: AIO: Winter Plugin
At the moment no, but i will add this feature later:)
Edit: if you are talking about the env_snow, not sure yet. I will do some reaearch |
Re: AIO: Winter Plugin
Quote:
Density: cl_weather 1/2/3. |
Re: AIO: Winter Plugin
it's already set at max value on cl_weather.
Updated: - fixed a small thing :3 |
Re: AIO: Winter Plugin
I mean its size. Is it possible? Or we need to create new sprite for it?
|
Re: AIO: Winter Plugin
Quote:
Quote:
|
Re: AIO: Winter Plugin
Wickedd if you read the plugin and image with the menu, if the user agree to set weather for him, plugin sets cl weather to max value 3. Read
|
Re: AIO: Winter Plugin
But the server shouldn't be able to modify client's cl_* cvars, a client should just ignore it.
|
Re: AIO: Winter Plugin
wise ass, you have the option to ignore it. stop spamming with non-sense if you did not read the entire long post
|
Re: AIO: Winter Plugin
tuty please read here before insulting other members.
Since the latest updates clients that set cl_filterstuffcmd to 1 block most if not all commands from the server that try to set "cl_*" cvars. |
Re: AIO: Winter Plugin
And? Plugin works anyway :) Why you all chat nonsense when you dont even have a clue how this plugin works. Test it first then chat nonsense
|
Re: AIO: Winter Plugin
I took the time and tested it.
If i have cl_filterstuffcmd set to 1 your plugin cannot change cl_weather cvar for me. I get the allaround known errormessage in the console "server tried to send invallid command blabla. |
Re: AIO: Winter Plugin
With cs_filterstuffcmd 0 it works, the menu is still welcome. You can try to query cl_filterstuffcmd cvar, if 0 show the menu, if 1 tell them to manually do the settings.
|
Re: AIO: Winter Plugin
Great!
But the video dosen't work for me, just it says the video is unavailable. |
Re: AIO: Winter Plugin
Fix the video, or add some more screenshots.
Cool plugin btw. |
Re: AIO: Winter Plugin
do you happened to have a version for TFC?
|
Re: AIO: Winter Plugin
I tested the plugin and I'm half really impressed! In fact, there are a lot of unnecessary things that I don't like, such as the grenade and knife models. The Christmas tree of terrorists is hellishly big and disappointing! For counter-terrorists, I'm really impressed with the Christmas tree, but I don't like the pulsing light. It would be more pleasant for the light always to shineand constantly changing its colors. The console command cl_weather is ,,SlowHacking". Only if the tree of counter-terrorists could be separated into a new plugin would it be an incredible plugin for any type of server. :P
|
All times are GMT -4. The time now is 01:04. |
Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.