Explicitly mark old pdata API as deprecated
 

The old pdata API, which takes hardcoded offsets, should be marked as deprecated in the documentation to discourage its use. Since Valve is updating the games again any plugins that use it can end up breaking.

The APIs involved in this are located in FakeMeta and HamSandwich:
https://www.amxmodx.org/api/fakemeta
https://www.amxmodx.org/api/hamsandwich/get_pdata_cbase

Other modules may also contain similar APIs that require users to be directed to a safe variant.

Re: Explicitly mark old pdata API as deprecated
 

Does there already exist "safe variants" for everything that those functions can do?

Re: Explicitly mark old pdata API as deprecated
 

Based on the API documentation i'd say so. The new API internally handles different data types so it looks like you can get even more data types than before.

Re: Explicitly mark old pdata API as deprecated
 

The get|set_pdata_* API should not be deprecated because it's not broken and still useful for games which don't have a gamedata file. However I do agree updating the documentation to encourage the use of the new get|set_ent_data*, get|set_gamerules* API for the supported games would be welcomed.
[Edit: well, I would not mind to deprecate them for the supported games, but I don't think we can do conditional with #pragma deprecated. I guess it will be worth to say a word about it in the next news].

It reminds me we don't have an automatic system to extract and update the new offsets in the gamedata files.
If i remember, I used a semi-automatic way such as dumping dwarf infos from latest .so and using some plugin to generate the files. I'm not sure I still have this plugin. Would be nice if someone could help in making a robust & automatic system for that.

Re: Explicitly mark old pdata API as deprecated
 

If you have anything left from that i could take a look and maybe put something together to fully automate the process. I'll also need the spec for the config files that need to be generated.

Edit: i found this: https://github.com/eliben/pyelftools

Could be a good starting point.