AlliedModders - [Solved] Bitwise Operation

AlliedModders (https://forums.alliedmods.net/index.php)

- Scripting (https://forums.alliedmods.net/forumdisplay.php?f=107)

- - Solved Bitwise Operation (https://forums.alliedmods.net/showthread.php?t=311400)

Bitwise Operation

Hey all!

So, I am trying to learn how to use bitwise operation as a replacement for booleans (ex. bool g_bEnabled[MAXPLAYERS+1]) (performance optimization).

Here is something I have coded:

PHP Code:


		
			
#include <sourcemod>



int g_iClients;



public void OnPluginStart()

{

    RegAdminCmd("sm_testbit", Command_Callback, ADMFLAG_ROOT);



    if (GetClientCount(true))

    {

        for (int i = 1; i <= MaxClients; i++)

        {

            if (IsClientInGame(i) && !IsFakeClient(i))

            {

                OnClientPostAdminCheck(i);

            }

        }

    }

}



public void OnClientPostAdminCheck(int client)

{

    g_iClients |= client;

}



public void OnClientDisconnect(int client)

{

    g_iClients &= ~client;

}



public Action Command_Callback(int client, int args)

{

    ReplyToCommand(client, "[SM] g_iClients: %s.", g_iClients & client ? "Found" : "Not found");

    return Plugin_Handled;

}

I have 2 questions:
1.) Did I add and remove the client indexes correctly with the g_iClients variable?
2.) Would I use:

Code:

g_iClients & client

Or:

Code:

g_iClients & (1 << client)

To check if the client exists in the variable?

Thanks,
Grant

Re: Bitwise Operation

Just use arrays, it's okay.

Re: Bitwise Operation

You're or-ing multiple values with shared bits (look at a binary chart). You'd probably want to do (1 << client) every time you add / remove / check for a flag, but otherwise you're using the correct bitwise operations.

Really though, I've also considered doing this before. Just use an array for client indices. Pawn cells are 32-bit values, so your code would be broken on client indices greater than 31 (considering the first client index is 1 you're already not using the rightmost bit). Even TF2 has a high client iindex of 33 (34?) with SourceTV and/or Replay present and a raised maxplayers value.

Re: Bitwise Operation

Quote:

Originally Posted by KliPPy (Post 2619942)

Just use arrays, it's okay.

Quote:

Originally Posted by nosoop (Post 2619945)

Thanks guys!