AlliedModders - Timer problems

AlliedModders (https://forums.alliedmods.net/index.php)

- Scripting (https://forums.alliedmods.net/forumdisplay.php?f=107)

- - Timer problems (https://forums.alliedmods.net/showthread.php?t=264404)

PHP Code:


		
			
public Action:Event_Round_Start(Handle:event, const String:name[], bool:dontBroadcast) 

{

    iTime = GetTime();

    CreateTimer(60.0, GodOff);

    for(new i = 1; i<=MaxClients;i++)

    {

        if(IsClientInGame(i) && IsPlayerAlive(i))

            SetEntProp(i, Prop_Data, "m_takedamage", 0, 1);

    }

}



public Action:GodOff(Handle:timer)

{

    int iRoundTime = GetTime() - iTime;

    if(iRoundTime == 60) // Checking again time for bugs

    {

        for(new i = 1; i<=MaxClients;i++)

        {

            SetEntProp(i, Prop_Data, "m_takedamage", 2, 1);

        }

        CreateTimer(90.0, GiveBeacon);

    }

}



public Action:GiveBeacon(Handle:timer)

{

    int iRoundTime = GetTime() - iTime;

    if(iRoundTime == 150)

    {

        ServerCommand("sm_beacon @all");

        CreateTimer(90.0, blabla...);

    }

}



...

How can I optimize this code?
I know, i'm really a poor coder :D

Re: Timer problems

i used OnGameFrame, with this i got better stability.
Now works correctly..

Re: Timer problems

Code:

public Action:Event_Round_Start(Handle:event, const String:name[], bool:dontBroadcast)

{

        for (new i = 1; i <= MaxClients; i++)

        {

                if(IsClientInGame(i) && IsPlayerAlive(i))

                {

                        SetEntProp(i, Prop_Data, "m_takedamage", 0, 1);

                }

        }

        

        CreateTimer(60.0, GodOff);

}



public Action:GodOff(Handle:timer)

{

        for(new i = 1; i <= MaxClients; i++)

        {

                SetEntProp(i, Prop_Data, "m_takedamage", 2, 1);

        }

        

        CreateTimer(90.0, GiveBeacon);

}



public Action:GiveBeacon(Handle:timer)

{

        ServerCommand("sm_beacon @all");

        

        CreateTimer(90.0, blabla...);

}

Not sure what you're trying to do but that's what I see.

Re: Timer problems

Here's another example of working with timers you want to execute only if certain conditions apply... like resetting every round_start event

code