AlliedModders - [ JailBreak Mod By Natsheh ]

AlliedModders (https://forums.alliedmods.net/index.php)

- Unapproved/Old Plugins (https://forums.alliedmods.net/forumdisplay.php?f=27)

- - [ JailBreak Mod By Natsheh ] (https://forums.alliedmods.net/showthread.php?t=227535)

[ JailBreak Mod By Natsheh ]

Re: [ JailBreak Mod By Natsheh ]

1. Specify what days does the day menu have.
2. Does it include last request?
3. Make a better description, people won't test this plugin unless they know what it has and does.

I haven't tested this plugin nor read the code but let's hope it's not a lame mod like most jb plugins that have been released over the past few months. And that's why most of them got unapproved so fast.

Re: [ JailBreak Mod By Natsheh ]

Some Suggestions:
- In the last-request, use enums, its better.
- Remove CurWeapon Event and use Ham_Item_Deploy.

Lines 1636-1643:

Code:

case 1: Duel_info[ id ] = 1 case 2: Duel_info[ id ] = 2 case 3: Duel_info[ id ] = 3 case 4: Duel_info[ id ] = 4 case 5: Duel_info[ id ] = 5 case 6: Duel_info[ id ] = 6 case 8: Duel_info[ id ] = 8

:arrow:

Code:

Duel_info[ id ] = item;

Line 1654:

Code:

get_players(players, pnum, "a")

:arrow:

Code:

get_players(players, pnum, "aceh", "CT")

Line 2421:

Code:

if(Day_CD == 10) client_cmd(0, "spk ^"CD/ten.wav^"") if(Day_CD == 9) client_cmd(0, "spk ^"CD/nine.wav^"") if(Day_CD == 8) client_cmd(0, "spk ^"CD/eight.wav^"") if(Day_CD == 7) client_cmd(0, "spk ^"CD/seven.wav^"") if(Day_CD == 6) client_cmd(0, "spk ^"CD/six.wav^"") if(Day_CD == 5) client_cmd(0, "spk ^"CD/five.wav^"") if(Day_CD == 4) client_cmd(0, "spk ^"CD/four.wav^"") if(Day_CD == 3) client_cmd(0, "spk ^"CD/three.wav^"") if(Day_CD == 2) client_cmd(0, "spk ^"CD/two.wav^"") if(Day_CD == 1) client_cmd(0, "spk ^"CD/one.wav^"")

:arrow:

Code:

static szNumberWord[ 20 ]; num_to_word( Day_CD, szNumberWord, charsmax( szNumberWord ) ); client_cmd(0, "spk ^"CD/%s.wav^"", szNumberWord);

Here to:

Code:

precache_sound("CD/one.wav") precache_sound("CD/two.wav") precache_sound("CD/three.wav") precache_sound("CD/four.wav") precache_sound("CD/five.wav") precache_sound("CD/six.wav") precache_sound("CD/seven.wav") precache_sound("CD/eight.wav") precache_sound("CD/nine.wav") precache_sound("CD/ten.wav")

I will check the code more later and tell you more things.

Re: [ JailBreak Mod By Natsheh ]

Quote:

Originally Posted by @.SizNeR (Post 2044571)

Thx For Ur help & Your Time :)

Re: [ JailBreak Mod By Natsheh ]

File JailBreak-Mod.zip removed as it contained an AMXX file

Re: [ JailBreak Mod By Natsheh ]

instead of using this slow hack which by the way does not work after latest update.

Code:

public client_connect(id)
{
    new szMapName[32]
    get_mapname(szMapName, charsmax(szMapName))
    
    if(contain(szMapName, "jail_") != -1)
        client_cmd(id, "bind m amx_jail_menu")
}
public client_disconnect(id)
{
    new szMapName[32]
    get_mapname(szMapName, charsmax(szMapName))
    
    if(contain(szMapName, "jail_") != -1)
        client_cmd(id, "bind m jointeam")
}

why not just

Code:

 register_clcmd( "jointeam", "GuardMenu" );

??

this way nothing is changed after they leave server.

Re: [ JailBreak Mod By Natsheh ]

Quote:

Originally Posted by Blizzard_87 (Post 2044783)

instead of using this slow hack which by the way does not work after latest update.

Code:

public client_connect(id)
{
    new szMapName[32]
    get_mapname(szMapName, charsmax(szMapName))
    
    if(contain(szMapName, "jail_") != -1)
        client_cmd(id, "bind m amx_jail_menu")
}
public client_disconnect(id)
{
    new szMapName[32]
    get_mapname(szMapName, charsmax(szMapName))
    
    if(contain(szMapName, "jail_") != -1)
        client_cmd(id, "bind m jointeam")
}

why not just

Code:

 register_clcmd( "jointeam", "GuardMenu" );

??

this way nothing is changed after they leave server.

its dont work!!!

Re: [ JailBreak Mod By Natsheh ]

Quote:

Originally Posted by Blizzard_87 (Post 2044783)

this way nothing is changed after they leave server.

You guys are forgetting that you can't change anything of the client's after they have left the server. client_disconnect() is called when the server receives the the message from the player pressing the disconnect button which closes the connection or player timed out therefore its too late anyway,

Re: [ JailBreak Mod By Natsheh ]

Quote:

Originally Posted by hornet (Post 2044969)

Several pieces of this plugin are copied and pasted.
A bucketload of harcoded values / strings.
You have double hooked forwards.
Very little is customizable ... Who wants to run a JailBreak server that is identical to someone elses?
etc.

Reccomend that you re-write this when you have a greater knowledge of amxx.

You guys are forgetting that you can't change anything of the client's after they have left the server. client_disconnect() is called when the server receives the the message from the player pressing the disconnect button which closes the connection or player timed out therefore its too late anyway,

dude imade this plugin and ididnt copied !!!!

and tech me! to have greater knowledge of amxx

Re: [ JailBreak Mod By Natsheh ]

I was hoping you would of realized that jointeam is command which is sent after choosing a team

So use the chooseteam command instead.