Some simple solutions
 

They are all described with an example.

Correct Definition

Correct Numerical Data Types

not only
but also
Clean Cvar Usage

correct way
Clean Algorithm

1:

to
2:

to
That's just me.

You can add what you know.

Re: Some simple solutions
 

It won't throw any warning. cs_get_user_team is already tagged as CsTeams. You should take a look at how tags work.

Same thing, tagging a float as a Float makes no sense.

First line is wrong, p_Gravityshould be tagged as Float(i.e. new Float:pGravity[MAX_PLAYERS). Also p usually stands from "pointers", so you should use f if you really want to use HN.
Second line is also wrong, float it's a custom tag, the default one is called Float. Again, variable should be tagged as Float, not the value(because the value it's already a float).

Correct way:
I would also like to add something about this kind of initialization:
This won't set all array cells to 1, only the first one(var[0] is 1, but var[1],var[2], ... are 0). If you want to initialize the entire array with 1, you should do:
Won't throw any error if the cvar is present. Anyway, don't use cvars, use pcvars, they are faster(get_pcvar_num).

What you did here is basically to cache the cvar value, so if it's changed in-game it won't take affect until the next map change.

p_Name should be 32, not 33 and in get_user_name you should put size - 1, so 31. Indexing pName by MAX_PLAYERS is confusing. You would do that when you want to have an array for players, but here you are using a char array to store the name of ONLY ONE player at a time. So just put 32.
The usage of charsmax() is correct.

While you could argue that's for readability it does not provide any performance optimization.

Don't get me wrong, I'm not picking on you, I'm trying to explain some stuff that seems to confuse you.

Re: Some simple solutions
 

Makes no sense just like Hamlet said.

That's bad practice, creating a variable costs you.

Max Players is 32, you would do

Re: Some simple solutions
 

In some cases due to differences in definition tags, becomes an unreadable command array (It's always like this)

of course, it makes sense for pawn just like c++
if you don't pay attention to the case, it will cause "Tag mismatch warming". You can try this

diffrence (it will cause fatal fault)

--


You're right about that. This is my fault

You can try this will not make a difference.

if plugin send this command to client all time, it will cause SZ_getSpace overflow without FSB_ALLOW OVERFLOW

The fact that this change in client isn't healthy will lead to mistakes.
For this reason, these are done with "cfg" before the game.

Amxmodx (1.8.3-dev) after updating "MAX_PLAYERS 32 and [MAX_PLAYERS+1]" is changed.
if you do this, you will encounter a lot of errors

new functuality from AMXX amxconst.inc

MAX_PLAYERS 33 and and without + 1 ([MAX_PLAYERS])

That's right.

I made the necessary explanations for you, thank you for your comment.

Re: Some simple solutions
 

What?
Both the return value of cs_get_user_team() and CS_TEAM_T constant are tagged with CsTeams:, a tag override is redundant.


Floating point values are implicitly tagged with Float: in Pawn, there's no need to override the tag. Again, redundant.

What command? Getting a cvar value is never sent to clients and you can do it as many times as you want in a single frame. As Hamlet said, use pcvars. In 1.8.3, use cvar binding.

In 1.8.3 there's
use that size for clients' names.

Re: Some simple solutions
 

I'm not talking about client name. Client ID I'm talking about

Re: Some simple solutions
 

Here you are not coding in c++, keep that in mind. Most of what you say is wrong.

I'm going to answer now only on what Klippy did not.
What about you trying it?

Output:
Lol, that's the entire purpose of a cvar. The cvar is to let server admins to change plugin behaviour on the fly, without needing to recompile or change/restart map.
If something is prone to error and could produce a crash or something just don't expose that value by cvars or enforce proper filtering on it to prevent bad values.

Indexing a string array that should store a player name by a constant used to size arrays for players is confusing. Use 32, make your own define if you are using amxx < 182 or use the proper constant as Klippy said.

Edit:
Klippy and I are talking about this:
Here you are not using p_Name as an array to store data for each player, it's going to save a player name. Let's say the player name is "ABCDEFGHIJ", then:

Re: Some simple solutions
 

Seems to be lacking some key knowledge on tags, arrays, and globals.

I'm going to close this thread as it will probably lead to more confusion/arguing. For understanding the issues, see other posts or more info below:

1. CS_TEAM_* constants are the CsTeams tag, no need to retag.
2. Retagging floats is unnecessary.
3. Untagged [int] array created, but forcing float data. Better example:
   
   PHP Code:

   ---

   new Float:gfPlayerGravity[ MAX_PLAYERS + 1 ];  //global float array to cache the last set gravity value by this plugin; for active gravity [from any plugin] use get_user_gravity instead of this array

SetPlayerGravity( iPlayer, Float:fGravity )
{
    gfPlayerGravity[ iPlayer ] = fGravity; //update our cached value for iPlayer
    set_user_gravity( iPlayer, fGravity ); //set gravity with fun module
} 


   ---

4. Pcvar example:
   
   PHP Code:

   ---

   new pcvar_max_money;
new giMaxMoney;
new giPlayerMoney[ MAX_PLAYERS + 1 ];

public plugin_init()
{
    pcvar_max_money = get_cvar_pointer( "max_money" );
    //get pcvar value
    //giMaxMoney = get_pcvar_num( pcvar_max_money ); // this retrieves the cvar at time of plugin_init
    bind_pcvar_num( pcvar_max_money, giMaxMoney ); // binds the cvar to the global variable, so we do not need to retrieve each time
}
public client_authorized( iPlayer )
{
    giPlayerMoney[ iPlayer ] = giMaxMoney; //update our cached value for iPlayer
    cs_set_user_money( iPlayer, giMaxMoney, .flash = 0); //set money with cstrike module
} 


   ---

5. MAX_PLAYERS is being used as a string length instead of an array size. Local string example:
   
   
   PHP Code:

   ---

   funcRandom( iPlayer )
{
    new strPlayerName[ MAX_NAME_LENGTH ];  //creating a string 32 cells long
    get_user_name( iPlayer, strPlayerName, charsmax( strPlayerName ) );
    //...
} 


   ---

   Global string example:
   
   PHP Code:

   ---

   new gstrPlayerName[ MAX_PLAYERS + 1 ][ MAX_NAME_LENGTH ]; //creating a global string array to cache player names

funcRandom( iPlayer )
{
    get_user_name( iPlayer, gstrPlayerName[ iPlayer ], charsmax( gstrPlayerName[] ) );
    //...
} 


   ---