AlliedModders
Page 1 of 3 1 23
Show 40 post(s) from this thread on one page

AlliedModders (https://forums.alliedmods.net/index.php)
-   Plugins (https://forums.alliedmods.net/forumdisplay.php?f=108)
-   -   [ANY? / CSGO] ExecuteStringCommand Crash Fix (https://forums.alliedmods.net/showthread.php?t=301126)

SM9 09-08-2017 20:26
[ANY? / CSGO] ExecuteStringCommand Crash Fix
 
2 Attachment(s)
Firstly, I am not going to say how to reproduce the crash, but notably most CSGO servers are affected, even servers without Sourcemod (I am sorry about the misconception earlier)

I am not sure if games like TF2, CSS etc are affected but the fix should work regardless minus the PTAH support.
If you have a CSGO server you can install PTAH for enhanced protection at an even earlier stage.

Optional requirements: PTAH (CSGO only)

Credits to these guys for helping track down the exploit:
Asherkin
Voided
Dr!fter
OfficialSikari for helping figure out how to replicate the issue.

Credits to komashchenko for PTAH.

Thanks to Kinsi for helping me test it.

Kinsi 09-08-2017 20:29
Re: [CSGO] ExecuteStringCommand Crash Fix
 
This crash has driven me nuts over the past weeks because of how infrequently / randomly it happened, and i believe we might've finally found the culprit. A lot of thanks to Asherkin, Dr!fter and VoiDeD for doing pretty much all of the work tracking it down. PM'd asher and we'll have to hope for a quick patch, for the while, this does the job.

SM9 09-08-2017 21:34
Re: [CSGO] ExecuteStringCommand Crash Fix
 
Updated to 0.3 -
  • Added logging to file.

SM9 09-08-2017 23:03
Re: [ANY? / CSGO] ExecuteStringCommand Crash Fix
 
Updated to 0.4 -
  • Make sure server is processing (Apparently this was needed even though we don't block the server anyway?? wtf).

KyleS 09-09-2017 02:20
Re: [ANY? / CSGO] ExecuteStringCommand Crash Fix
 
Quote:
Originally Posted by xCoderx (Post 2547615)
Firstly, I am not going to say how to reproduce the crash, but most servers which run Sourcemod are currently affected, and the SM dev team does not plan to fix the problem even though it only happens with servers that run Sourcemod.
This isn't even close to accurate. SM may add some processing time to a client connection that makes this easier to trigger with your rudimentary steps to reproduce, but the cause is not SourceMod at all and has been explained to you a number of times by a number of people.

Visual77 09-09-2017 03:38
Re: [ANY? / CSGO] ExecuteStringCommand Crash Fix
 
This was already in smac/rcon_lock

FlawlessKush 09-09-2017 07:42
Re: [ANY? / CSGO] ExecuteStringCommand Crash Fix
 
Quote:
Originally Posted by Visual77 (Post 2547647)
This was already in smac/rcon_lock
??? so we dont need this then if we use smac or is this more effective?


@xCoderx

Code:
[SM] Exception reported: Client index 10 is invalid (arg 3)
L 09/09/2017 - 02:13:08: [SM] Blaming: ExecuteStringCmdCrashFix.smx
L 09/09/2017 - 02:13:08: [SM] Call stack trace:
L 09/09/2017 - 02:13:08: [SM]  [0] LogToFileEx
L 09/09/2017 - 02:13:08: [SM]  [1] Line 51, C:\Users\Michael\Desktop\ExecuteStringCmdCrashFix.sp::ExecuteStringCommand
L 09/09/2017 - 02:38:38: Error log file session closed.

KyleS 09-09-2017 10:34
Re: [ANY? / CSGO] ExecuteStringCommand Crash Fix
 
Quote:
Originally Posted by FlawlessKush (Post 2547692)
??? so we dont need this then if we use smac or is this more effective?


@xCoderx

Code:
[SM] Exception reported: Client index 10 is invalid (arg 3)
L 09/09/2017 - 02:13:08: [SM] Blaming: ExecuteStringCmdCrashFix.smx
L 09/09/2017 - 02:13:08: [SM] Call stack trace:
L 09/09/2017 - 02:13:08: [SM]  [0] LogToFileEx
L 09/09/2017 - 02:13:08: [SM]  [1] Line 51, C:\Users\Michael\Desktop\ExecuteStringCmdCrashFix.sp::ExecuteStringCommand
L 09/09/2017 - 02:38:38: Error log file session closed.
Yes, this engine/game issue has been fixed in plugins for roughly a decade now (as explained to both of them in IRC).

SM9 09-09-2017 11:23
Re: [ANY? / CSGO] ExecuteStringCommand Crash Fix
 
Quote:
Originally Posted by KyleS (Post 2547741)
Yes, this engine/game issue has been fixed in plugins for roughly a decade now (as explained to both of them in IRC).
Quote:
Originally Posted by KyleS (Post 2547643)
This isn't even close to accurate. SM may add some processing time to a client connection that makes this easier to trigger with your rudimentary steps to reproduce, but the cause is not SourceMod at all and has been explained to you a number of times by a number of people.
Sorry about the confusion, it appears to be a game bug with the game itself.

Quote:
Originally Posted by FlawlessKush (Post 2547692)
??? so we dont need this then if we use smac or is this more effective?


@xCoderx

Code:
[SM] Exception reported: Client index 10 is invalid (arg 3)
L 09/09/2017 - 02:13:08: [SM] Blaming: ExecuteStringCmdCrashFix.smx
L 09/09/2017 - 02:13:08: [SM] Call stack trace:
L 09/09/2017 - 02:13:08: [SM]  [0] LogToFileEx
L 09/09/2017 - 02:13:08: [SM]  [1] Line 51, C:\Users\Michael\Desktop\ExecuteStringCmdCrashFix.sp::ExecuteStringCommand
L 09/09/2017 - 02:38:38: Error log file session closed.
If you are running CSGO and PTAH then this will be more effective as it blocks the string command at a lower level, otherwise its the same as smac_commands

I have also fixed the error in 0.5, thanks for telling me about it.

Updated to 0.5 -
  • Reordered logic, (Thanks Headline for sanitizing things)

Morell 09-10-2017 02:36
Re: [ANY? / CSGO] ExecuteStringCommand Crash Fix
 
The bug that fixes it might be this one?

sourcemod.2.csgo.dll!__SourceHook_FHCls_ConCo mmandDispatchfalse::Func(CCommand const &) [GameHooks.cpp:45 + 0xa3]


All times are GMT -4. The time now is 16:58.
Page 1 of 3 1 23
Show 40 post(s) from this thread on one page

Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.