AlliedModders

AlliedModders (https://forums.alliedmods.net/index.php)
-   Unapproved/Old Plugins (https://forums.alliedmods.net/forumdisplay.php?f=27)
-   -   amx_searchcmd alias (https://forums.alliedmods.net/showthread.php?t=314686)

DJEarthQuake 03-02-2019 22:36

amx_searchcmd alias
 
1 Attachment(s)
https://i.imgur.com/hraT1Ux.gif
Amx_searchcmd aliases: Exclamation point ! question mark ? and the period .
Instead of type out amx_searchcmd you can use a period or other alias.
Requirements: AMXX 1.9+
Language File project | Amxx 182 version

thEsp 03-03-2019 04:42

Re: Easy adminhelp
 
What is this supposed to do ? Add more description.

DJEarthQuake 03-03-2019 08:07

Re: Easy adminhelp
 
Purpose of work is to type ? or other marks instead of only amx_searchcmd.
These are all aliases to amx_searchcmd which more less is GREP.

So when one only recalls part of the command this will find all commands that contain that part and list only those instead of go through the entire list with amx_help 11 haphazardly.

fysiks 10-11-2019 22:27

Re: Amx_searchcmd punctuation mark. (Easy) Adminhelp.sma.
 
You still don't have a description of your plugin and your OP is formatted terribly. "amx_get" as a command for this makes absolutely no sense.

Why do variable have nonsensical names? Why is the indentation all messed up in the places that you edited?

The poor coding style and the trivial changes in this plugin make it the perfect candidate for being unapproved.

DJEarthQuake 10-12-2019 02:10

Re: Amx_searchcmd punctuation mark. (Easy) Adminhelp.sma.
 
There's only so much one can say about replacing the stock adminhelp.sma modified for aliasing the partial search command.

DJEarthQuake 10-13-2019 10:36

Re: Aliases of Amx_searchcmd | Adminhelp.sma 10/12/2019
 
Code remake.

DJEarthQuake 10-22-2019 01:38

Re: Aliases of Amx_searchcmd | Adminhelp.sma 10/12/2019
 
@Rivotril Thank you for your translation work in Spanish. I've added it. All languages have been reformatted to handle the plugin but they need finalized. There is an open request in translations. I hope there is interest. Even without my plugin adminhelp.txt is still incorrect. Amxx is telling all users worldwide as they connect to use both amx_help and Amx_SearchCmd interchangeable.

DJEarthQuake 01-09-2020 08:25

Re: Aliases of Amx_searchcmd | Adminhelp.sma 01/09/2020
 
@Godofwar. Thank you for keeping the Amxx project alive translating German!

HamletEagle 01-09-2020 10:14

Re: Aliases of Amx_searchcmd | Adminhelp.sma 01/09/2020
 
I still have no clue what your plugin is supposed to do. I should not have to open the sma file and figure it out.
What about the regular user who doesn't know how to code? Your description should be clear(and not inexistent for that matter).
Please write some phrases that make sense and explain what this plugin is supposed to do. You should have all the relevant examples in the main post, not in random comments.

"Remake uses a 2-dimensional array and better language."
This is irrelevant information, server owners do not care what you used and how you used it, they want and need to know what is the purpose of the plugin.

DJEarthQuake 01-09-2020 11:32

Re: Aliases of Amx_searchcmd | Adminhelp.sma 01/09/2020
 
Okay please let me know if the new wording helps.

fysiks 01-09-2020 22:52

Re: Aliases of Amx_searchcmd | Adminhelp.sma 01/09/2020
 
The changes that you made to this default plugin are so trivial that it doesn't really merit posting it as a plugin submission.

Also, the fact that it's so trivial, it's a bit insulting that you changed the author of the plugin to some random name. I generally add my name after the original to denote that I'm a secondary author and/or add a signifier to the version (e.g. "f1", "f2", ..., etc.). And, this is even if I've made more than just trivial changes.

This whole thing can basically be accomplished with a separate plugin using client_cmd() or amxclient_cmd() without needing to replace the original adminhelp plugin. Another benefit to this approach is that it's basically forwards compatible! In fact, I suspect that there is a generic aliasing plugin already out there that can do this already.

Code:

#include <amxmodx>

public plugin_init()
{
        register_concmd("myAlias", "cmdAlias")
}

public cmdAlias(id)
{
        new szString[64]
        read_argv(0, szString, charsmax(szString))
        client_cmd(id, "amx_searchcmd %s", szString)
}


DJEarthQuake 01-12-2020 12:13

Re: Aliases of Amx_searchcmd | Adminhelp.sma 01/09/2020
 
Amx_searchcmd: aliasing aside, is incomplete on rolling release.
Plugin is here for feature enhancement feedback and help with the rolling releases’ unfinished language file.

Thread and script header: both show credits.
Everybody. Starting from Olo. Onto the AMXX Dev team, name-by-name. Individually. From the ‘translators’ to the ‘critics’. All parties. Have received credit.

The next iteration: trades defines for a command already.
The aliasing design intent was to take a load off not put one on.

HamletEagle 01-24-2020 06:12

Re: Admin Help PartSearch CMD Alias Arsenal
 
I have to agree with fysiks here.
I think it's a good idea to avoid posting modified default plugins(because when/if they get updated you would have to update your modified version and since people don't support plugins for an eternity we end up with broken stuff). If the modification is significant then the best course of action would be to make a pull request on github and try to get the changes in the official plugin.

However, in this particular case, you can avoid editing the default plugin as fysiks showed. This has the advantage of not breaking every time the official plugin is updated. But even then, it's a trivial plugin and I don't think it is enough to be considered for approval.

If you disagree with anything I said feel free to discuss, but for now, I will have to unapprove.

P.S: attach the plugin as a sma file, no need to copy/paste it inside the topic.

Napoleon_be 01-24-2020 08:02

Re: Admin Help PartSearch CMD Alias Arsenal
 
Why is my name in "pink" :nono:

DJEarthQuake 01-25-2020 01:50

Re: Admin Help PartSearch CMD Alias Arsenal
 
Fair appraisal. When I shared I knew it belonged on GitHub if it cliqued here. The translations I suspect will approach completion faster here than there.

Quote:

Originally Posted by Napoleon_be (Post 2681436)
Why is my name in "pink" :nono:

Napoleon_be it is a ROY G' Biv scheme. Your name landed on Magenta. This is so Why Am I Mr. Pink? - Reservoir Dogs!!


DJEarthQuake 06-09-2020 17:07

Re: AdminHelp PartSearch Command Aliasing
 
This alias plugin was remade to work on top of stock file. For those who prefer to type amx_searchcmd over a single character alias this plugin is not for you. The original version is still available.

Quote:

Originally Posted by HamletEagle (Post 2681429)
I think it's a good idea to avoid posting modified default plugins(because when/if they get updated you would have to update your modified version and since people don't support plugins for an eternity we end up with broken stuff).

Agreed. Example of an Approved Plugin that modifies default plugin.
Quote:

Originally Posted by Johnny got his gun (Post 74904)
I made this modified version of antiflood.sma awhile back. Replace your old one.



All times are GMT -4. The time now is 00:44.

Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.