AlliedModders - Plugin works in 1.8.2, breaks in 1.9

AlliedModders (https://forums.alliedmods.net/index.php)

- General (https://forums.alliedmods.net/forumdisplay.php?f=7)

- - Plugin works in 1.8.2, breaks in 1.9 (https://forums.alliedmods.net/showthread.php?t=322198)

Plugin works in 1.8.2, breaks in 1.9

Hi all, I have a plugin that works in 1.8.2, but compiling and running that same plugin in 1.9 no longer works completely correct. My hunch is that the way menu handling was implemented is breaking in 1.9.

Report this plugin on Github?

Re: Plugin works in 1.8.2, breaks in 1.9

Amxx should be backwards compatible so yes, you should report it(also provide the source code).

Re: Plugin works in 1.8.2, breaks in 1.9

It's Auto-Mix Pug by Diegorkable. It starts the voting process but then begins to loop voting for teams over and over again. Rather than proceeding to voteFF().

Re: Plugin works in 1.8.2, breaks in 1.9

This is unfortunate because I don't think anyone is willing to check a 5k plugin to find out the problem. Any chances you have some coding experience so you can extract that part in a small standalone plugin that replicates the issue?

Re: Plugin works in 1.8.2, breaks in 1.9

Edit: looking at the menu handling tutorial, many conventions were broken in this code regarding menu_destroy and trying to call the same menu handler within the menu handler.

PHP Code:


		
			
public votemap(id, menu, item) {

    if( item == MENU_EXIT ) {

        menu_display(id, g_gVoteMenu)

        return PLUGIN_HANDLED;

    }

...

So this code breaks in 1.8.3 and 1.9. Is this considered a bug still? Should we expect 1.9 to handle this?

And then when starting HLDS I see the following lines when running in 1.9, do these hold any significance?:

Code:

stray key in process_key: changeyaw 59

stray key in process_key: hashumangibs 60

stray key in process_key: hasaliengibs 61

stray key in process_key: fademonster 62

stray key in process_key: gibmonster 63

stray key in process_key: getdeathactivity 64

stray key in process_key: becomedead 65

stray key in process_key: irelationship 67

stray key in process_key: painsound 68

stray key in process_key: reportaistate 70

stray key in process_key: monsterinitdead 71

stray key in process_key: look 72

stray key in process_key: bestvisibleenemy 73

stray key in process_key: finviewcone 74

stray key in process_key: fvecinviewcone 75

stray key in process_key: item_getiteminfo 61

stray key in process_key: cstrike_item_isweapon 65

stray key in process_key: cstrike_weapon_sendweaponanim 85

stray key in process_key: cstrike_player_resetmaxspeed 69

stray key in process_key: cstrike_player_isbot 81

stray key in process_key: cstrike_player_getautoaimvector 85

stray key in process_key: cstrike_player_blind 86

stray key in process_key: cstrike_player_ontouchingweapon 87