Global Offensive Mod v1.1p
1 Attachment(s)
NEW VERSION! CLICK HERE . . . . . Global Offensive Mod 1.1 Public Version Description If you kill enemy chances are that found Chest or Key! Only weapons may find in the Chest. Get more skins! Settings Drops Quote:
New weapon [max 50] write last line "weapon ID" "name" "v mdl" "chance to find (1-100)" Rang "Rang Name" "Needed kill" Parts of Plugin
Lang
Commands
Install
Screenshots http://kepfeltoltes.hu/150702/419504...toltes.hu_.jpg http://kepfeltoltes.hu/150702/104331...toltes.hu_.jpg http://kepfeltoltes.hu/150702/197281...toltes.hu_.jpg http://kepfeltoltes.hu/150702/422041...toltes.hu_.jpg http://kepfeltoltes.hu/150702/205746...toltes.hu_.jpg http://kepfeltoltes.hu/150702/915642...toltes.hu_.jpg http://kepfeltoltes.hu/150702/384215...toltes.hu_.jpg http://kepfeltoltes.hu/150702/892355...toltes.hu_.jpg Changelog
Link: https://drive.google.com/file/d/0B64vWj0cMno8V2RqLUpkSktBNm8/view |
Re: Global Offensive Mod v1.0p
- You start the message in the first 67.3 then play it again in each 76.9s why? just add a loop 'b' and why those different num??
+ Code:
+I don't know why you don't use charsmax()!!! Man use it please. - You can increase the ( new data in the menu ) to -> [6]. + use static instead of -> new in -> new OldName[32], NewName[32], Name[32] ... + if(containi(Mdl, ".mdl") != -1) can be like this also -> if(equal(Mdl[strlen(Mdl)-4] , ".mdl")) well its the same. + Add a 'else' while opening the file with message if the file doesn't exist + Use 'case' instead of statement ( if ) in 'Key' in the menu. - If you want to clear a variable like the Password[id] = "" , i think its better to use EOS + if(Line[0] == ';' || strlen(Line) < 2) u can add this it won't hurt (Just in case) "|| (Line[0] == '/' && Line[1] == '/')" + Use DeathMsg instead of client_death ( client_death its can be efficient for getting the wpnindex and hitplace and TK + Add a check in Death(event) -> if ( is_user_connected(killer) ) + i've heard that client_death don't return anything like PLUGIN_HANDLED/CONTINUE .. , just do a 'return' in case if you keep client_death but DeathMsg event better. EDIT: - Code:
Why didn't you just use TEAM_COLOR? EDIT2 : Code:
Can just be like this : Code:
i think this is all what i've seen. if anything you see it wrong, just say it. |
Re: Global Offensive Mod v1.0p
I see some wrong things.
Quote:
Quote:
Quote:
Quote:
Please, learn more before correcting others. @DeRoiD, you should learn more(basic optimizations and good practices at least) before releasing a plugin. You have some nice ideeas, but if you can't code them in a proper way it's useless. |
Re: Global Offensive Mod v1.0p
Quote:
Quote:
Quote:
EOS = '^0' = 0 Quote:
Quote:
You didn't give me arguments. why i'm wrong :/! |
Re: Global Offensive Mod v1.0p
Quote:
1.Why the ... is a good habit to use static when changing names ? static should be used on forwards that are called often to allocate memory one time, how many times a user can change his name per second ? Try to use some logic. 2.Your example is wrong, this is what I said. Do you even test before posting ? 3.You wrote "'\0'", I just said that if I remeber well the control char is ^ and not \, also gave an advice to use the constant EOS for readability. 4.client_death does the same thing as DeadMsh, no matter the method in such case. What are you talking about ? Again, try to make some sense. |
Re: Global Offensive Mod v1.0p
Quote:
2- if(equal(Mdl[strlen(Mdl)] , ".mdl")) . Lol, i forgot -4 -> if(equal(Mdl[strlen(Mdl)-4] , ".mdl")). And yes i've test it but i copy the wrong script. 3- No comment 4- Read my first reply(#2) |
Re: Global Offensive Mod v1.0p
Quote:
In a forward (ChangeName in this case) that's called not-so-often it really depends on the coder. Some might want to sacrifice some memory(with static), and some might want to sacrifice like a microsecond of execution time (with new). Both are correct choices in this case, no reason to fight over that. |
Re: Global Offensive Mod v1.0p
It's still useless imo, over-optimizing is never a good choice. My point was that new is perfectly fine in this case and changing to static is not needed.
client_death is not a wrong choice, I don't see you giving a good reason. But, let's come back to the topic. |
Re: Global Offensive Mod v1.0p
Good idea, poorly done.
|
Re: Global Offensive Mod v1.0p
I like this idea ;)
|
All times are GMT -4. The time now is 13:39. |
Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.