Day/Night Effect V1.3
2 Attachment(s)
--=Day/Night Effect 1.3=--
Discripcion: Change the light and sky of map,according to the time. Credits: Gladius Idea Changelogs: 1.1:Add Lights 1.2: Existent file check 1.3: Optimization,Dynamic configuration Cvars: amx_dn_sky_on // on/off changing sky amx_dn_lights_on // on/off light change sky register: Create a file ". Ini." skys the name. Code:
;sky.ini Sorry for my English, I use translator. Someone would be so kind as to correct the translation. Thanks |
Re: Effect Day/Night V1.1
Good!
|
Re: Effect Day/Night V1.1
Quote:
|
Re: Effect Day/Night V1.1
Quote:
@EDIT Updated |
Re: Effect Day/Night V1.2
Nice Destro! GJ :P
|
Re: Effect Day/Night V1.2
There is something to optimize?
|
Re: Effect Day/Night V1.2
Code:
num_str_sky = "1" Code:
case 0..4: { Code:
case 0..4,23: { Code:
g_skyname[0] = ' ' The function set_effect does not need to be public. Should use log_amx instead of log_to_file. Instead of using a variable sky_load on line 122, you could simply check if g_skyname is empty or not. You could also attempt to move the functions load_sky and set_effect into plugin_precache, assuming that you can alter sv_skyname and use set_lights during that time, instead of during plugin_init. You use charsmax in several spots, would be better if you used it throughout the plugin. Also work on your whitespace. People prefer lines like this: Code:
if(!file_exists(file)){ Code:
if ( !file_exists( file ) ) Suggestions: Have the plugin check every hour for what sky should be present. (Some servers remain on a map for longer than an hour) Allow the skys.ini to specify a sky for certain hours, and not your 1 to 6 method. Also allow skys.ini to specify a light level for the matching sky. I would personally rename the plugin something along the lines of "hourly", "skys" and "lights". |
Re: Effect Day/Night V1.2
Quote:
pd: Quote:
|
Re: Effect Day/Night V1.3
change the version in .sma code because it's 1.1 i see the plugin is 1.3
|
Re: Effect Day/Night V1.3
In a hurry.:(
|
All times are GMT -4. The time now is 05:14. |
Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.