AWP Models [XP System Support]
2 Attachment(s)
https://raw.githubusercontent.com/Oc...er/version.png AWP Models https://raw.githubusercontent.com/Oc...ages/menu1.jpg https://raw.githubusercontent.com/Oc...ages/menu3.png ☄ Description
☄ Cvars
☄ Adding skins
https://raw.githubusercontent.com/Oc...using_this.png https://raw.githubusercontent.com/Oc...plugin_lab.png https://raw.githubusercontent.com/Oc...ad_default.png |
Re: AWP Models
I think adding a cvar for put a message in the menu is not a good idea, do you? Will be better users change them in the .ini file.
I like this, most of users here will like aswell. Will be good with more weapons. |
Re: AWP Models
Why is it a bad idea? It's usually a bad idea when the message is supposed to be long, but in this case it's only one word with a few colors that needs to fit in one line in the menu, so I don't think that's a problem.
I made this especially for an AWP server, so that's why I didn't add an option for all the other weapons, plus I don't really feel like doing such a big plugin. I also have another one for a knife server with knife models, but I don't know if it is a good idea to post both. |
Re: AWP Models
If you think that it can be how its right now, just do what your mind says.
Yea, the code will be so much long, but just use your knowledge with enumerates and arrays, you know so much things with these formats. You can minimize so much lines with this. Here's my changes: 1. In ColorChat(): You can cache the value of iPlayers[i] with an interger. You need not start the iCount with 1 is_user_connected() is not needed Here: PHP Code:
And you're using the g_iSayText just one time, you can cache only if you use a native more than one time. Just add get_user_msgid("SayText"). |
Re: AWP Models
I don't want to make this code complicated and use .ini files for settings. The least I can do is add a lang file and put all the messages there.
That ColorChat is not even mine, I have been using it since forever and approvers don't have a problem with it. But now that you mention it, you're right, maybe it should be fixed, but I really don't want to experiment with it, since I haven't had any problems with it. It starts from 0 with a reason, take a look at the beginning of the function. However, you're wrong about the SayText part. The code is used every time when ColorChat is called, aka every time a message is sent, so it will search the msgid every time it is used. Caching it in plugin_init will is totally correct. |
Re: AWP Models
Okay.
Yea yea, I was wrong, I've searched and everyone use like this, you're totally right, my mistake. And I knew its not your ColorChat. |
Re: AWP Models
Update v1.3 @ 05.02.2017
|
Re: AWP Models
PHP Code:
You doesn't make all changes I said on ColorChat(). |
Re: AWP Models
What's wrong? I didn't do any changes because you said you're wrong, or did you change your mind now?
|
Re: AWP Models
I said i was wrong about the MsgSayText ._.
And, why would you add a ML for the tag prefix? Or I've readed it wrong? |
All times are GMT -4. The time now is 11:52. |
Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.