Dispenser Music Choice - Rex Subplugins
 

Hi!

It's my first post here, so don't judge strictly :)

Updated the old one plugin (ordinary post - https://forums.alliedmods.net/showthread.php?p=1982288) with some new features.

1) New commands:
1.1) sm_dm <number> or !dm <number> - select the current song for your dispenser if it's built. Song list based on config further down the post. Default Flag - Reservation.
1.2) sm_dmtarget @player <number> or !dmtarget @player <number> - the same as previous one, but now you can select dispenser music for other players (only for 1 per time). Default Flag - Cheats.
1.3) sm_dmall <number> or !dmall <number> - select music for all dispensers on map. Will not work, if dispenser has no owner, forced by RTD or disabled for the owner with !dispenser command. Default Flag - Cheats.
1.3.1) CVAR sm_dmusic_delay (def = 30.0) - players can't select music with !dm after someone used !dmall for this amout of seconds.

2) Now plugin is fully compatible with backpackdispenser and multiple_buildings plugins.
3) Music removes after end of the round or dispenser owner's death (and if dispenser was destoyed).

4) !dm can be used only if:
4.1) You are alive
4.2) You are engineer
4.3) You have build the dispenser
4.4) You turned on !dispenser command, which allows playing music

5) If some dispensers are in the one area at the same moment, admin can use !dmall to select one melody for all of them, which will be bassboosted for as many dispensers as are beside each other.

----

Old ones:
1) sm_dispenser or !dispenser - Allow your dispensers playing music. Rebuild your dispenser after changing this setting.
2) Songs are going one by one.

----
Some bugs:
1) !dm_all will not work, if there are more than 5 dispensers in one place at the same moment.
2) The same for !dm and !dmtarget if you use multiple_buildings plugin.
3) Rare error: !dm, !dmtarget, !dmall only remove sounds without playing the selected ones. Just rewrite the command.

config goes to addons/sourcemod/configs. Don't forget to add something!
plugin goes to addons/sourcemod/plugins.

Re: Dispenser Music Choice - Rex Subplugins
 

Good work, ̶b̶u̶t̶ ̶y̶o̶u̶ ̶f̶o̶r̶g̶o̶t̶ ̶t̶o̶ ̶s̶h̶a̶r̶e̶ ̶t̶h̶e̶ ̶s̶o̶u̶r̶c̶e̶c̶o̶d̶e̶.̶

Re: Dispenser Music Choice - Rex Subplugins
 

Done

Re: Dispenser Music Choice - Rex Subplugins
 

From what I see, the plugin is a combination of old and new syntax, and it's recommended that you don't mix these two. It's not a serious issue, but I recommend you to update it if you intend to continue supporting the plugin.

I also think VSH/Freak Fortress is not the place where this should be posted, general Plugins thread is way better.
Quoting the forum's rules:
"If you post (or see a post) in the wrong section, use the Report Post button to request it be moved rather than replying to the thread."

Re: Dispenser Music Choice - Rex Subplugins
 

took a quick look, here are some critics/feedback for now:
if you want to rework on it, dont copy mistakes.
by that i mean:
1- never store entity by its index.
2- do you really need to convert entity index to string just to insert a handle it to a trie
3- you know you can use ArrayList(2) instead of two different versions of ArrayList()?
4- you don't need to delete cookies onpluginend, since they will be automatically freed
5- Like NoloZero01 said, don't mix old syntax with new ones
6- This is wrong section to post plugin, use Plugins thread

Re: Dispenser Music Choice - Rex Subplugins
 

Unfortunately plugins can't be moved into the plugins forum, you'll need to re-post it there.