AlliedModders - [TF2] Sheens 1.2

AlliedModders (https://forums.alliedmods.net/index.php)

- Plugins (https://forums.alliedmods.net/forumdisplay.php?f=108)

- - [TF2] Sheens 1.2 (https://forums.alliedmods.net/showthread.php?t=314877)

[TF2] Sheens 1.2

This plugin allows you to apply sheens and killstreak effects on a weapon.

Commands:
sm_sheens [sheen] [effect]
sm_sheen [sheen] [effect]
Default flag: k

Cvars:
sm_sheens_version - Sheens Plugin Version
sm_sheens_flag - Sheens Access Flag

Installation:
Put sheens.smx into tf/addons/sourcemod/plugins
Put tf2.attributes.txt into tf/addons/sourcemod/gamedata
Put sheens.phrases.txt into tf/addons/sourcemod/translations

Changelog

Re: [TF2] Sheens

Why not just use tf2attributes?

Re: [TF2] Sheens

Quote:

Originally Posted by Mitchell (Post 2642832)

Why not just use tf2attributes?

I don't really like using external stuff for the plugins I make.
You can also use the gamedata/tf2attributes.txt if you rename it to sheens.txt and it will work with the plugin though.

Re: [TF2] Sheens

Three things:

If you're gonna recreate the wheel by copying tf2attributes code into the plugin for use, at least have the plugin use the same gamedata file.
You're leaking handles with your menus, you need to kill the menu handles in the callbacks with MenuAction_End.
You can methodmap a whole lot of this and create the menus early and save them for use multiple times as well.

Re: [TF2] Sheens

Quote:

Originally Posted by Drixevel (Post 2642863)

Three things:

If you're gonna recreate the wheel by copying tf2attributes code into the plugin for use, at least have the plugin use the same gamedata file.
Your leaking handles with your menus, you need to kill the menu handles in the callbacks with MenuAction_End.
You can methodmap a whole lot of this and create the menus early and save them for use multiple times as well.

Thanks! I fixed the leaks and made it use the same gamedata file then. I'm not that familiar with methodmapping yet so I'll do that once I'm more experienced with it.

Re: [TF2] Sheens 1.1

May you could add clientprefs support, to keep the client settings after rejoins.

Re: [TF2] Sheens 1.1

translation support? for chat messages

Re: [TF2] Sheens 1.1

Quote:

Originally Posted by Kleiner (Post 2731707)

translation support? for chat messages

The guy has been offline for a few months, not to mention that there's barely anything to translate.

Re: [TF2] Sheens 1.1

Quote:

Originally Posted by KoltaiArmy (Post 2680809)

May you could add clientprefs support, to keep the client settings after rejoins.

Sorry I sadly don't know how to do this for the plugin. If anyone could help me with it, that would be great

Quote:

Originally Posted by Kleiner (Post 2731707)

translation support? for chat messages

Added this one in 1.1.2!

Re: [TF2] Sheens 1.1

Welcome back pear after a while break :)
Good to see ya.