AlliedModders - [Release] SourceBans++ (v1.6.4) [Updated: 2021-10-06]

AlliedModders (https://forums.alliedmods.net/index.php)

- SourceBans / SourceBans++ (https://forums.alliedmods.net/forumdisplay.php?f=152)

- - Release SourceBans++ (v1.6.4) [Updated: 2021-10-06] (https://forums.alliedmods.net/showthread.php?t=263735)

Re: [RELEASE] SourceBans++ (v1.6.1) [Updated: 2017-05-06]

Version 1.6.1 has been released.
Please Backup your database and files before updating!

Changelog:

Fixed an issue while XAJAX initialized
Fixed the 'dash intro text' not displaying custom HTML elements
Fixed 'change password' function
Fixed encoding issues with player names
Fixed aspect ratio of map image
Fixed editing groups/override pages
Fixed display error for 'edit mod' page
Fixed version numbering displaying 0
Improved sizes and file types of images

All changes here
Download

Re: [RELEASE] SourceBans++ (v1.6.1) [Updated: 2017-05-06]

Thank you.

Downloaded, using this on 6 servers.

Re: [RELEASE] SourceBans++ (v1.6.1) [Updated: 2017-05-06]

Quote:

Originally Posted by Groruk (Post 2518762)

[...]

Problem:

Has anyone encountered this? After upgrading to this version, it spams these errors:

Code:

Warning: hash_equals(): Expected known_string to be a string, null given in *******************\includes\CUserManager.php on line 195

Call Stack

#        Time        Memory        Function        Location

1        0.0019        240392        {main}( )        ...\index.php:0

2        0.0048        374512        include_once( '*******************\init.php' )        ...\index.php:28

3        0.0630        4011304        CUserManager->__construct( )        ...\init.php:360

4        0.0634        4012096        CUserManager->CheckLogin( )        ...\CUserManager.php:45

5        0.0719        4016664        hash_equals ( )        ...\CUserManager.php:195



Warning: hash_equals(): Expected known_string to be a string, null given in *******************\includes\CUserManager.php on line 195

Call Stack

#        Time        Memory        Function        Location

1        0.0019        240392        {main}( )        ...\index.php:0

2        0.1005        5467024        include_once( '*******************\includes\sb-callback.php' )        ...\index.php:32

3        0.1087        5843624        CUserManager->CheckLogin( )        ...\sb-callback.php:36

4        0.1171        5844080        hash_equals ( )        ...\CUserManager.php:195



Warning: session_start(): Cannot send session cache limiter - headers already sent (output started at *******************\includes\CUserManager.php:195) in *******************\index.php on line 34

Call Stack

#        Time        Memory        Function        Location

1        0.0019        240392        {main}( )        ...\index.php:0

2        0.1231        5804120        session_start ( )        ...\index.php:34

I know I should make a pull request but I'm still new to GitHub.

Temporary Fix:

Re: [RELEASE] SourceBans++ (v1.6.1) [Updated: 2017-05-06]

Quote:

xajax Error: xajax failed to automatically identify your Request URI.Please set the Request URI explicitly when you instantiate the xajax object.

Still got xajax error :c

Re: [RELEASE] SourceBans++ (v1.6.1) [Updated: 2017-05-06]

Spoiler

Quote:

Originally Posted by LeetDonkey (Post 2517582)

The latest security addition that salts the passwords breaks the donation addon - it is impossible to login on the admin page.
I've tried looking into it, but I have absolutely no idea how to fix it.
I was hoping that one of the sourcebans developers with some insight into the added security mechanisms would be able to fix the donations addon:
https://github.com/nineteeneleven/Donations-Control

I don't know if it's an easy fix, but I figured that there's no harm in asking.

Thanks.

Quote:

Originally Posted by DaRk56 (Post 2517716)

I have the same problem. No idea also can be the part "Salt"

- "Config"

PHP Code:


		
			
///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

define('SB_DB', true); //ONLY SET TRUE IF SOURCEBANS IS ON A DIFFERENT MYSQL SERVER

define('SB_SV_HOST', 'localhost');      //set MySQL host ONLY NEEDED IF SOURCEBANS IS ON A DIFFERENT MYSQL SERVER

define('SB_SV_USER', 'sourcebans');         //MySQL username ONLY NEEDED IF SOURCEBANS IS ON A DIFFERENT MYSQL SERVER

define('SB_SV_PASS', 'xxxXXxx');       //MySQL password ONLY NEEDED IF SOURCEBANS IS ON A DIFFERENT MYSQL SERVER

///////////////////////////////////////////////////////////////////////////////////////////////////////////////////////////

define('SOURCEBANS_DB', 'sourcebans'); // sourcebans database, this is needed.

define('SB_PREFIX', 'sb'); //Sourcebans database prefix. Only change this value if you changed your database prefix when setting up SourceBans.

define('SB_SALT', 'SourceBans'); //dont change this unless you changed your salt in sourcebans (if you dont know what salt is, you didnt change it)

define('SB_ADMINS', 'Leader'); //name of admin group in sourcebans which has access to the donor panel

///////////////////////////////////////////////////////////////////////////////////////////

"Index"

PHP Code:


		
			
<?php

if (isset($_POST['loginSubmit'])) {

    define('NineteenEleven', TRUE);

    require_once '../includes/config.php';

    require_once ABSDIR . 'includes/LoggerClass.php';

    $log = new log;

    $user_name = $_POST['user_name'];

    $password = sha1(sha1(SB_SALT . $_POST['password']));



    try {

        $db = new PDO('mysql:host=' . DB_HOST . ';dbname=' . SOURCEBANS_DB . ';charset=utf8mb4', SB_USER, SB_PASS);

        $db->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);

        $db->setAttribute(PDO::ATTR_EMULATE_PREPARES, false);

    } catch (Exception $e) {

        die('Unable to open connection to MySQL server.');

    }



    try {

        $stmt = $db->prepare("SELECT * FROM " . SB_PREFIX . "_admins WHERE user=? and password=? and srv_group = '" . SB_ADMINS . "';");

        $stmt->execute(array($user_name, $password));

        $row = $stmt->fetchAll(PDO::FETCH_ASSOC);

    } catch (Exception $e) {

        echo "<h3>Something went wrong with our system.</h3>";

        $log->logError($ex->getMessage(), $ex->getFile(), $ex->getLine());

    }

    $count = count($row);

    if ($count === 1) {

        $email = $row[0]['email'];

        session_start();

        $_SESSION['username'] = $user_name;

        $_SESSION['email'] = $email;

        $_SESSION['table'] = false;

        ini_set('default_socket_timeout', 10);

        $json = @json_decode(@file_get_contents('http://1911.expert/dc-version/version.php'));



        if (!empty($json) && VERSION_NEW != $json->version) {



            $_SESSION['message'] = "<div class='alert alert-warning' role='alert'>There is an update available. ";



            if (isset($json->msg)) {

                $_SESSION['message'] .= $json->msg;

            }

            $_SESSION['message'] .= "</div>";

        }

        print("<center><h1 class = 'success'> Welcome back $user_name </h1></center>");

        $log->logAction("$user_name logged in from " . $_SERVER['REMOTE_ADDR']);

        print("<script type = 'text/javascript'> setTimeout('reload()', 1000)

                function reload(){

                window.location = 'show_donations.php'

                }</script>");

        exit();

    } else {

        print "<center><h1 class='error'>Wrong Username or Password</h1></center>";

        $log->logAction("Failed login attempt for user name: $user_name from " . $_SERVER['REMOTE_ADDR']);

    }

}

?>

<div id='login'>

    <table width="300" border="0" align="center" cellpadding="0" cellspacing="1" bgcolor="#CCCCCC">

        <tr>

        <form id="loginSubmit" method="POST" action="index.php">

            <td>

                <table width="100%" border="0" cellpadding="3" cellspacing="1" bgcolor="#FFFFFF">

                    <tr>

                        <td colspan="3"><strong>Admin Login </strong></td>

                    </tr>

                    <tr>

                        <td width="78">Username</td>

                        <td width="6">:</td>

                        <td width="294"><input name="user_name" type="text" id="user_name"></td>

                    </tr>

                    <tr>

                        <td>Password</td>

                        <td>:</td>

                        <td><input name="password" type="password" id="password"></td>

                    </tr>

                    <tr>

                        <td>&nbsp;</td>

                        <td>&nbsp;</td>

                        <td><input type="submit" name="loginSubmit" value="Login" form='loginSubmit' /><input type='button' id='hideLogin' value='Cancel' /></td>



                    </tr>

                </table>

            </td>

        </form>

        </tr>

    </table>

</div>

Change the salt function to this

Code:

$password = crypt($_POST['password'], SB_NEW_SALT);

And then you will have to grab the SB_NEW_SALT from the Sourcebans config manually by yourself since now its Unique for each installation for Security

After you done that you might need to login through Sourcebans and change ur password to rehash your PW in the database.

Re: [RELEASE] SourceBans++ (v1.6.1) [Updated: 2017-05-06]

I am having trouble getting comms bans to actually appear on my bans page.

I've just upgraded from Sourcebans 1.4.11 to Sourcebans++ Version 1.6.1 -git495. I am using Sourcemod v1.8.0.5992 and MetaMod v1.10.7.

I can gag, mute and silence people as before, with it now preventing players from reconnecting to avoid a gag/mute/silence. Regular server bans are also working as normal, and they appear on my servers sourcebans page.

My problem is that none of the comms bans appear. I can see the gags and mutes have been added correctly to the database, as when I access the database itself I can see them.

I have checked the error logs, and it does show this error:

Code:

05/16/2017 - 14:23:35: [sbpp_comms.smx] You must set valid `ServerID` value in sourcebans.cfg!

However I do have this set:

Code:

// This is the ID of this server (Check in the admin panel -> servers to find the ID of this server)

                "ServerID"                "8"

I've also tried setting this back to the default value of "-1" to see what would happen, but the same error keeps appearing and bans still do not appear on the comm bans page.

How do I fix this?

Re: [RELEASE] SourceBans++ (v1.6.1) [Updated: 2017-05-06]

Quote:

Originally Posted by sgt_phsco (Post 2520864)

Code:

05/16/2017 - 14:23:35: [sbpp_comms.smx] You must set valid `ServerID` value in sourcebans.cfg!

However I do have this set:

Code:

// This is the ID of this server (Check in the admin panel -> servers to find the ID of this server)

                "ServerID"                "8"

I've also tried setting this back to the default value of "-1" to see what would happen, but the same error keeps appearing and bans still do not appear on the comm bans page.

How do I fix this?

SOLVED
The problem was my Sourcebans Theme. I was using a custom theme that was made for Sourcebans 1.4.11, not Sourcebans++.

As soon as I changed theme, they were visible.

Re: [RELEASE] SourceBans++ (v1.6.1) [Updated: 2017-05-06]

Out of curiosity, does anyone have an issue with CONSOLE muting players randomly (permanently). I've had this issue for a few days now and I've only really updated SB++ from 1.5.7 to 1.6.1 (CSGO update also happened).

EDIT: I found the solution out myself. It seems that between 1.5.7 to 1.6.1, the handling of BaseComm_SetClientMute() by sourcecomms was changed. I simply updated my plugin to use the relevant SourceComms natives if the sourcecomms library was loaded and the issue wen't away. The plugin was a priority speaker (which mutes/unmutes T's if they try to speak over a CT player).

Re: [RELEASE] SourceBans++ (v1.6.1) [Updated: 2017-05-06]

Quote:

Originally Posted by Byte (Post 2520894)

:O spooky

Does anyone else have in-game or web rcon access? Never hurts to double check permissions, could be someone trying to be funny, or a compromised account.

Re: [RELEASE] SourceBans++ (v1.6.1) [Updated: 2017-05-06]

Quote:

Originally Posted by Byte (Post 2520894)

I get this when an admin steamid isnt registered in sourcebans but is admin via configs.