AlliedModders - The code is correct?

AlliedModders (https://forums.alliedmods.net/index.php)

- Scripting Help (https://forums.alliedmods.net/forumdisplay.php?f=11)

- - The code is correct? (https://forums.alliedmods.net/showthread.php?t=175174)

The code is correct?

I'm starting with the programming of plugins and wanted to know if this is OK:

Code:

public donate(id,ammount,user)

{

//User ammo

new user1_ammo = zp_get_user_ammo_packs(id)

new user2_ammo = zp_get_user_ammo_packs(user)



if(user1_ammo >= ammount){

new user1_restar = user1_ammo-ammount

new user2_sumar = user2_ammo+ammount



zp_set_user_ammo_packs(id,user1_restar)

zp_set_user_ammo_packs(user,user2_sumar)



client_print(id, print_chat, "[ZP] "+ammont+" ammo give to "+user+"")

client_print(user, print_chat, "[ZP] Have you received "+ammont+" from "+id+"")

}else{

client_print(id, print_chat, "[ZP] You don't have enough Ammo Pack")

}



}

Re: The code is correct?

PHP Code:


		
			
client_print(id, print_chat, "[ZP] "+ammont+" ammo give to "+user+"")

You can't format your string as in C++ / Java. Also, user is a id, not the name of the user.

http://www.amxmodx.org/funcwiki.php?go=func&id=49
http://www.amxmodx.org/funcwiki.php?go=func&id=165

user1_restar and user2_sumar are useless.

PHP Code:


		
			
new user1_restar = user1_ammo-ammount

new user2_sumar = user2_ammo+ammount



zp_set_user_ammo_packs(id,user1_restar)

zp_set_user_ammo_packs(user,user2_sumar)

PHP Code:


		
			
zp_set_user_ammo_packs(id,user1_ammo-ammount)

zp_set_user_ammo_packs(user,user2_ammo+ammount)