AlliedModders - [CS1.6|CZ] Knife Realism

AlliedModders (https://forums.alliedmods.net/index.php)

- Approved Plugins (https://forums.alliedmods.net/forumdisplay.php?f=8)

- - [CS1.6|CZ] Knife Realism (https://forums.alliedmods.net/showthread.php?t=236720)

Re: [CS1.6|CZ] Knife Realism v0.0.5 ( 14/10/2014 )

Quote:

Originally Posted by Arkshine (Post 2210721)

Just to be sure, you did some test right? :P

I tested the blood decals and they were working as expected. I've only got cs1.6 to test on sadly I can't test on other games.

The melee check I took on faith from your advice should work as you described. I'll do a full test after work and update if any problems.

Re: [CS1.6|CZ] Knife Realism v0.0.5 ( 14/10/2014 )

Let's dig more :mrgreen:

This OFFSET_WEAPONOWNER, For consistency reason, please use the original CBasePlayer member name which is m_pPlayer.
There is really no point to cache value in plugin_cfg, plus such value can be changed in the middle of game, and that's not something which is called often.
I would cache get_user_team( index ) and get_user_team( iAttacker ) before.
In CBasePlayer_TakeDamage_P, you should call get_kr_flags where it's actually used, inside second check.
new szFlags[ 24 ]; well you can reduce buffer, since you can have only 7 flags.
I think I would use MSG_PVS for TE_BLOODSTREAM because that's something rather fast to happen, so no point to send message to others players who doesn't see this player. Less flood, the better.
Supporting plugin pause/unpause would be welcomed.

Re: [CS1.6|CZ] Knife Realism v0.0.5 ( 14/10/2014 )

Quote:

Originally Posted by Arkshine (Post 2210765)

Let's dig more :mrgreen:

This OFFSET_WEAPONOWNER, For consistency reason, please use the original CBasePlayer member name which is m_pPlayer.
There is really no point to cache value in plugin_cfg, plus such value can be changed in the middle of game, and that's not something which is called often.
I would cache get_user_team( index ) and get_user_team( iAttacker ) before.
In CBasePlayer_TakeDamage_P, you should call get_kr_flags where it's actually used, inside second check.
new szFlags[ 24 ]; well you can reduce buffer, since you can have only 7 flags.
I think I would use MSG_PVS for TE_BLOODSTREAM because that's something rather fast to happen, so no point to send message to others players who doesn't see this player. Less flood, the better.
Supporting plugin pause/unpause would be welcomed.

Thanks for suggestions.

Will implement them when next on desktop.