AlliedModders - [Solved] Ban players if disconnect

AlliedModders (https://forums.alliedmods.net/index.php)

- Suggestions / Requests (https://forums.alliedmods.net/forumdisplay.php?f=12)

- - Solved Ban players if disconnect (https://forums.alliedmods.net/showthread.php?t=265792)

Re: Ban if no return in 5 minutes.

WTF... Ha ha... Testing more... Something is wrong for me then...
But cant see what...

Did you remove FLAG A for you?

Re: Ban if no return in 5 minutes.

Since i upgradeded to amxx 1.8.3 map changes are so slow. Delete custom.hpk worked.
Mapcycle doesnt even get maps from maps.ini not even mapcycle.txt
Dont even know where the hlds gets the mapcycle from only but it changes map to some wierd ones i never seen before.
Can this cause the problem? I think it is it.

Can u in a simple way convert this to amxx 1.8.2 plugin?
This might help i dont know hope so cause i think 1.8.3 isnt the way for me.

If not i will try to fix the problem im having, so wierd never liked beta 1.8.3

But yes plugin was working perfect and also if you have tested it yourself then i think its done.

Thanks so much for this plugin it was really a needy one i think some will use this plugin cause i know maaaannnyyy was searching for it in other forums.

Re: Ban if no return in 5 minutes.

No my man totally fresh install of server.
No extra plugins.
Everything is fresh and not touched.

Same problem!

Amxx 1.8.3 latest beta

PS! This plugin or 1.8.3 or combination of other plugins has fu**ed up the server good times.
Cant install amxx corectrly without server crashing @ random not even older version.

This happened after this plugin or 1.8.3 upgrade.

Do 1.8.2 version why 1.8.3 its till not stable... Not for me as you see...

Teamviewer someday?

Re: Ban if no return in 5 minutes.

It works fine for me on 1.8.2 and 1.8.3, what is the exact issue that you are having? One thing I missed is a bot/hltv check, which I've added above.

Re: Ban if no return in 5 minutes.

1.8.2

Yes i could compile it with 1.8.2 only after you updated the code.
Yes the plugins was loaded the first time.

The plugin crashes the server after map change.

Now if the plugin is on server cant start.
If plugin is off then it can start.

https://youtu.be/7U9aZNl-BdM

1.8.3

Fresh install amxx beta latest 1.8.3
Plugin running but not banning.

https://youtu.be/xZusBoU4N5I

x.x.x

Checked old BINR.vault
Output - TLVn 9]V <Zvé1448949909
When plugin was working (yesterday before the code update) but map changes didnt i got a output like this TLVn 9]V <Zvé STEAMIDMYSTEAMID1448949909
So its like banning but no steam id...

Re: Ban if no return in 5 minutes.

1.8.3 should be backwards compatible and it works completely fine for me under both 1.8.2 and 1.8.3.

Check your admin flags to see if you have immunity flag because it ignores those with immunity.

About that nvault data. You cannot open an nvault file in notepad, as I said above you will need to use nvault editor that is linked in my sig. Maybe your vault is corrupt so try deleting it and restart your server.

Re: Ban if no return in 5 minutes.

Mkaj testing...

Its a problem still not baning and that vault file is wierd.
Everything in the video.

https://youtu.be/CMY3W8uKtes

Re: Ban if no return in 5 minutes.

You can see data but it's in binary format which you can't view or modify in a text editor. The data gets cutoff at the first null character so you will probably only ever see the first record in the file. If you save the file, you will break it.

Re: Ban if no return in 5 minutes.

Check updated previous post with video...

Hope this is causing the problem i hope!

Update! No this wasnt it marked all checked.

http://i.imgur.com/E3t1HL3.png

Re: Ban if no return in 5 minutes.

Code is fixed. When I added code to ignore bots and hltv, I made a slight mistake and made it ignore real players and only impact bots and hltv.

1. I told you, you cannot view nvault files with notepad! The data will be cut-off at the first null character. Download the nvault editor to see data. This is a binary file, not text file.
2. Data does not write the vault in real-time like you think. It is journalized and only gets written to the .vault file when the map changes or server shuts down. The data is still accessible to be read/written by the nvault natives, but you cannot open the file directly to see new data until a map change after the data was written.

Re: Ban if no return in 5 minutes.

Yes! It works!

But one problem!
After 1st ban! I reconnect and then i just can reconnect 1 time - 2nd time ban!
If not banned i can reconnect as much as i want.

Tested more its wierd after some time it cant change map same mistake.

<<<<<<<<<<<<<<<3

PS! BINR.vault opened with notepad.

Quote:

TLVn ‰j^V
1449027993¯g^V
STEAM_0:0:407244471449027263

Re: Ban if no return in 5 minutes.

Quote:

Originally Posted by 4ever16 (Post 2368054)

I will need to test it more, but it should be working correctly.

I never said you can't open the file, of course you 'can' open it. But what you see is only the key for the first entry in the vault. If you had 1000 records in the vault, you would only see the key of the first entry and that's it. And if you save the file using a text editor, the file will become corrupt.

"TLVn ‰j^V
1449027993¯g^V
STEAM_0:0:407244471449027263[NULL IS HERE SO YOU SEE NOTHING AFTER IT]

Re: Ban if no return in 5 minutes.

Also like if someone gets banned the server will not be able to change map if it changes it will crash the server.
And BIN.vault needs to be delete to make server start again.

Video.
https://youtu.be/0rQEPdHyyl0

Re: Ban if no return in 5 minutes.

My guess on that ban issue is you are disconnecting before your steam-id is retrieved. Try the updated code. You are wrong about the change map thing. There is no way this plugin would cause a crash, unless you are corrupting the nvault file.

Re: Ban if no return in 5 minutes.

What do u mean by corrupting the file? I do not touch it.
Well im trying again.

Re: Ban if no return in 5 minutes.

I don't know anything else that would cause a crash, especially inconsistently.

Re: Ban if no return in 5 minutes.

Same thing...
When not banned... Reconnect works 1000 times.
After the ban 2-3 reconnects = ban.

Mapchange also same doesnt want to change map / crashes the server after someone gets banned and a mapchange is done.

Re: Ban if no return in 5 minutes.

Test 1.

Connected.
Disconnected 1 min.
Ban 1 min.
Connected after 1 min.

1 Reconnect = ok.
2 Reconnect = 2 minutes ok. 3 round.
3 Reconnect = 2 minutes ok. 3 round.
4 Reconnect = 30 seconds ok.
5 Reconnect = 10 seconds BAN.

Test 2.

Connected.
Disconnected 1 min.
Ban 1 min.
Connected after 1 min.

1 Reconnect = ok.
2 Reconnect = 10-20 seconds BAN.

Test 3

Connected.
Disconnected 1 min.
Ban 1 min.
Connected after 1 min.

1 Reconnect = ok.
2 Reconnect = 62 seconds = ok.
3 Reconnect = 62 seconds = ok.
4 Reconnect = 70 Seconds = BAN.

And yeah map doesnt want to change after some reconects or after some reconnects after ban.

Re: Ban if no return in 5 minutes.

I can reproduce the issue, I am investigating how to fix it. I am leaning towards a re-write using SQLite. I think the issue might be related to a bug in the celltravtrie include but I need to test more to confirm.

Let me know how it should work in this scenario.

binr_reconnectmin = 5
binr_banmins = 60

Player disconnects and does not reconnect within 5 minutes.
He attempts to reconnect 120 minutes later. Does he then get issued a ban, or does the ban get issued immediately after the 5 minutes passes from step 1. In this scenario he will not even know he had a ban since he is reconnecting after the binr_banmins duration.

Re: Ban if no return in 5 minutes.

binr_reconnectmin = 5
binr_banmins = 60

Reconnected after 122 minutes. No ban why would it ban ;D ?

Disconnected 5 minutes again.
Return 7 minutes no ban.
Reconnect no ban.
Reconnect second time 20 seconds ban.

- - - - - -

Isnt it easier to use amxbans cause it already has a timestamp bans time locked bans.

Re: Ban if no return in 5 minutes.

Because the player is essentially getting no punishment for not reconnecting when he should have... that's just my thought.

It's easier to just handle the bans through the plugin itself.

Re: Ban if no return in 5 minutes.

So whats the solution?
Crashes the server and bans when it shouldnt need to ban / bans after reconnects.

Its unusable.

Re: Ban if no return in 5 minutes.

As I said, I'm looking into a solution

https://forums.alliedmods.net/showpo...4&postcount=99

Re: Ban if no return in 5 minutes.

SQLite? I personaly cant use any SQL / MYSQL website stuff.

Re: Ban if no return in 5 minutes.

SQL will be better ? Bugsy?

Re: Ban if no return in 5 minutes.

SQLite is not web-based, it can be used as a local database on the server.

SQL is useful because you can query for data instead of iterating through an array of data to look for something. An example is when you want to ban someone who has not returned after X seconds.

Since it is already coded in a way that I think should work, I may use a traditional array for what I was using travtrie for.

Re: Ban if no return in 5 minutes.

Quote:

Originally Posted by Bugsy (Post 2368569)

SQLite is not web-based, it can be used as a local database on the server.

Ok sounds good.

Quote:

SQL is useful because you can query for data instead of iterating through an array of data to look for something. An example is when you want to ban someone who has not returned after X seconds.

SQL i dont know about it but it shouldnt be done manually cause admins arnt allways online and its to much work doing it manually everytime.

Automatic :bee:

Re: Ban if no return in 5 minutes.

It's obviously going to be automatic, that's the basis of this plugin; to do bans for you.

I coded a version in SQL but then thought of a much simpler solution for this. I'll post shortly.

Re: Ban if no return in 5 minutes.

Quote:

Originally Posted by 4ever16 (Post 2368683)

SQL i dont know about it but it shouldnt be done manually cause admins arnt allways online and its to much work doing it manually everytime.

Automatic :bee:

One time set-up will be needed after that u dont need to do any thing :)

Re: Ban if no return in 5 minutes.

Waiting... :D Hope that this will be it.

Re: Ban if no return in 5 minutes.

Here it is, much simpler than the first pass and will be easier to debug.

This is currently configured for testing so the ban time is in seconds instead of minutes which allows for fast testing. It can currently handle up to 30 players who have disconnected and are being monitored to issue a ban if they've disconnected too long. It's better to keep this number on the smaller side, but it can be increased if needed.

If you want to test it with actual minutes, change const Minute_Seconds = 1 to const Minute_Seconds = 60.

PHP Code:


		
			

#include <amxmodx>
#include <engine>
#include <nvault_util>

new const Version[] = "1.2";

#define MAX_PLAYERS 32

const BanQueueSize = 30;
const Float:EntityInterval = 1.0;
const MinuteSeconds = 60;

enum PlayerData
{
    pdAuthID[ 34 ],
    pdDisconnectTime,
}

new g_pdData[ MAX_PLAYERS + 1 ][ PlayerData ] , g_BanQueue[ BanQueueSize ][ PlayerData ];
new g_IgnorePlayers , g_HasAuthorized , g_Entity , g_Vault;
new g_pBanLeavers , g_pReconnectMinutes , g_pBanMinutes , g_pImmunityFlags;

public plugin_init() 
{
    register_plugin( "Ban If No Return" , Version , "bugsy" );
    
    g_pBanLeavers = register_cvar( "binr_enabled" , "1" );
    g_pReconnectMinutes = register_cvar( "binr_reconnectmin" , "5" );
    g_pBanMinutes = register_cvar( "binr_banmins" , "60" );
    g_pImmunityFlags = register_cvar( "binr_immunityflags" , "a" );
    
    LoadQueue();
    
    g_Vault = nvault_open( "ban_if_no_return" );
    nvault_prune( g_Vault , 0 , get_systime() );
    
    g_Entity = create_entity( "info_target" );
    entity_set_string( g_Entity , EV_SZ_classname , "binr_entity" );
    register_think( "binr_entity" , "EntityThink" );
    entity_set_float( g_Entity , EV_FL_nextthink , ( get_gametime() + EntityInterval ) );
}

public plugin_end()
{
    SaveQueue();
    
    call_think( g_Entity );
    nvault_close( g_Vault );
}

public client_authorized( id ) 
{
    new iTimeStamp , szKickMessage[ 96 ] , szFlags[ 26 ];
    
    get_pcvar_string( g_pImmunityFlags , szFlags , charsmax( szFlags ) );
    g_IgnorePlayers |= ( is_user_bot( id ) || is_user_hltv( id )  || ( get_user_flags( id ) & read_flags( szFlags ) ) ? 1 : 0 ) << ( id & 31 ) ;
    
    if ( !( g_IgnorePlayers & ( 1 << ( id & 31 ) ) ) )
    {
        get_user_authid( id , g_pdData[ id ][ pdAuthID ] , charsmax( g_pdData[][ pdAuthID ] ) );
        
        if ( nvault_lookup( g_Vault , g_pdData[ id ][ pdAuthID ] , "" , 0 , iTimeStamp ) )
        {
            if ( iTimeStamp > get_systime() )
            {
                formatex( szKickMessage , charsmax( szKickMessage ) , "^nYou have been banned for %d minutes for not re-joining within %d minutes." , get_pcvar_num( g_pBanMinutes ) , get_pcvar_num( g_pReconnectMinutes ) );   
                message_begin( MSG_ONE , 2 , {0,0,0} , id );     
                write_string( szKickMessage );     
                message_end(); 
            }
            else
            {
                nvault_remove( g_Vault , g_pdData[ id ][ pdAuthID ] );
            }
        }
        else
        {
            RemoveFromBanQueue( id );
        }
    }
    
    g_HasAuthorized |= ( 1 << ( id & 31 ) );
}

public client_disconnect( id ) 
{
    if ( !( g_IgnorePlayers & ( 1 << ( id & 31 ) ) ) && ( g_HasAuthorized & ( 1 << ( id & 31 ) ) ) && get_pcvar_num( g_pBanLeavers ) )
    {
        if ( !AddToBanQueue( id ) )
            set_fail_state( "Ban If No Return: Need to increase queue size." );
    }
    
    g_IgnorePlayers &= ~( 1 << ( id & 31 ) );
    g_HasAuthorized &= ~( 1 << ( id & 31 ) );
}

public EntityThink( iEntity )
{
    if( iEntity == g_Entity ) 
    {
        SetBansInQueue();                        
        entity_set_float( g_Entity , EV_FL_nextthink , ( get_gametime() + EntityInterval ) );
    }
}

bool:AddToBanQueue( id , DisconnectTime=0 )
{
    new bool:bSuccess;
    
    for (new iFindSlot = 0 ; iFindSlot < BanQueueSize ; iFindSlot++ )
    {
        if ( g_BanQueue[ iFindSlot ][ pdAuthID ][ 0 ] == EOS )
        {
            copy( g_BanQueue[ iFindSlot ][ pdAuthID ] , charsmax( g_BanQueue[][ pdAuthID ] ) , g_pdData[ id ][ pdAuthID ] );
            g_BanQueue[ iFindSlot ][ pdDisconnectTime ] = DisconnectTime ? DisconnectTime : get_systime();
            bSuccess = true;
            break;
        }
    }
    
    return bSuccess;
}

RemoveFromBanQueue( id )
{
    for ( new iFindSlot = 0 ; iFindSlot < BanQueueSize ; iFindSlot++ )
    {
        if ( equal( g_BanQueue[ iFindSlot ][ pdAuthID ] , g_pdData[ id ][ pdAuthID ] ) )
        {
            g_BanQueue[ iFindSlot ][ pdAuthID ][ 0 ] = EOS;
            g_BanQueue[ iFindSlot ][ pdDisconnectTime ] = 0;
            break;
        }
    }
}

SetBansInQueue()
{
    new iBanTime;
    
    for ( new iFindSlot = 0 ; iFindSlot < BanQueueSize ; iFindSlot++ )
    {
        if ( g_BanQueue[ iFindSlot ][ pdAuthID ][ 0 ] )
        {
            if ( ( get_systime() - g_BanQueue[ iFindSlot ][ pdDisconnectTime ] ) >= ( get_pcvar_num( g_pReconnectMinutes ) * MinuteSeconds ) )
            {
                nvault_set( g_Vault , g_BanQueue[ iFindSlot ][ pdAuthID ] , "1" );
                nvault_touch( g_Vault , g_BanQueue[ iFindSlot ][ pdAuthID ] , ( iBanTime = get_pcvar_num( g_pBanMinutes ) ) == 0 ? 0 : get_systime() +  ( iBanTime * MinuteSeconds ) );

                g_BanQueue[ iFindSlot ][ pdAuthID ][ 0 ] = EOS;
                g_BanQueue[ iFindSlot ][ pdDisconnectTime ] = 0;
            }
        }
    }
}

LoadQueue()
{
    new iVault , pData[ _:PlayerData ] , iPos , iCount , iItems , iTimeStamp , szKey[ 9 ];
    
    if ( ( iVault = nvault_util_open( "ban_if_no_return" ) ) )
    {
        iCount = nvault_util_count( iVault );
        
        for ( new iEntry = 0 ; iEntry < iCount ; iEntry++ )
        {
            iPos = nvault_util_read_array( iVault , iPos , szKey , charsmax( szKey ) , pData , sizeof( pData ) , iItems , iTimeStamp );
            
            if ( equal( szKey , "BanQueue" ) )
            {
                copy( g_pdData[ 0 ][ pdAuthID ] , sizeof( g_pdData[][ pdAuthID ] ) , pData[ _:pdAuthID ] );
                g_pdData[ 0 ][ pdDisconnectTime ] = pData[ _:pdDisconnectTime ];
                AddToBanQueue( 0 , g_pdData[ 0 ][ pdDisconnectTime ] );
            }
        }
    }
}

SaveQueue()
{
    new szKey[ 12 ] , iSlotIndex , pData[ _:PlayerData ];
    
    copy( szKey , charsmax( szKey ) , "BanQueue" );
    
    for ( new iSlot = 0 ; iSlot < BanQueueSize ; iSlot++ )
    {
        if ( g_BanQueue[ iSlot ][ pdDisconnectTime ] )
        {
            copy( pData[ _:pdAuthID ] , charsmax( pData[ pdAuthID ] ) , g_BanQueue[ iSlot ][ pdAuthID ] );
            pData[ _:pdDisconnectTime ] = g_BanQueue[ iSlot ][ pdDisconnectTime ];
            
            num_to_str( iSlotIndex++ , szKey[ 8 ] , charsmax( szKey ) - 8 );
            nvault_set_array( g_Vault , szKey , pData , sizeof( pData ) );
            nvault_touch( g_Vault , szKey , 1 );
        }
    }
}

Re: Ban if no return in 5 minutes.

Hey Bugsy,

Tested it.

1st connect

PHP Code:


		
			

L 12/05/2015 - 13:07:06: [admin.amxx] Login: "Gullu Bhai<17><STEAM_0:0:><>" became an admin (account "STEAM_0:0:") (access "bcdefghijklmnopqrstuy") (address "192.168.0.3")
CONNECTED: REMOVED STEAM_0:0: FROM QUEUE

disconnect

PHP Code:


		
			

DISCONNECTED: ADDED STEAM_0:0: TO QUEUE
Dropped Gullu Bhai from server
Reason:  Client sent 'drop'
ENTITY: SET BAN ON STEAM_0:0: AND REMOVED FROM QUEUE

after 10 min i connected again

2nd connect

PHP Code:


		
			

192.168.0.3:27005:reconnect
L 12/05/2015 - 13:39:43: [admin.amxx] Login: "Gullu Bhai<18><STEAM_0:0:><>" became an admin (account "STEAM_0:0:") (access "bcdefghijklmnopqrstuy") (address "192.168.0.3")
CONNECTED: BAN EXPIRED, DELETED STEAM_0:0: BAN

Actually its must ban me instead it removed my steamid from list ... plugin works perfectly in adding and removing steam id from queue but it isnt banning me ...

Re: Ban if no return in 5 minutes.

@tousif i dont know what u talking about it works good for me. You maybe tested it on listen server?!

Yes my man. This works good.

Last question.

How do i make so it doesnt ban leavers on warmup aka warmup.cfg but doesnt allow the leavers aka banned players from live.cfg to not join @ warmup.cfg?

Just have binr_enabled 1 @ live.cfg and binr_enabled 0 @ warmup.cfg?

Or what cvar or function check so banned players cant join?

Tested with few cvars.

live.cfg
binr_enabled 1
binr_reconnectmin 1
binr_banmins 4

warmup.cfg
binr_enabled 0
binr_reconnectmin 1
binr_banmins 4

warmup.cfg
binr_enabled 1
binr_reconnectmin 999999
binr_banmins 0

warmup.cfg
binr_enabled 1
binr_reconnectmin 1
binr_banmins 1

warmup.cfg
binr_enabled 1
binr_reconnectmin 0
binr_banmins 4

What i learned is that if u reconnect after rec minutes when live yes it bans you for exact time needed.
But if u disconnect on live and reconnect when warmup.cfg then you dont get ban time from live.cfg u get ban time from warmup.cfg

You understand what i need / want?

Re: Ban if no return in 5 minutes.

Quote:

Originally Posted by 4ever16 (Post 2368916)

@tousif i dont know what u talking about it works good for me. You maybe tested it on listen server?!

Tested it on hlds :3

Re: Ban if no return in 5 minutes.

@tousif : It is banning you, but you are re-connecting after the ban expires. As I said in my post, everything is now in seconds, so the ban will expire quickly.

ENTITY: SET BAN ON STEAM_0:0: AND REMOVED FROM QUEUE
CONNECTED: BAN EXPIRED, DELETED STEAM_0:0: BAN

@4ever16 : This is the nature of cvars. They use the assigned value at that point in time, it doesn't remember 'Oh he was connected when the cvar was this, it now changed to this, but I will still use the old value'.

What is the purpose of the warmup configuration and live configuration? I would assume you would want the functionality disabled on warmup.

Re: Ban if no return in 5 minutes.

Warmup.cfg = when match isnt live when server doesnt have 10 players.
Live.cfg = when match is live when 10 players are online.

Server must have these 2 configs. Otherwise people will get banned just for joining and leaving even though there isnt a match going on. The pourpose of my request was to ban people who only leave live match, noobs who destroy the match making 5vs5 to 5vs4. I want them to learn that if u joining the server or playing a match @ the server play until the end or comeback after the ban (looong ban) so they can think twice before joining live match or the server to play a match.

Yes @ warmup.cfg it should only ban players who left and didnt return @ live.cfg was loaded.
But @ warmup.cfg players can leave without getting any ban.
Simplier sed u get banned @ live.cfg and u cannot return @ warmup.cfg. You must wait until your ban is over to return.

The problem right now is that when match is live and you leave and dont return and try to connect like 3 minutes after - you get banned for 60 minutes.
But if i do the same thing but dont reconnect when live - instead i reconnect after the match when warmup.cfg is loaded which has other cvars then i can connect without ban.
U get me?

What i think i need is that this plugin doesnt ban on warmup but bans only leavers from live.cfg @ warmup.cfg
Its like a small paradox with this plugin right now ;D Not the plugin just that i have 2 .cfgs making this an issue.

Re: Ban if no return in 5 minutes.

Try the above code. I was basically disabling all checking, even bans, if the binr_enabled cvar was 0. Now it will do the OnConnect checks regardless of that value.

For your 2 configs, I would leave the binr_reconnectmin and binr_banmins values constant in both, only toggle the binr_enabled cvar. This is going to need more work I'm sure, but I need to understand better what you are trying to do with these 2 settings.

Can you break it down like this

Disconnect @ warmup
Reconnect @ live
Ban should be X

Disconnect @ live
Reconnect @ warmup
Ban should be X

Disconnect @ live
Reconnect @ live
Ban should be X

Disconnect @ warmup
Reconnect @ warmup
Ban should be X

Re: Ban if no return in 5 minutes.

Mm trying your new code. Didnt work didnt get banned @ warmup.cfg. when i left live.cfg

I hope i understand what you are trying to say.

Disconnect @ warmup
Reconnect @ live
Ban should be 0

Disconnect @ live
Reconnect @ warmup
Ban should be 70 hours in minutes

Disconnect @ live
Reconnect @ live
Ban should be 70 hours in minutes

Disconnect @ warmup
Reconnect @ warmup
Ban should be 0

Re: Ban if no return in 5 minutes.

Should the queue get restored on map change.

So if someone disconnects 20 seconds before the map changes, should they still be required to rejoin within X seconds to avoid a ban on the new map? Currently, the queue is not saved\restored between map changs.

Re: Ban if no return in 5 minutes.

Quote:

Originally Posted by Bugsy (Post 2369011)

So if someone disconnects 20 seconds before the map changes, should they still be required to rejoin within X seconds to avoid a ban on the new map?

Yes.
But after the map change when warmup.cfg is loaded you can disconnect without ban as sed.
I think i can turn off a cvar or plugin if needed exactly when the match is over i just need to see the working plugin or cvars.