AlliedModders - SM RCon (updated 2012-09-09)

AlliedModders (https://forums.alliedmods.net/index.php)

- Extensions (https://forums.alliedmods.net/forumdisplay.php?f=134)

- - SM RCon (updated 2012-09-09) (https://forums.alliedmods.net/showthread.php?t=168403)

Re: SM RCon (updated 2011-09-29)

I'm using this for verbose rcon logging, but I'm starting to see some potential problems.

1. SMRCon_OnAuth is triggered even if an IP is banned. Meaning they could continue spamming auth attempts and flood logs.

2. Some plugins rely on the rcon output to get information from servers (HLSW, maybe SourceBans), and logging during SMRCon_OnCommand sends that information back over the rcon which would interfere.

Is logging during these forwards a bad idea to begin with?

Re: SM RCon (updated 2011-09-29)

Quote:

Originally Posted by GoD-Tony (Post 1577678)

1. SMRCon_OnAuth is triggered even if an IP is banned. Meaning they could continue spamming auth attempts and flood logs.

The allow bool passed in should already be false if the connection would be denied without your intervention. Is that not the case?

Quote:

Originally Posted by GoD-Tony (Post 1577678)

2. Some plugins rely on the rcon output to get information from servers (HLSW, maybe SourceBans), and logging during SMRCon_OnCommand sends that information back over the rcon which would interfere.

That shouldn't be any different than logging during commands without this ext if they were executed via rcon. All console output during the command is forwarded. You could try temporarily turning off sv_logecho.

Re: SM RCon (updated 2011-09-29)

As a followup to my last post; I worked around issue #2 by delaying the logging using a timer, and issue #1 by not monitoring failed auth attempts.

Re: SM RCon (updated 2011-09-29)

Can someone give advice, how I could log actions without showing to rcon user/spammer ?
https://forums.alliedmods.net/attach...1&d=1323370478

Happen:
SMRCon_OnAuth()
SMRCon_OnCommand()
(And maybe rest Action: functions)...

PHP Code:


		
			
#include <smrcon>
new String:path[256];

public OnPluginStart()
{
    BuildPath(Path_SM, path, sizeof(path), "logs/smrcon.txt");
    //RegConsoleCmd("sm_testi", testi);
}

public Action:testi(client, args)
{
    LogToFileEx(path, "SMRCon_IsCmdFromRCon(%s)", SMRCon_IsCmdFromRCon() ? "true":"false");
    return Plugin_Handled;
}

public Action:SMRCon_OnAuth(rconId, const String:address[], const String:password[], &bool:allow)
{
    //LogToFile(path, "rconId %i, address %s, password %s %s", rconId, address, password, allow ? "allow":"deny");
    LogToFileEx(path, "Liirum laarum");
}

public Action:SMRCon_OnCommand(rconId, const String:address[], const String:command[], &bool:allow)
{
    //LogToFile(path, "rconId %i, address %s, command %s %s", rconId, address, command, allow ? "allow":"deny");
    LogToFileEx(path, "Uliuliuli huhuhu");
}

public SMRCon_OnDisconnect(rconId)
{
    //LogToFile(path, "SMRCon_OnDisconnect(%i)", rconId);
    LogToFileEx(path, "Poispois");
}

public Action:SMRCon_OnLog(rconId, const String:address[], const String:logdata[])
{
    //LogToFile(path, "rconId %i, address %s, logdata %s", rconId, address, logdata);
    LogToFileEx(path, "Tuu tuu tuu");
}

Should I delay this logging with datatimer ??

Re: SM RCon (updated 2011-09-29)

Quote:

Originally Posted by Bacardi (Post 1609862)

Should I delay this logging with datatimer ??

Yes, this is the only way to prevent it from being sent back through rcon.

Re: SM RCon (updated 2011-09-29)

Quote:

Originally Posted by GoD-Tony (Post 1609920)

Yes, this is the only way to prevent it from being sent back through rcon.

Done and works... need check will this leave open handles.

stupid plugin

PHP Code:


		
			
#include <smrcon>
new String:path[256];

public OnPluginStart()
{
    BuildPath(Path_SM, path, sizeof(path), "logs/smrcon.txt");
    //RegConsoleCmd("sm_testi", testi);
}

public Action:testi(client, args)
{
    LogToFileEx(path, "SMRCon_IsCmdFromRCon(%s)", SMRCon_IsCmdFromRCon() ? "true":"false");
    return Plugin_Handled;
}

public Action:SMRCon_OnAuth(rconId, const String:address[], const String:password[], &bool:allow)
{
    //LogToFile(path, "rconId %i, address %s, password %s %s", rconId, address, password, allow ? "allow":"deny");
    new Handle:temp = INVALID_HANDLE;
    CreateDataTimer(1.0, timmer_OnAuth, temp);
    WritePackCell(temp, rconId);
    WritePackString(temp, address);
    WritePackString(temp, password);
    WritePackCell(temp, allow);
}

public Action:timmer_OnAuth(Handle:timer, Handle:temp)
{
    ResetPack(temp);
    new rconId = ReadPackCell(temp);

    new String:address[512];
    ReadPackString(temp, address, sizeof(address));

    new String:password[512];
    ReadPackString(temp, password, sizeof(password));

    new bool:allow = ReadPackCell(temp) == 1 ? true:false;
    LogToFile(path, "rconId %i, address %s, password %s %s", rconId, address, password, allow ? "allow":"deny");
}

public Action:SMRCon_OnCommand(rconId, const String:address[], const String:command[], &bool:allow)
{
    //LogToFile(path, "rconId %i, address %s, command %s %s", rconId, address, command, allow ? "allow":"deny");
    new Handle:temp = INVALID_HANDLE;
    CreateDataTimer(1.0, timmer_OnCommand, temp);
    WritePackCell(temp, rconId);
    WritePackString(temp, address);
    WritePackString(temp, command);
    WritePackCell(temp, allow);
}

public Action:timmer_OnCommand(Handle:timer, Handle:temp)
{
    ResetPack(temp);
    new rconId = ReadPackCell(temp);

    new String:address[512];
    ReadPackString(temp, address, sizeof(address));

    new String:command[512];
    ReadPackString(temp, command, sizeof(command));

    new bool:allow = ReadPackCell(temp) == 1 ? true:false;
    LogToFile(path, "rconId %i, address %s, command %s %s", rconId, address, command, allow ? "allow":"deny");
}

public SMRCon_OnDisconnect(rconId)
{
    LogToFile(path, "SMRCon_OnDisconnect(%i)", rconId);
}

public Action:SMRCon_OnLog(rconId, const String:address[], const String:logdata[])
{
    //LogToFile(path, "rconId %i, address %s, logdata %s", rconId, address, logdata);
    new Handle:temp = INVALID_HANDLE;
    CreateDataTimer(1.0, timmer_OnLog, temp);
    WritePackCell(temp, rconId);
    WritePackString(temp, address);
    WritePackString(temp, logdata);
}

public Action:timmer_OnLog(Handle:timer, Handle:temp)
{
    ResetPack(temp);
    new rconId = ReadPackCell(temp);

    new String:address[512];
    ReadPackString(temp, address, sizeof(address));

    new String:logdata[512];
    ReadPackString(temp, logdata, sizeof(logdata));

    LogToFile(path, "rconId %i, address %s, logdata %s", rconId, address, logdata);
}

output txt

Re: SM RCon (updated 2011-09-29)

What's different in sm basic rcon system?

Re: SM RCon (updated 2012-03-10)

Version 1.2.0 has been posted.

This will now, by default, block rcon from any banned addresses, even if they use the correct password. The engine apparently lets banned users use rcon :/

This also resolves SMRCon_OnAuth being fired when banned addresses attempt to auth.

Re: SM RCon (updated 2012-03-10)

Quote:

Originally Posted by psychonic (Post 1666230)

Version 1.2.0 has been posted.

This will now, by default, block rcon from any banned addresses, even if they use the correct password. The engine apparently lets banned users use rcon :/

This also resolves SMRCon_OnAuth being fired when banned addresses attempt to auth.

Really :)
Yes!

*edit
God dam ! I go my self banned :D, can't remove my IP XD.
Need do a trick...

*edit
If you have same IP as Server, you can still log in rcon with right password, even you have get banned by rcon hacking (extension not prevent this).

Re: SM RCon (updated 2012-03-10)

Quote:

Originally Posted by Bacardi (Post 1666271)

If you have same IP as Server, you can still log in rcon with right password, even you have get banned by rcon hacking (extension not prevent this).

Are you sure that the extension doesn't prevent that? I used local testing for most of my tests (and retested that scenario now), binding the server to my lan ip and then connecting to the same lan ip (no 127.0.0.1/loopback).