[MoggieX]

Howdy,

More a plee to a more experinced coder really, the server crontab plugin at http://forums.alliedmods.net/showthr...t=60046&page=3 fails to compile/run with the latest release of SM, dubbeh appears to ahve been away since last September and I have no idea on how to fix it, as its using timers which:

1. I have no idea on
2. I have no idea why its in a handle in the first place
3. I still have no idea
4. The handle reported issue is changing names (see errors below), its like its in the wrong format


In sc_module.sp at line 62:

PHP Code:

public OnPluginEnd ()
{
    if (g_hJobsTimer != INVALID_HANDLE)
    {
        KillTimer (g_hJobsTimer);
        CloseHandle (g_hJobsTimer);
        g_hJobsTimer = INVALID_HANDLE;
    }
.... 


Errors reported in the error log:

PHP Code:

L 01/26/2008 - 03:25:05: Info (map "de_dust2") (file "errors_20080126.log")
L 01/26/2008 - 03:25:05: [SM] Native "CloseHandle" reported: Handle 1a30033 is invalid (error 3)
L 01/26/2008 - 03:25:05: [SM] Displaying call stack trace for plugin "sc_module.smx":
L 01/26/2008 - 03:25:05: [SM]   [0]  Line 62, sc_module.sp::OnPluginEnd()
L 01/26/2008 - 03:25:06: Error log file session closed.
L 01/26/2008 - 03:28:39: SourceMod error session started
L 01/26/2008 - 03:28:39: Info (map "de_dust2_unlimited") (file "errors_20080126.log")
L 01/26/2008 - 03:28:39: [SM] Native "CloseHandle" reported: Handle 1cd500d4 is invalid (error 3)
L 01/26/2008 - 03:28:39: [SM] Displaying call stack trace for plugin "sc_module.smx":
L 01/26/2008 - 03:28:39: [SM]   [0]  Line 62, sc_module.sp::OnPluginEnd() 


Anyone fancy taking a look?

Matt

[teame06]

It pointless to be destorying timer in OnPluginEnd(). The reason why is because all handle are destory when the plugin ends. The plugin only ends when the plugin is unloaded/reloaded during map changes. That whole function is not required

[bl4nk]

Originally Posted by teame06 It pointless to be destorying timer in OnPluginEnd(). The reason why is because all handle are destory when the plugin ends. The plugin only ends when the plugin is unloaded/reloaded during map changes. That whole function is not required

According to ferret, this will only happen if the plugin has changed since it was last loaded. Otherwise all repeating timers will continue over to the next map change.

[teame06]

Originally Posted by bl4nk According to ferret, this will only happen if the plugin has changed since it was last loaded. Otherwise all repeating timers will continue over to the next map change.

Where as this plugin does it correctly. He does not overlap or keep adding on timers. This plugin only create one timer during OnPluginStart. Which is only called once. As this plugin is calling KillTimer and CloseHandle on the g_hJobsTimer. Which make the handle invalid when KillTimer is ran but g_hJobsTimer still has a handle number because it hasn't been cleared out of the variable g_hJobsTimer.

And I wasn't talking about the timer carrying over to the next map. I was talking about the unnecessary need to Kill the timer in OnPluginEnd. The core will do that for you when the plugin is unloaded.

[MoggieX]

OoO, so if I commend out the killtimer function (as it'll do it anyway), prob resolved?!

public OnPluginEnd () { if (g_hJobsTimer != INVALID_HANDLE) { // KillTimer (g_hJobsTimer); CloseHandle (g_hJobsTimer); g_hJobsTimer = INVALID_HANDLE; }

Appears to compile ok now, will check on our servers.

Thanks,

Matt