[Xanimos]

I request being able to get the query string that was executed.

This is usefull for finding out what was wrong in the query that it failed to execute.

Just something like SQL_GetQueryString(Handle:QueryHandle , Query[] , len)

[EDIT] Also once this is done, may I please have a linux build of this? Thanks.

[Freecode]

Hows is this different from the query that you build?

[Xanimos]

Well two different ways.
1) ThreadQuery() - Yes you do have to format your own query, but the error will be found in another function when you don't have the var, unless it's global.

2) PrepareQuery() - has format built right in it so you don't have a var for it.

[Freecode]

What im saying is. If you want to know the query you build you can do like

format(query, 255, "SELECT *.......field = %s",name);
SQL_PrepareQuery ( Handle, query);

and you will have your query.
And yes you would have to store them globaly. So i guess then this would be a good request

[Xanimos]

Originally Posted by Freecode What im saying is. If you want to know the query you build you can do like format(query, 255, "SELECT *.......field = %s",name); SQL_PrepareQuery ( Handle, query); and you will have your query. And yes you would have to store them globaly. So i guess then this would be a good request

Well it would have to be

format(query, 255, "SELECT *.......field = %s",name);
SQL_PrepareQuery ( Handle, "%s" , query);

So you don't get bad formatting errors.

But my request still stands.

This will be very helpful when dealing with multiple plugin using one function for the errors.

[BAILOPAN]

Marked as a valid request, this'll go into the next release. I'll update this post when it's in SVN.

[Xanimos]

Just an update.

I attached the updated files that can be committed to the SVN.
Files included in the .zip:

• basic_sql.cpp
• sqlx.inc

But for reference here is the function that was added to basic_sql.cpp.

PHP Code:

static cell AMX_NATIVE_CALL SQL_GetQueryString(AMX *amx, cell *params)
{
    AmxQueryInfo *qInfo = (AmxQueryInfo *)GetHandle(params[1], Handle_Query);
    if (!qInfo)
    {
        MF_LogError(amx, AMX_ERR_NATIVE, "Invalid handle: %d", params[1]);
        return 0;
    }

    MF_SetAmxString(amx , params[2], qInfo->pQuery , params[3]);

    return 1;
} 


So this can be locked after it's committed.

[BAILOPAN]

FYI, your patch passes the query pointer in, that'll probably crash at best ;)
You need to actually change the ISQLDriver/IQuery API around. View the changes if you're interested.

This is committed as Revision 2916. Thanks for the suggestion!