Raised This Month: $51 Target: $400
 12% 

Easier/efficient way to submit patches.


Post New Thread Reply   
 
Thread Tools Display Modes
Author Message
KyleS
SourceMod Plugin Approver
Join Date: Jul 2009
Location: Segmentation Fault.
Old 05-10-2010 , 17:05   Easier/efficient way to submit patches.
Reply With Quote #1

Besides creating multiple tickets on the GoogleCode repo, is there any faster way that people can submit patches to fix errors with Zombie:Reloaded?

Last edited by KyleS; 05-10-2010 at 17:06. Reason: My spelling sucks :|
KyleS is offline
rhelgeby
Veteran Member
Join Date: Oct 2008
Location: 0x4E6F72776179
Old 05-10-2010 , 17:38   Re: Easier/efficient way to submit patches.
Reply With Quote #2

Well, patches are not implemented faster than the developers are working. They must be approved and tested before we implement them.

But patches are of course always welcome.

The proper way to give us patches (which is easier for us to handle):
  1. Make a clone of our dev/stable repository, and make sure you have a updated repository before starting. We prefer patches for the development branch. Patches can be ported to the stable branch if they are compatible. Important: Do not mix dev and stable repositories, they are different and incompatible branches (changes in one branch cannot just be copied to another one). If you use the console version, the command is:
    hg clone <remote source repos (one of our repositories at Google Code)> <local destination folder>
  2. Do your work.
  3. Commit. You may commit multiple times if you're working on multiple stuff to separate your work into separate revisions.
    hg commit -u "<your name>" -m "<short description of the work done>"
  4. Export what you committed to a file in unified diff format (done by default in Mercurial). It should look like this: http://en.wikipedia.org/wiki/Unified...Unified_format
    hg export -o my_work.patch <my revision(s)>
  5. Make a new ticket in our issue tracker and attach the patch file. Also tell us which branch it's based on (dev or stable).

To do this you need Mercurial (Linux, command line tool) or TortoiseHG (Windows, GUI + command line tool) to be installed.

Again, everyone are welcome to submit fixes/features for ZR. However they have to be reviewed and approved by us before they are eventually implemented in the official version.

Update - 2010.09.20:
We hope that there are someone interesting in learning how ZR work, because we will need more developers soon. If you are interested, do like I did and read the entire source, file by file. There are comments in plain english that explain what the code does (mostly for beginners, but also to help us remember what the code does).
__________________
Richard Helgeby

Zombie:Reloaded | PawnUnit | Object Library
(Please don't send private messages for support, they will be ignored. Use the forum.)

Last edited by rhelgeby; 09-20-2010 at 14:32.
rhelgeby is offline
Send a message via MSN to rhelgeby
KyleS
SourceMod Plugin Approver
Join Date: Jul 2009
Location: Segmentation Fault.
Old 05-10-2010 , 17:51   Re: Easier/efficient way to submit patches.
Reply With Quote #3

Sounds good, I'll grab the latest dev and give it a whirl.
KyleS is offline
rhelgeby
Veteran Member
Join Date: Oct 2008
Location: 0x4E6F72776179
Old 09-20-2010 , 14:33   Re: Easier/efficient way to submit patches.
Reply With Quote #4

Just did a small review in my post and added a notice.
__________________
Richard Helgeby

Zombie:Reloaded | PawnUnit | Object Library
(Please don't send private messages for support, they will be ignored. Use the forum.)
rhelgeby is offline
Send a message via MSN to rhelgeby
KyleS
SourceMod Plugin Approver
Join Date: Jul 2009
Location: Segmentation Fault.
Old 09-21-2010 , 01:27   Re: Easier/efficient way to submit patches.
Reply With Quote #5



I did install Mercurial, however I was told everything was being rewritten (for the new base) so I had stopped entertaining the idea. Is this still the case? or should I fire up Merc again and bug you guys some more
KyleS is offline
rhelgeby
Veteran Member
Join Date: Oct 2008
Location: 0x4E6F72776179
Old 09-21-2010 , 14:23   Re: Easier/efficient way to submit patches.
Reply With Quote #6

The dev branch is redesigned at the moment.
__________________
Richard Helgeby

Zombie:Reloaded | PawnUnit | Object Library
(Please don't send private messages for support, they will be ignored. Use the forum.)
rhelgeby is offline
Send a message via MSN to rhelgeby
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 08:50.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode