How to add comma ?

GreenZombie · **Author**

Hi, for example some zombie class have 4000 HP, i want to write 4,000
I try this - https://forums.alliedmods.net/showthread.php?t=267049 but not work... I copy this code:

PHP Code:


			
#include <amxmodx> 



new iMin = -2147483648; 

new iMax = 2147483647; 



public plugin_init()  

{ 

    new szNum[ 15 ]; 

     

    AddCommas( iMin , szNum , charsmax( szNum ) ); 

    server_print( "%d = %s" , iMin , szNum ); 

     

    AddCommas( iMax , szNum , charsmax( szNum ) ); 

    server_print( "%d = %s" , iMax , szNum ); 

} 



public AddCommas( iNum , szOutput[] , iLen ) 

{ 

    new szTmp[ 15 ] , iOutputPos , iNumPos , iNumLen; 

     

    if ( iNum < 0 ) 

    { 

        szOutput[ iOutputPos++ ] = '-'; 

        iNum = abs( iNum ); 

    } 

     

    iNumLen = num_to_str( iNum , szTmp , charsmax( szTmp ) ); 



    if ( iNumLen <= 3 ) 

    { 

        iOutputPos += copy( szOutput[ iOutputPos ] , iLen , szTmp ); 

    } 

    else 

    { 

        while ( ( iNumPos < iNumLen ) && ( iOutputPos < iLen ) )  

        { 

            szOutput[ iOutputPos++ ] = szTmp[ iNumPos++ ]; 

         

            if( ( iNumLen - iNumPos ) && !( ( iNumLen - iNumPos ) % 3 ) )  

                szOutput[ iOutputPos++ ] = ','; 

        } 

         

        szOutput[ iOutputPos ] = EOS; 

    } 

     

    return iOutputPos; 

}

and i created .sma file and i post this code in the .sma file after his i compiled the file, copy the .amxx file and paste .amxx file in folder :plugins" after this i write the .amxx file name in plugins.ini and not work

**Bugsy** · 08-05-2015 , 18:13 Re: How to add comma ?

I wrote that function. Show me how you're using it

Nano x · 11-21-2015 , 14:34 Re: How to add comma ?

how can i add comma to this plugin

redivcram · 11-21-2015 , 15:34 Re: How to add comma ?

Quote:

Originally Posted by Nano x

how can i add comma to this plugin

This is not your theead, wait for the answer for OP and you can do it with your plugin

**Bugsy** · 11-21-2015 , 16:00 Re: How to add comma ?

It's already done for you. Look at the OP's code in plugin_init().

AddCommas( the number , the string , max chars ).

PHP Code:


			
new iNumber = 100000;
new szNumberWithCommas[ 15 ];
AddCommas( iNumber , szNumberWithCommas , charsmax( szNumberWithCommas )
server_print( "%d with commas is %s" , iNumber , szNumberWithCommas )

Nano x · 11-21-2015 , 17:29 Re: How to add comma ?

but it is not working no comma, here is the original plugin

PHP Code:


			
#include <amxmodx>
#include <hamsandwich>
#include <colorchat>
#include <zombie_plague_advance>

#define PLUGIN_NAME "[ZP] Sniper Health"
#define PLUGIN_VERS "1.0"
#define PLUGIN_AUTH "hi!"

#define TASK_HEALTH 1234554321


public plugin_init() 
{
    register_plugin(PLUGIN_NAME, PLUGIN_VERS, PLUGIN_AUTH)

    // Fwd's
    RegisterHam(Ham_Spawn, "player", "Fwd_PlayerSpawn_Post", 1)
    RegisterHam(Ham_Killed, "player", "Fwd_PlayerKilled_Pre", 0)
}

public Fwd_PlayerSpawn_Post(id)
{
    if (task_exists(id+TASK_HEALTH))
        remove_task(id+TASK_HEALTH)
}

public Fwd_PlayerKilled_Pre(victim, attacker, shouldgib)
{
    if (task_exists(victim+TASK_HEALTH))
        remove_task(victim+TASK_HEALTH)
}

public zp_round_started(mode, id)
{
    if (mode != MODE_SNIPER)
        return
        
    if (!zp_get_user_sniper(id))
        return
        
    set_task(34.0, "Task_ShowHealth", id+TASK_HEALTH, _, _, "b")

}

public Task_ShowHealth(id)
{
    id -= TASK_HEALTH
    
    if (!zp_get_user_sniper(id))
        remove_task(id+TASK_HEALTH)
    
    ColorChat(0, GREY, "^x04[ZP]^x01 A ^x03Rapture^x01 Reminder ^x03@^x01 ^x04Sniper^x01 still has ^3%d ^x04health points!^x01", get_user_health(id))

}

**Bugsy** · 11-21-2015 , 17:31 Re: How to add comma ?

The function does not exist and is not called in that code

fysiks · 11-21-2015 , 17:32 Re: How to add comma ?

Post the code that you tried, not the original plugin (you already posted that one).

Nano x · 11-21-2015 , 17:46 Re: How to add comma ?

here is the one i have tried

PHP Code:


			
#include <amxmodx>
#include <hamsandwich>
#include <colorchat>
#include <zombie_plague_advance>

#define PLUGIN_NAME "[ZP] Sniper Health"
#define PLUGIN_VERS "1.0"
#define PLUGIN_AUTH "hi!"

#define TASK_HEALTH 1234554321

new iMin = -2147483648;
new iMax = 2147483647;

public plugin_init() 
{
    register_plugin(PLUGIN_NAME, PLUGIN_VERS, PLUGIN_AUTH)
         new szNum[ 15 ];
    
         AddCommas( iMin , szNum , charsmax( szNum ) );
         server_print( "%d = %s" , iMin , szNum );
    
         AddCommas( iMax , szNum , charsmax( szNum ) );
         server_print( "%d = %s" , iMax , szNum );
    
    // Fwd's
    RegisterHam(Ham_Spawn, "player", "Fwd_PlayerSpawn_Post", 1)
    RegisterHam(Ham_Killed, "player", "Fwd_PlayerKilled_Pre", 0)
}

public Fwd_PlayerSpawn_Post(id)
{
    if (task_exists(id+TASK_HEALTH))
        remove_task(id+TASK_HEALTH)
}

public Fwd_PlayerKilled_Pre(victim, attacker, shouldgib)
{
    if (task_exists(victim+TASK_HEALTH))
        remove_task(victim+TASK_HEALTH)
}

public zp_round_started(mode, id)
{
    if (mode != MODE_SNIPER)
        return
        
    if (!zp_get_user_sniper(id))
        return
        
    set_task(34.0, "Task_ShowHealth", id+TASK_HEALTH, _, _, "b")

}

public Task_ShowHealth(id)
{
    id -= TASK_HEALTH
    
    if (!zp_get_user_sniper(id))
        remove_task(id+TASK_HEALTH)
    
    ColorChat(0, GREY, "^x04[ZP]^x01 A ^x03Rapture^x01 Reminder ^x03@^x01 ^x04Sniper^x01 still has ^3%d ^x04health points!^x01", get_user_health(id))

}
public AddCommas( iNum , szOutput[] , iLen )
{
    new szTmp[ 15 ] , iOutputPos , iNumPos , iNumLen;
    
    if ( iNum < 0 )
    {
        szOutput[ iOutputPos++ ] = '-';
        iNum = abs( iNum );
    }
    
    iNumLen = num_to_str( iNum , szTmp , charsmax( szTmp ) );

    if ( iNumLen <= 3 )
    {
        iOutputPos += copy( szOutput[ iOutputPos ] , iLen , szTmp );
    }
    else
    {
        while ( ( iNumPos < iNumLen ) && ( iOutputPos < iLen ) ) 
        {
            szOutput[ iOutputPos++ ] = szTmp[ iNumPos++ ];
        
            if( ( iNumLen - iNumPos ) && !( ( iNumLen - iNumPos ) % 3 ) ) 
                szOutput[ iOutputPos++ ] = ',';
        }
        
        szOutput[ iOutputPos ] = EOS;
    }
    
    return iOutputPos;
}

**Bugsy** · 11-21-2015 , 17:57 Re: How to add comma ?

The function definitely worked in the past, but now it's adding two negative signs and trimming off a number on the end. Did the functionality of abs() change or break? It should return the value from 0, but per func wiki:

Code:

Absolute value of x (x if it is greater than 0, -x otherwise).

Which means it essentially does nothing.

Edit: Ok, I was misreading this. -x = -(-1235) and will return a positive and the function is working. But, it does not work on the specific value being used in the test which is the lower boundary of what can be stored in a signed long -2147483648.

There should never be a negative value returned from abs().

Code:

In mathematics, the absolute value or modulus |x| of a real number x 
is the non-negative value of x without regard to its sign. Namely, |x| = x for a 
positive x, |x| = −x for a negative x (in which case −x is positive), and |0| = 0. 
For example, the absolute value of 3 is 3, and the absolute value of −3 is also 3. 
The absolute value of a number may be thought of as its distance from zero.

Use this:

PHP Code:


			
    
public AddCommas( iNum , szOutput[] , iLen )
{
    new szTmp[ 17 ] , iOutputPos , iNumPos , iNumLen;
    
    //if ( iNum < 0 )
    //{
    //    szOutput[ iOutputPos++ ] = '-';
    //    iNum = abs( iNum );
    //}
    
    iNumLen = num_to_str( iNum , szTmp , charsmax( szTmp ) );
    
    if ( iNumLen <= 3 )
    {
        iOutputPos += copy( szOutput[ iOutputPos ] , iLen , szTmp );
    }
    else
    {
        while ( ( iNumPos < iNumLen ) && ( iOutputPos < iLen ) ) 
        {
            szOutput[ iOutputPos++ ] = szTmp[ iNumPos++ ];
            
            if( ( iNumLen - iNumPos ) && !( ( iNumLen - iNumPos ) % 3 ) ) 
                szOutput[ iOutputPos++ ] = ',';
        }
            
        szOutput[ iOutputPos ] = EOS;
    }
    
    return iOutputPos;
}