[koshmel]

How read Binary data(JPG. DEM file)?
i use

decl String:Buff[10000];
while (!IsEndOfFile(OFile))
        {
            ReadFileString(OFile,Buff,10000)
            SocketSend(socket,Buff);
        }

but it's wrong work with binary data.

[bl4nk]

Open the file with the mode "rb+".

[Kigen]

Actually it appears some corruption occurs when sending/receiving binary data with this plugin.

[koshmel]

Originally Posted by bl4nk Open the file with the mode "rb+".

What's it's mean?)
How i read (:

decl Buff[1005];
new BuffL=0;
    while (!IsEndOfFile(OFile))
        {
            BuffL=ReadFile(OFile, Buff, 250,4);
            if (BuffL<250)
                {BuffL=FileSize(UploadFileName)%1000;}
                else{BuffL=1000;}
            SocketSend(socket,Buff,BuffL);
        }

It's work's)
maybe it's work only on 32-bit's system

[bl4nk]

OpenFile("file.txt", "rb+");

[sfPlayer]

As mentioned in the documentation (-> socket.inc), you have to pass the data length in SocketSend for binary data as you've done in your 2nd code snippet otherwise the extension will send only up to the first \0 character.

srcds is always running in 32bit mode, even if you are using a 64bit OS.

[StevoTVR]

There seems to be a memory leak with this extension. I'm working on a plugin that requires downloading a different page on a website for each connecting client. It works, but the server started crashing frequently and I noticed the committed memory was up to about 5Gb before the crashes.

Version: 2.4.0
OS: Fedora Core 9
Games: Insurgency, DoD:S, TF2

I used this plugin to test:

PHP Code:

#pragma semicolon 1
#include <sourcemod>
#include <socket>

#define PLUGIN_VERSION "1.0.0"

public Plugin:myinfo = 
{
    name = "Socket Test",
    author = "Unknown",
    description = "Test",
    version = "1.0",
    url = ""
}

public OnPluginStart()
{
    RegAdminCmd("sm_socket_test", CommandTest, ADMFLAG_CONVARS, "test");
}

public Action:CommandTest(client, args)
{
    // create a new tcp socket
    new Handle:socket = SocketCreate(SOCKET_TCP, OnSocketError);
    // open a file handle for writing the result
    new Handle:hFile = OpenFile("dl.htm", "wb");
    // pass the file handle to the callbacks
    SocketSetArg(socket, hFile);
    // connect the socket
    SocketConnect(socket, OnSocketConnected, OnSocketReceive, OnSocketDisconnected, "www.sourcemod.net", 80);
    return Plugin_Handled;
}

public OnSocketConnected(Handle:socket, any:hFile) {
    // socket is connected, send the http request

    decl String:requestStr[100];
    Format(requestStr, sizeof(requestStr), "GET /%s HTTP/1.0\r\nHost: %s\r\nConnection: close\r\n\r\n", "index.php", "www.sourcemod.net");
    SocketSend(socket, requestStr);
}

public OnSocketReceive(Handle:socket, String:receiveData[], const dataSize, any:hFile) {
    // receive another chunk and write it to <modfolder>/dl.htm
    // we could strip the http response header here, but for example's sake we'll leave it in

    WriteFileString(hFile, receiveData, false);
}

public OnSocketDisconnected(Handle:socket, any:hFile) {
    // Connection: close advises the webserver to close the connection when the transfer is finished
    // we're done here

    CloseHandle(hFile);
    CloseHandle(socket);
}

public OnSocketError(Handle:socket, const errorType, const errorNum, any:hFile) {
    // a socket error occured

    LogError("socket error %d (errno %d)", errorType, errorNum);
    CloseHandle(hFile);
    CloseHandle(socket);
} 


Every time I ran the command, the committed memory increased by about 20Mb. So there's either a memory leak in the extension or I'm doing something wrong.

Any help would be appreciated.

[Scipio]

I've been running this extension for sometime now with no problems, now that I have moved to a new game provider it's causing players to get blocked from my server with the message: client dropped from server. I read somewhere that it's caused by firewall settings on the server, could I get all the details about this so I can get my provider to fix this, thanks.

[sfPlayer]

I can reproduce the memory leak, but I can't find its cause. The socket extension's allocations are mostly below 100Byte, the largest is the 4kB receive buffer. I've also tried Valgrind without success.

The memory stays allocated even after I unload the socket extension, maybe there is a problem within SM.

m@mkpc:~/srcds$ cat /proc/22220/status |grep VmSize
VmSize: 161216 kB
>sm_socket_test
m@mkpc:~/srcds$ cat /proc/22220/status |grep VmSize
VmSize: 177724 kB
>sm_socket_test
m@mkpc:~/srcds$ cat /proc/22220/status |grep VmSize
VmSize: 194116 kB
>sm exts unload 4
>sm exts unload 4 910
m@mkpc:~/srcds$ cat /proc/22220/status |grep VmSize
VmSize: 194056 kB

[sfPlayer]

I've got two solutions, one requires SourceMod to be patched, the other one needs some ugly workaround.