[Nextra]

PHP Code:

clamp( iVar, 1, g_iMaxPlayers ) != ( 1 <= iVar <= g_iMaxPlayers ) 


Example:

PHP Code:

new iVar = 100;
new bool:bResult, iResult;

// g_iMaxPlayers = 32

bResult = ( 1 <= iVar <= g_iMaxPlayers );
iResult = clamp( iVar, 1, g_iMaxPlayers );

// bResult = false
// iResult = 32 (aka true, check would be incorrect) 


[Doc-Holiday]

To be completly honest with you guys.... I dont under stand why the hell to add in the whole mp_friendly fire...

If it is set to 0 take damage for teammates is set to 0


reguardless it still is just as efficient... and its been running great i have it on all 6 of my servers. no errors.

[Jon]

PHP Code:

if(    is_user_connected( attacker ) // in fact this check is safer than on check player range !!
    &&    cs_get_user_team(attacker) == cs_get_user_team(victim)
    &&    get_pcvar_num(friendlyFire)    ) 


mp_friendlyfire should be the very first check. It will make it more efficient because you shouldn't do anything in the function when it's set to 0. Although it's a trivial improvement.

edit: read below

[ConnorMcLeod]

Considering that most damage are normally done to enemy, i don't think the first check should be ff cvar.
Anyway the forward won't be called so often.

[Doc-Holiday]

Originally Posted by ConnorMcLeod Considering that most damage are normally done to enemy, i don't think the first check should be ff cvar. Anyway the forward won't be called so often.

Not to mention if it was turned off its still going to fire the event...

When ff is off and shooting your teamate it wont show anything as in they didnt take damage

I ran a server print with ff off and shot my teammates and didnt show a thing... i went to shoot bad guys and bam it showed... so with ff off it dosent even fire team attacks just the other guys so there for it goes anyways...

It only checks if valid and same team... once not same team it stops...

If i dont check valid first can mess stuff up.. so once it checks teams it should be fine.

[Jon]

Sense

That made none.

[Doc-Holiday]

Originally Posted by Jon Sense That made none.

With friendly fire off.... You shooting a teammate dosent register ham_takedamage

Shooting your enemy will fire and on the second check it comes back negitive and stops.

There fore checking friendly fire var first is not going to make a difference efficiency wise.

[Jon]

Originally Posted by NcB_Sav With friendly fire off.... You shooting a teammate dosent register ham_takedamage

That's wrong, test it. That's exactly why I told you to check it.

[Doc-Holiday]

Originally Posted by Jon That's wrong, test it. That's exactly why I told you to check it.

o well the checks in there so yea

[Hunter-Digital]

Originally Posted by Nextra PHP Code: clamp( iVar, 1, g_iMaxPlayers ) != ( 1 <= iVar <= g_iMaxPlayers )  Example: PHP Code: new iVar = 100; new bool:bResult, iResult;   // g_iMaxPlayers = 32   bResult = ( 1 <= iVar <= g_iMaxPlayers ); iResult = clamp( iVar, 1, g_iMaxPlayers );   // bResult = false // iResult = 32 (aka true, check would be incorrect)

I did not say I was going to assign that to the variable... that was just the condition...

new cvar = 5;
 
/* is... */
cvar = clamp(1, 3);
 
/* slower than... */
 
if(cvar > 3)
   cvar = 3
 
if(cvar < 0)
   cvar = 0
 
/* or... */
 
cvar = (cvar > 3 ? 3 : (cvar < 0 ? 0 : cvar))
 
/* ??? */

But still, I don't know what I had in mind with that condition (X < Y < Z)... so anyway :} this is what I meant.