Raised This Month: $ Target: $400
 0% 

Zoomless Announcer


Post New Thread Reply   
 
Thread Tools Display Modes
BOYSplayCS
BANNED
Join Date: Apr 2008
Location: Gainesville, FL
Old 02-20-2009 , 07:10   Re: Zoomless Announcer
Reply With Quote #21

But can't you display the word "No-Scoped" in the HUD message?
BOYSplayCS is offline
Costin83
Senior Member
Join Date: Jul 2008
Location: Romania
Old 02-20-2009 , 09:02   Re: Zoomless Announcer
Reply With Quote #22

Quote:
Originally Posted by BOYSplayCS View Post
But can't you display the word "No-Scoped" in the HUD message?
You can change it however you want, just edit....
Costin83 is offline
Send a message via Yahoo to Costin83
Old 02-20-2009, 09:07
Costin83
This message has been deleted by Costin83. Reason: I don't know... it double posted itself...
Arkshine
AMX Mod X Plugin Approver
Join Date: Oct 2005
Old 02-20-2009 , 09:56   Re: Zoomless Announcer
Reply With Quote #23

Some thoughts :

- You're using Ham which required Amxx 1.8.x and charsmax() is a macro from Amxx 1.8.0 ; so no need to include that.
Code:
//#define OLD_VERSION
Code:
#if defined OLD_VERSION
#define charsmax(%1)	sizeof %1 - 1
#endif
If you still want to include it do just :
Code:
#if !defined charsmax
    #define charsmax(%1)  ( sizeof( %1 ) - 1 )
#endif
- PluginEnabled() : You should use a define. Would be more faster than returning the value + call. Something like :
Code:
#define PluginEnabled  get_pcvar_num( toggle_plugin )
- fm_get_distance(), fm_get_user_money() : You should use a macro. Same reason above and you will remove the unecessary var. Something like :
Code:
#define GetDistance(%1,%2)  ( get_distance_f( %1, %2 ) * 0.0254 )
#define GetUserMoney(%1)    ( get_pdata_int( %1, OFFSET_MONEY ) )
- fm_set_user_money() : MSG_ONE -> MSG_ONE_UNRELIABLE ; flash ? 1 : 0 -> flash ; And you can remove return 1.

- ChatMessage() : static ? ; why formatex() before ? ; MSG_ONE_UNRELIABLE ; Your loop is useless since the checks are pointless, using MSG_BROADCAST would be enough.

- roundnew() ; You should keep { }

- client_putinserver(), client_disconnect() : Try to avoid to return something when no need ; something like :
Code:
    if ( PluginEnabled )
    {
        #if defined SAVE
            LoadZoomLessKills( id );
        #else
            g_CountPlayerZoomlessKills[ id ] = 0;
        #endif
    }
- show_topzoomless() : First for() why did use 'count' when you have 'i' ? Also after that you can use 'num' ; Use formatex().

- fw_prethink() : Did you try using CurWeapon or FM_PlaybackEvent ; it would be more appropriate to do that in such forward because prethink is called all the time and very often. Would be more efficient.

- ham_killed() : Same suggestions, avoid return and use {}.
- kills_compare() : use {}

And to finish : new const PLUGIN[] ; pointless, use #define.

As notes, would not a bad idea to use #define MAX_CLIENTS 32 and using [ MAX_CLIENTS + 1 ] ; instead of '33'.
And, to avoid to use cstrike since you're using already an offset, you can use m_iFOV ( 363 ).

Last edited by Arkshine; 02-20-2009 at 09:59.
Arkshine is offline
lowled
Senior Member
Join Date: Sep 2007
Old 02-20-2009 , 11:04   Re: Zoomless Announcer
Reply With Quote #24

add chatcolor like lj stats = in function of the distance u have normal, green or red anoouncement
__________________
lowled is offline
BOYSplayCS
BANNED
Join Date: Apr 2008
Location: Gainesville, FL
Old 02-20-2009 , 17:34   Re: Zoomless Announcer
Reply With Quote #25

Quote:
Originally Posted by Costin83 View Post
You can change it however you want, just edit....
I'm not stupid, I know that. I am talking about for other people, not just myself.
BOYSplayCS is offline
tuty
Veteran Member
Join Date: Jul 2008
Location: UK
Old 02-22-2009 , 08:14   Re: Zoomless Announcer
Reply With Quote #26

PHP Code:
 message_beginMSG_ONEg_msgsaytext_);
 
write_byte);
 
write_stringBuffer );
 
message_end(); 
MSG_ONE_UNRELIABLE
__________________
tuty is offline
Send a message via ICQ to tuty Send a message via AIM to tuty
Arkshine
AMX Mod X Plugin Approver
Join Date: Oct 2005
Old 02-22-2009 , 08:22   Re: Zoomless Announcer
Reply With Quote #27

I've already said that tuty, above.
Arkshine is offline
tuty
Veteran Member
Join Date: Jul 2008
Location: UK
Old 02-22-2009 , 09:42   Re: Zoomless Announcer
Reply With Quote #28

lol i didn't see that
__________________
tuty is offline
Send a message via ICQ to tuty Send a message via AIM to tuty
anakin_cstrike
Veteran Member
Join Date: Nov 2007
Location: Romania
Old 02-22-2009 , 13:23   Re: Zoomless Announcer
Reply With Quote #29

No shit ?! ^^
__________________

anakin_cstrike is offline
tuty
Veteran Member
Join Date: Jul 2008
Location: UK
Old 02-22-2009 , 13:35   Re: Zoomless Announcer
Reply With Quote #30

Quote:
Originally Posted by anakin_cstrike View Post
No shit ?! ^^
nam observat ma... ce plm :-j
__________________
tuty is offline
Send a message via ICQ to tuty Send a message via AIM to tuty
Reply



Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump


All times are GMT -4. The time now is 17:02.


Powered by vBulletin®
Copyright ©2000 - 2024, vBulletin Solutions, Inc.
Theme made by Freecode