[hleV]

#include <amxmodx>
#include <engine>
 
stock Engine_GiveItem(const Client, const Weapon[])
{
        new Entity = create_entity(Weapon);
 
        if (!is_valid_ent(Entity))
                return;
 
        DispatchSpawn(Entity);
        fake_touch(Entity, Client);
}

4 natives. No need for more if used carefully. I wonder if this can be treated as the best method after Fun's. I did some tests (but not too many) and it worked flawlessly.

THIS HAS NOTHING TO DO WITH USING ENGINE INSTEAD OF FUN!

[xPaw]

I'd use fun anyway, its faster than that stock

[ot_207]

Originally Posted by xPaw I'd use fun anyway, its faster than that stock

The fakemeta flu has passed now the engine flu season has come...

[Jon]

Originally Posted by hleV THIS HAS NOTHING TO DO WITH USING ENGINE INSTEAD OF FUN!

Then this thread is useless. Fun exists and is better/more efficient.

[Arkshine]

Well, there is not really a reason to do that when you can use give_item() directly for sure.

GiveNamedItem() from HLSDK :

void CBasePlayer::GiveNamedItem( const char *pszName )
{
    edict_t *pent;

    int istr = MAKE_STRING(pszName);

    pent = CREATE_NAMED_ENTITY(istr);
    if ( FNullEnt( pent ) )
    {
        ALERT ( at_console, "NULL Ent in GiveNamedItem!\n" );
        return;
    }
    VARS( pent )->origin = pev->origin;
    pent->v.spawnflags |= SF_NORESPAWN;

    DispatchSpawn( pent );
    DispatchTouch( pent, ENT( pev ) );
}

It seems you forget to add the SF_NORESPAWN flag. About the origin, I'm not sure to understand if it's really needed.

[ConnorMcLeod]

Full conversion needs both engine and fakemeta, to limit natives calls.
But fun is the only one that should be used.

PHP Code:

GiveNamedItem( id, const pszName[] )
{
    new iEnt = create_entity(pszName)
    if( !iEnt ) // create_entity returns 0 on failure
    {
        engfunc(EngFunc_AlertMessage, at_console, "NULL Ent in GiveNamedItem!\n" )
        return
    }

    new Float:fVecOrigin[3]
    entity_get_vector(id, EV_VEC_origin, fVecOrigin)
    entity_set_vector(iEnt, EV_VEC_origin, fVecOrigin) // don't need SetOrigin as you spawn it later
    entity_set_int(iEnt, EV_INT_spawnflags, entity_get_int(iEnt, EV_INT_spawnflags) | SF_NORESPAWN)

    DispatchSpawn( iEnt )
    fake_touch( iEnt, id )
} 


[Arkshine]

I'm not sure that EngFunc_AlertMessage would be useful here. I would use log_amx.

[Hawk552]

Or you could just stop fretting over these 0.00001% optimizations and write whatever is easiest. I wonder how many plugins could have been written in the time that people used to pointlessly optimize instead.

[SnoW]

Originally Posted by Hawk552 Or you could just stop fretting over these 0.00001% optimizations and write whatever is easiest. I wonder how many plugins could have been written in the time that people used to pointlessly optimize instead.

Since all new plugins suck, people focuse to make the old ones better.

[Styles]

Originally Posted by SnoW Since all new plugins suck, people focuse to make the old ones better.

Correct.

Hawk, not everyone can come up with an idea to build an entire role playing idea like you and somehow make it successful. I mean I could, and a few more here, you know who you are, but fuck it. It's not worth it and to be honest, most of the members here don't deserve it. There are a bunch of new people who are ignorant, rude and stupid. I refuse to help anyone like this. I don't care what you guys say about it but that's my feeling.

And Hawk, don't say you don't care about optimizations. You were on this bandwagon at one point too. Look at ApolloRP, besides the fact that the first datalayer was basically a prototype, you did redo it and in fact optimization a lot of it. You also did to the core and many other parts of it.