[shine771]

Echoooo
0.8

- Description -

This plugin automatically makes echoes in large rooms, tunnels, sewers etc.

- Cvars -

amx_echo_roomtype <0 - 28> <Echo type> <Def: 3>

- Notes -

It's not perfect. Not even close to perfect. In my opinion, you cant get a perfect echo without placing env_sounds or defining echo zones manually, and to do it automatically, it would take up too much resources. There is a serious bug. If player is in a "echo zone" and leaves it'll still have echo joining other servers. To fix it you have to type "room_type 0" in console. The bad thing with amxx is that you cant catch the disconnect event and execute client commands before user disconnects. I don't care if this gets unapproved, as it probably will, because it messes up client settings. I just wanted to give a try at to make this. Maybe someone will use it though.
It worked perfect in cs_militia sewers, my gf_hellschamber map for GF and de_dust2 tunnels. There were some small bugs in de_dust though.

Inspired by This request.

[alan_el_more]

good plugin and idea

[joaquimandrade]

Tell me one thing:

Didn't you meant, instead of:

PHP Code:

is_sky_above(Float:Origin[3],Float:Dist) { 


PHP Code:

is_sky_above(Float:Origin[3],&Float:Dist) { 


[shine771]

I have been scripting for a while but i've never came across something like this. Can you explain what it's used for?

[joaquimandrade]

Originally Posted by shine771 I have been scripting for a while but i've never came across something like this. Can you explain what it's used for? Does it do the same thing that this does, or something else? is_sky_above(Float:Origin[3],Float:Dist = 0.0)

No. In a function header, having a cell variable declared as &variable, means that the function will be able to change its value. ("Pass by reference". Opposed to "Pass by value")

I asked you because you are doing:

PHP Code:

Dist += SKYCHECK_STEP 


Inside the function so, if you want to change it's value, you have to pass it by reference.
___

I was looking at your code and you seriously need to improve that function (is_sky_above).

Why are you adding SKYCHECK_STEP inside a loop to the Z index instead of doing a long trace?

[shine771]

Ok thanks . Updated. About that trace. I didn't thought of that at that moment. I'll update it asap.

[joaquimandrade]

Originally Posted by shine771 Ok thanks . Updated.

You must understand what you are doing. Your algorithm has more flaws, and inconsistencies:

PHP Code:

//If distance is smaller
if(Dist > MIN_ECHO_DISTANCE) { 


Then

PHP Code:

if(is_sky_above(tEnd,Dist)) { 


(You are calculating if is_sky_above for all traced points that are in a "echo distance")

Why?

[shine771]

Updated.

To check if player is in some kind of a room. I didn't really thought why i did it. I just made this plugin in ~20-30minutes. Double checked the code, tested and submitted it here. Don't ask why i did it. Tell me a better way.

[joaquimandrade]

Originally Posted by shine771 Updated. To check if player is in some kind of a room. I didn't really thought why i did it. I just made this plugin in ~20-30minutes. Double checked the code, tested and submitted it here. Don't ask why i did it. Tell me a better way.

Here is my try on improving your code.

is_sky_above is still unfixed, and the algorithm is still far from perfect. Anyway, I guess that a perfect algorithm can't be made for this.

Other thing: probably some guy that knows amxmodx better than me can tell you a consistent way of doing this:

PHP Code:

client_cmd(id,"room_type 0") 


[shine771]

Omg, i posted the wrong .sma.. Updating now. Shouldn't you use Ham or Fakemeta instead of engine? I removed extra sky checks. Now it works great. About those echo points: