[RaT3D]

Description:
TeamCommands is a simple plugin which lets a client join / change teams by typing a command in chat. I originally created the plugin under the name NineTyNine, I called it QuickJoin. But I've decided to update the name, and I've changed a bit in the coding.

Commands:
There's quite a few commands to choose between.
Spectator Mode / AFK:

• !spec
• !spectate
• !away
• !afk

Counter-Terrorist

• !ct
• !counterterrorist

Terrorist

• !t
• !terrorist

ConVars:
There's one ConVar, which shows the version of the plugin.

• sm_qj_version

This plugin is similar to:
- https://forums.alliedmods.net/showthread.php?p=1130434
But this one works for CSS. Thanks for the inspiration!

[Drixevel]

Looks good! Only thing I would recommend you do is check if the client is valid, alive, etc when they use the commands.

[RaT3D]

Originally Posted by r3dw3r3w0lf Looks good! Only thing I would recommend you do is check if the client is valid, alive, etc when they use the commands.

But the client do not have to be alive to change team?

[TnTSCS]

He was throwing things out there that you should consider...

if the command "sm_ct" is issued by a console user (someone from HLSW for example), then the following error would be thrown:

L 02/12/2014 - 08:23:27: Info (map "de_dust2_only_b") (file "errors_20140212.log")
L 02/12/2014 - 08:23:27: [SM] Native "ClientCommand" reported: Client index 0 is invalid
L 02/12/2014 - 08:23:27: [SM] Displaying call stack trace for plugin "teamcommands.smx":
L 02/12/2014 - 08:23:27: [SM]   [0]  Line 49, /home/groups/alliedmodders/forums/files/2/4/4/4/7/0/130517.attach::TCTurnClientToCounterTerrorist()

Using something like this should help:

PHP Code:

YourCommandCallback(client, args)
{
    if (!IsValidPlayer(client))
    {
        return Plugin_Handled;
    }
    
    // Rest of your code here
}

bool:IsValidPlayer(client)
{
    if (!(1 <= client <= MaxClients) || !IsClientConnected(client))
    {
        return false;
    }
    
    return IsClientInGame(client);
} 


Also, you have semicolons on all but 1 line - using #pragma semicolon 1 might be a good idea to help you a tad