[motto]

God Job!

[TheAvengers2]

Hello, I'd suggest the following revision to your code.

stock CS_GetClientClanTag(client, String:buffer[], size)
{
    if(!IsValidEdict(client)) return;
    static String:startprop[64];
    static offset = -1;
    
    if (startprop[0] == '\0' || offset == -1)
    {
        new Handle:conf = LoadGameConfigFile("cssclantags");
        if (conf == INVALID_HANDLE)
        {
            ThrowError("Cannot find gamedata/cssclantags.txt");
            return;
        }
        
        if (!GameConfGetKeyValue(conf, "ClanTagStart", startprop, sizeof(startprop))
            || (offset = GameConfGetOffset(conf, "ClanTagStartOffset")) == -1)
        {
            CloseHandle(conf);
            ThrowError("Could not find either ClanTagStart or ClanTagStartOffset in gamedata file");
            return;
        }
        
        CloseHandle(conf);
        
        new start = FindSendPropInfo("CCSPlayer", startprop);
        if (start == -1)
        {
            ThrowError("Could not find netprop \"%s\" on CCSPlayer", startprop);
            return;
        }
        
        offset += start;
    }
    
    GetEntDataString(client, offset, buffer, size);
}

[psychonic]

Originally Posted by TheAvengers2 Hello, I'd suggest the following revision to your code. stock CS_GetClientClanTag(client, String:buffer[], size) { if(!IsValidEdict(client)) return; static String:startprop[64]; static offset = -1; if (startprop[0] == '\0' || offset == -1) { new Handle:conf = LoadGameConfigFile("cssclantags"); if (conf == INVALID_HANDLE) { ThrowError("Cannot find gamedata/cssclantags.txt"); return; } if (!GameConfGetKeyValue(conf, "ClanTagStart", startprop, sizeof(startprop)) || (offset = GameConfGetOffset(conf, "ClanTagStartOffset")) == -1) { CloseHandle(conf); ThrowError("Could not find either ClanTagStart or ClanTagStartOffset in gamedata file"); return; } CloseHandle(conf); new start = FindSendPropInfo("CCSPlayer", startprop); if (start == -1) { ThrowError("Could not find netprop \"%s\" on CCSPlayer", startprop); return; } offset += start; } GetEntDataString(client, offset, buffer, size); }

Why would you pass it an invalid client, let alone an invalid edict?

Edit: not to mention that throwing an error would be the appropriate action, whether it be from the stock or letting SM do it, rather than just ignoring.

[ShufflexDD]

public OnClientSettingsChanged(client)
{
	CS_SetClientClanTag(client, "Top 5ive");
}

in my logs:

L 09/18/2011 - 20:27:24: [SM] Displaying call stack trace for plugin "test.smx":
L 09/18/2011 - 20:27:24: [SM]   [0]  Line 42, C:\Users\Тёма\Desktop\Top 5ive\DeathRun\SourceMod\addons\sourcemod\scripting\include\cssclantags.inc::CS_GetClientClanTag()
L 09/18/2011 - 20:27:24: [SM]   [1]  Line 16, C:\Users\Тёма\Desktop\Top 5ive\DeathRun\SourceMod\addons\sourcemod\scripting\loxn.sp::OnClientSettingsChanged()

how to fix it?

[Peace-Maker]

You didn't post any error, only the backtrace.

[ShufflexDD]

how to do without these errors?

[Peace-Maker]

I'd fix the unknown error by checking, if the client is ingame before trying to set his clantag.

Why don't you just post the logged error?! Secret?

[ShufflexDD]

thank you!

Originally Posted by Peace-Maker Why don't you just post the logged error?! Secret?

what?

[Starbish]

Continuing only On Server which makes then by this function?

[psychonic]

Originally Posted by Starbish Continuing only On Server which makes then by this function?