[ConnorMcLeod]

I'm the author of that mod, and i have requested it to be trashed, that's why your plugin is in unapproved section, doesn't mean you can't support/update/improve it.

About the code :

switch with 1 case ???
players can take multiple weapons (no limit), unless i have read too fast
else continue; ???
menus could be static, and no reason to store all menu indexes ( for not static menus ) in the same global var
GiveWeapons doesn't need to be public
You don't need menu_item_getinfo, just use item and a table for weapons indexes.